CollapseViewHelper blocks collapsing of nested containers

[EvilBMP]

Right now, the CollapseViewHelper has the following condition:

collapse/Classes/ViewHelpers/CollapseViewHelper.php

Line 36 in 7117a86

if ($type instanceof GridColumnItem && !$type instanceof ContainerGridColumnItem) {

Why is the type ContainerGridColumnItem forbidden here? This blocks the ability to collapse container elements inside another container element.

Is this by design or a bug?

IMHO this condition should be if ($type instanceof GridColumnItem || $type instanceof ContainerGridColumnItem) {

I can provide a PR but wanted to discuss this first. Thanks.

[achimfritz]

i think it could be allowed (just drop the condition, ContainerGridColumnItem is also an instance of GridColumnItem because its derived).

Looks for me, some additionl work is neccessery, to configure EXT:container to use the Header Partial, (or use the VH), not sure, if figure out, let me know.

[EvilBMP]

Well, in my TCA override for the tt_content table, I added the following to every container configuration:

            ->addGridPartialPath(
                \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::isLoaded('collapse') ?
                    'EXT:collapse/Resources/Private/TemplateOverrides/Partials/' :
                    ''
            )

After changing the condition in the ViewHelper to if ($type instanceof GridColumnItem) as you mentioned, everything seemed to work.

But when I collapsed some child container elements in a bigger "outer container" the collapse state seems not persisted correctly. Because after switching pages and coming back to the page with nested container elements, the "outer container" is collapsed (which I didn't do) and after expanding some of the beforehand collapsed child containers were not collapsed anymore.

This behavior keeps the same, after "fixing" the collapsed states and switching pages again.

[achimfritz]

hm, this works for me, cannot see the bug you described (i have TYPO3 v13 container 3.2.1 and collapsed 2.0.1 (inkl. the change)

btw, adding configuration to every container can done by an event-listener like

<?php

declare(strict_types=1);

namespace Hotbytes\Accordion\EventListener;

use B13\Container\Events\BeforeContainerConfigurationIsAppliedEvent;
use TYPO3\CMS\Core\Attribute\AsEventListener;

#[AsEventListener]
final class BeforeContainerConfigurationIsAppliedListener
{
    public function __invoke(BeforeContainerConfigurationIsAppliedEvent $event): void
    {
        $event->getContainerConfiguration()->addGridPartialPath('EXT:accordion/Resources/Private/TemplateOverrides/Partials/');
    }
}