Skip to content

setup.py and requirements.txt have mismatched redfish version requirements #189

@berlikm

Description

@berlikm

Description

The setup.py file declares redfish>=2.1.4 in install_requires, but requirements.txt was recently updated to require redfish>=3.1.0.

This causes confusion when installing check_redfish as a package (via pip install git+https://github.com/bb-Ricardo/check_redfish), since pip reads dependencies from setup.py, not requirements.txt.

Current State

File redfish requirement Last updated
requirements.txt >=3.1.0 bd4e2c9 (last week)
setup.py >=2.1.4 028211b (last week, but not synced)

Expected Behavior

Both files should specify the same minimum version (redfish>=3.1.0).

Suggested Fix

Update setup.py line 15:

install_requires=[
    'redfish>=3.1.0',  # Changed from 2.1.4 to match requirements.txt
],

Environment

  • check_redfish version: 2.1.0
  • Installation method: pip install git+https://github.com/bb-Ricardo/check_redfish
  • Python: 3.12

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions