php 8.5: deprecated PDO constants and functions

[jamieburchell]

As per upcoming PHP 8.5 deprecations

There are a huge number of driver-specific constants and methods defined on the main PDO class; as examples, PDO::MYSQL_ATTR_USE_BUFFERED_QUERY, PDO::pgsqlCopyFromArray(). PHP 8.4 introduced driver-specific subclasses of PDO, and all of these are now defined in those subclasses.

PHP 8.5 deprecates usage of the PDO constants and methods in favor of those.

For interested parties there's a preliminary fix in this branch which has been lightly tested with PDO for MySQL (I usually use the mysqli driver). This change will require PHP >= 8.4.

The patch also returns the respective subclass where available, instead of the generic PDO class.

[NielBuys]

Applied to my fork. Thanks.

[rhickmott]

Is there any reason for the change from

new PDO($this->dsn, $this->username, $this->password, $this->options);

To
PDO::connect($this->dsn, $this->username, $this->password, $this->options);

in pdo_driver.php

I had already swapped the constants and it seems to function ok, I was wondering if there was a functional compatibility reason or if it was just personal preference.

[jamieburchell]

@rhickmott This is now the recommended way to connect. This way, you are returned a PDO subclass instance for drivers that support it.

[rhickmott]

Fair enougth :) I will take a look into it, just rasied it as I tried to keep everything as 'stock' as possible in our apps.

As an addition (looking at 8.5 Depreciations as there isn't one issue)

system\libraries\Xmlrpc.php
system\libraries\Xmlrpsc.php

Contain xml_parser_free()

You can either remove these or swap them to PHP_VERSION_ID < 80000 && xml_parser_free($parser);

[jamieburchell]

As an addition (looking at 8.5 Depreciations as there isn't one issue)

system\libraries\Xmlrpc.php system\libraries\Xmlrpsc.php

Contain xml_parser_free()

You can either remove these or swap them to PHP_VERSION_ID < 80000 && xml_parser_free($parser);

Yup. My fork removes these.