Revert "TUI: strip parenthetical FINAL CHECK labels; show Task complete marker"

This reverts commit 48be095.

Author: beacoder

python_agent_harness/tui/render.py

@@ -91,9 +91,7 @@ def _tool_result_preview(content: str) -> str:
 #
 # The header must be bracketed or start its own line: that keeps prose
 # like "let me do the final check" from truncating a real reply.
-# "Goal:", "**Goal:**", "**Goal**:", "`Goal` :", and labels carrying a
-# parenthetical before the colon ("Evidence (re-verified):")
-_FC_LABEL = r"[*_`]*[ \t]*(?:\([^)\n]*\)[ \t]*)?:"
+_FC_LABEL = r"[*_`]*[ \t]*:"  # "Goal:", "**Goal:**", "**Goal**:", "`Goal` :"
 _FC_HEADER = (
     r"(?:"
     r"(?:\*\*|__|#{1,6}[ \t]*)?"  # decoration before a bracketed header
@@ -264,12 +262,7 @@ def _build_history_rows(self, full: bool = False) -> list[Any]:
                     if stripped != body:
                         body = stripped
                         collapsed_reasoning = True
-                stripped = _strip_final_check(body)
-                # a reply that was ONLY the completion-check block
-                # leaves nothing behind — surface a done marker so the
-                # round doesn't render blank
-                check_only = stripped != body and not stripped.strip()
-                body = stripped
+                body = _strip_final_check(body)
                 if not full:
                     body = _tail_lines(body, 12)
                 if collapsed_reasoning:
@@ -295,9 +288,7 @@ def _build_history_rows(self, full: bool = False) -> list[Any]:
                             params = ""
                         label = f"tool: {tc.name}({params})" if params else f"tool: {tc.name}"
                         rows.append(Text(f"▶ {label}", style="magenta"))
-                if check_only:
-                    rows.append(Text("Task complete.", style="dim"))
-                elif body.strip():
+                if body.strip():
                     rows.append(Markdown(f"**assistant:** {body}", style=ASSISTANT_STYLE))
             elif m.role == "tool":
                 preview = _tool_result_preview(m.text())
@@ -347,12 +338,7 @@ def _stream_row(self) -> Text | None:
         """Live stream row (cheap Text, tail-capped)."""
         with self.lock:
             stream = self.stream_text
-        stripped = _strip_final_check(stream)
-        if stripped != stream and not stripped:
-            # the stream was only the completion-check block: replace
-            # the (now hidden) bookkeeping with a done marker
-            return Text("Task complete.", style="dim")
-        stream = stripped
+        stream = _strip_final_check(stream)
         if not stream:
             return None
         cap = self._visible_row_cap()

tests/tui/test_tui_render.py

@@ -220,10 +220,10 @@ def test_restored_injected_prompts_hidden(self):
     def test_nudge_and_final_check_hidden(self):
         """Harness bookkeeping is hidden from the panel: the injected
         completion-nudge user prompt and the assistant's [FINAL CHECK]
-        block never show up — a check-only reply renders as a "Task
-        complete." marker instead, and a reply carrying real content
-        keeps its content.  The stored messages are untouched — the
-        agent loop keeps working exactly as before."""
+        block never show up — even when the check block is the reply's
+        ONLY content (a reply carrying real content keeps its content).
+        The stored messages are untouched — the agent loop keeps
+        working exactly as before."""
         from python_agent_harness import config
 
         tui, buf = make_tui()
@@ -247,11 +247,10 @@ def test_nudge_and_final_check_hidden(self):
         self.assertIn("build the thing", out)
         self.assertIn("Done. All tests pass.", out)
         # the [FINAL CHECK] block is hidden even when it is the whole
-        # reply — a check-only message renders as the done marker
+        # reply — check-only messages never render
         self.assertNotIn("FINAL CHECK", out)
         self.assertNotIn("Status: SUCCESS", out)
         self.assertNotIn(config.NUDGE_MESSAGE, out)
-        self.assertIn("Task complete.", out)
         # the agent loop's history is untouched
         self.assertEqual(
             tui.session.last_messages[1].text(),
@@ -281,15 +280,13 @@ def test_final_check_markdown_variants_hidden(self):
             "[FINAL CHECK]\n- **Goal:** g\n- **Status:** SUCCESS\n- **Evidence:** e",
             "## Final Check\n\n- Goal: g\n- Status: SUCCESS\n- Evidence: e\n",
             "answer.\n\n[Final check]\n* `Goal`: g\n* `Status`: SUCCESS\n* `Evidence`: e",
-            "answer.\n\n[FINAL CHECK]\n- Goal: g\n- Status: SUCCESS\n- Evidence (re-verified): e",
         ]
         for text in variants:
             with self.subTest(text=text):
                 self.assertNotIn("Goal", _strip_final_check(text))
                 # no dangling markdown decoration left behind
                 self.assertNotIn("*", _strip_final_check(text))
         # a reply's real content survives the strip
-        self.assertEqual(_strip_final_check(variants[-2]), "answer.")
         self.assertEqual(_strip_final_check(variants[-1]), "answer.")
 
     def test_final_check_prose_mention_kept(self):
@@ -323,16 +320,14 @@ def test_final_check_without_header_kept(self):
         self.assertIn("Status: SUCCESS", out)
         self.assertIn("Evidence:", out)
 
-    def test_stream_pure_final_check_shows_marker(self):
-        """A stream that is only the [FINAL CHECK] block renders the
-        done marker instead of flashing bookkeeping or going blank."""
+    def test_stream_pure_final_check_hidden(self):
+        """A stream that is only the [FINAL CHECK] block never renders
+        — the row goes blank on the final reply instead of flashing
+        bookkeeping."""
         tui, _ = make_tui()
         tui.stream_text = "[FINAL CHECK]\n- Goal: x\n- Status: SUCCESS\n- Evidence: y"
         row = tui._stream_row()
-        self.assertIsNotNone(row)
-        self.assertIn("Task complete.", row.plain)
-        self.assertNotIn("FINAL CHECK", row.plain)
-        self.assertNotIn("Status: SUCCESS", row.plain)
+        self.assertIsNone(row)
 
     def test_reasoning_streams_normally(self):
         """While streaming, reasoning content shows up live like any