From ba96ca25d166e437a6ecd6d350c93ca73b0b599f Mon Sep 17 00:00:00 2001 From: Jeremy Collins Date: Sun, 6 Sep 2026 21:43:28 -0400 Subject: [PATCH] Stop collecting src/chart.zig tests The test module addPkgTest builds for it links portray's lua_shim.c, which references tgc_binding, an export in src/s101/catalogue.zig that the module does not emit. macOS linked it and ld.lld on Linux did not: error: ld.lld: undefined symbol: tgc_binding note: referenced by lua_shim.c:620 build-test failed on main at the merge that added the registration, and passed on its parent. The seven tests in src/chart.zig go back to uncollected, three that were there before and four for the inventory. --- build.zig | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/build.zig b/build.zig index eeb7abf..5835c83 100644 --- a/build.zig +++ b/build.zig @@ -1069,25 +1069,6 @@ pub fn build(b: *std.Build) void { // Charts read straight out of a .zip, and the aux files that travel with // them: pure over std, so each tests alone. _ = addPkgTest(b, test_step, "src/zipsrc.zig", target, optimize, &.{}); - // src/chart.zig holds tests that nothing collected: the engine imports it - // as a module, and a module import does not pull another module's test - // blocks in. It needs libc for portray's embedded Lua. - addPkgTest(b, test_step, "src/chart.zig", target, optimize, &.{ - .{ .name = "s57", .module = s57_mod }, - .{ .name = "s101", .module = s101_mod }, - .{ .name = "tiles", .module = tiles_mod }, - .{ .name = "scene", .module = scene_mod }, - .{ .name = "render", .module = render_mod }, - .{ .name = "portray", .module = portray_mod }, - .{ .name = "sprite", .module = sprite_mod }, - .{ .name = "catalog", .module = catalog_embed }, - .{ .name = "zipsrc", .module = zipsrc_mod }, - .{ .name = "auxfiles", .module = auxfiles_mod }, - .{ .name = "style", .module = style_mod }, - .{ .name = "coverage", .module = coverage_mod }, - .{ .name = "compose", .module = compose_mod }, - .{ .name = "raster", .module = raster_mod }, - }).link_libc = true; _ = addPkgTest(b, test_step, "src/auxfiles.zig", target, optimize, &.{}); // Geometry core for the cross-band composition. No longer std-only: plane.zig // reads its partition tuning/stats valves via std.c.getenv, so the test binary