Skip to content

Commit 616f2d8

Browse files
committed
GP-82 review updates
1 parent e360373 commit 616f2d8

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

3-0-spring-framework/3-1-1-dispatcher-servlet-initializer/src/test/java/com/bobocode/WelcomeWebAppTest.java renamed to 3-0-spring-framework/3-1-1-dispatcher-servlet-initializer/src/test/java/com/bobocode/WebAppConfigurationTest.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
import static org.junit.jupiter.api.Assertions.assertNotNull;
2222

2323
@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
24-
class WelcomeWebAppTest {
24+
class WebAppConfigurationTest {
2525

2626
@Test
2727
@Order(1)
@@ -124,7 +124,7 @@ void initializerWebConfigClasses() {
124124

125125
@Test
126126
@Order(11)
127-
@DisplayName("Proper Dispatcher Servlet mapping")
127+
@DisplayName("Dispatcher Servlet mapping is \"/\"")
128128
void dispatcherServletMapping() {
129129
WebAppInitializerWrapper webAppInitializerWrapper = new WebAppInitializerWrapper();
130130

@@ -153,7 +153,8 @@ void welcomeControllerMethodIsMarkedAsGetMethod() throws NoSuchMethodException {
153153
@Order(14)
154154
@DisplayName("WelcomeController Get method is marked properly")
155155
void welcomeControllerMethodMapping() throws NoSuchMethodException {
156-
GetMapping getMapping = WelcomeController.class.getDeclaredMethod("welcome").getAnnotation(GetMapping.class);
156+
GetMapping getMapping = WelcomeController.class
157+
.getDeclaredMethod("welcome").getAnnotation(GetMapping.class);
157158

158159
assertThat(getMapping.value()).contains("/welcome");
159160
}
@@ -162,7 +163,8 @@ void welcomeControllerMethodMapping() throws NoSuchMethodException {
162163
@Order(15)
163164
@DisplayName("WelcomeController Get method is marked as @ResponseBody")
164165
void welcomeControllerMethodIsMarkedAsResponseBody() throws NoSuchMethodException {
165-
ResponseBody responseBody = WelcomeController.class.getDeclaredMethod("welcome").getAnnotation(ResponseBody.class);
166+
ResponseBody responseBody = WelcomeController.class
167+
.getDeclaredMethod("welcome").getAnnotation(ResponseBody.class);
166168

167169
assertNotNull(responseBody);
168170
}

java-web-course-util/java-web-util/pom.xml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,6 @@
1010
<modelVersion>4.0.0</modelVersion>
1111

1212
<artifactId>java-web-util</artifactId>
13-
14-
<properties>
15-
<maven.compiler.source>11</maven.compiler.source>
16-
<maven.compiler.target>11</maven.compiler.target>
17-
</properties>
1813

1914
<dependencies>
2015
<dependency>

0 commit comments

Comments
 (0)