add HelloJspController tests and refactor viewResolverRegistryHasCorrectPrefixAndSuffix() method

Author: Ivan Virchenko

3-0-spring-framework/3-0-2-view-resolver/src/main/java/com/bobocode/controller/HelloJspController.java

@@ -0,0 +1,14 @@
+package com.bobocode.controller;
+
+import org.springframework.stereotype.Controller;
+import org.springframework.web.bind.annotation.GetMapping;
+import org.springframework.web.bind.annotation.RequestMapping;
+
+@Controller
+@RequestMapping
+public class HelloJspController {
+    @GetMapping
+    public String hello() {
+        return "hello";
+    }
+}

3-0-spring-framework/3-0-2-view-resolver/src/test/java/com/bobocode/HelloJspControllerTest.java

@@ -0,0 +1,88 @@
+package com.bobocode;
+
+import com.bobocode.config.ResolverConfig;
+import com.bobocode.controller.HelloJspController;
+import lombok.SneakyThrows;
+import org.junit.jupiter.api.*;
+import org.mockito.internal.configuration.ClassPathLoader;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.test.autoconfigure.web.servlet.WebMvcTest;
+import org.springframework.http.MediaType;
+import org.springframework.stereotype.Controller;
+import org.springframework.test.context.ContextConfiguration;
+import org.springframework.test.web.servlet.MockMvc;
+import org.springframework.test.web.servlet.result.MockMvcResultMatchers;
+import org.springframework.validation.support.BindingAwareModelMap;
+import org.springframework.web.bind.annotation.GetMapping;
+import org.springframework.web.bind.annotation.RequestMapping;
+
+import java.lang.reflect.Method;
+import java.util.Arrays;
+
+import static org.junit.jupiter.api.Assertions.*;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get;
+import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.*;
+
+@WebMvcTest
+@ContextConfiguration(classes = ResolverConfig.class)
+@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
+public class HelloJspControllerTest {
+
+    @Autowired
+    private MockMvc mockMvc;
+    private final HelloJspController helloJspController = new HelloJspController();
+
+    @Test
+    @Order(1)
+    @DisplayName("Class marked as @Controller")
+    void helloJspControllerClassMarkedAsController() {
+        Controller controller = HelloJspController.class.getAnnotation(Controller.class);
+        assertNotNull(controller);
+    }
+
+    @Test
+    @Order(2)
+    @DisplayName("Class marked as @RequestMapping")
+    void helloJspControllerClassMarkedAsRequestMapping() {
+        RequestMapping requestMapping = HelloJspController.class.getAnnotation(RequestMapping.class);
+        assertNotNull(requestMapping);
+    }
+
+    @Test
+    @Order(3)
+    @DisplayName("Method that get hello page is marker with @GetMapping")
+    void helloJspControllerHasMethodAnnotatedAsGetMapping() {
+        boolean hasAnnotation = Arrays.stream(HelloJspController.class.getMethods())
+                .anyMatch(method ->
+                        method.getAnnotation(GetMapping.class) != null
+                );
+        assertTrue(hasAnnotation);
+    }
+
+    @Test
+    @Order(4)
+    @SneakyThrows
+    @DisplayName("Get method returns view name \"hello\"")
+    void helloJspControllerMethodReturnsHelloViewName() {
+        Method method = Arrays.stream(HelloJspController.class.getMethods())
+                .filter(m -> m.getAnnotation(GetMapping.class) != null)
+                .findFirst()
+                .orElseThrow();
+
+        var viewName = method.invoke(helloJspController);
+
+        assertEquals("hello", viewName);
+    }
+
+    @Test
+    @Order(5)
+    @SneakyThrows
+    @DisplayName("GET method is completed ✅")
+    void getRequestShouldReturnStatusOkAndCorrectData() {
+        mockMvc.perform(get("/"))
+                .andExpect(status().isOk())
+                .andExpect(view().name("hello"))
+                .andExpect(MockMvcResultMatchers.forwardedUrl("/WEB-INF/views/hello.jsp"));
+    }
+}

3-0-spring-framework/3-0-2-view-resolver/src/test/java/com/bobocode/ViewResolverTest.java

@@ -3,6 +3,7 @@
 import com.bobocode.config.ResolverConfig;
 import lombok.SneakyThrows;
 import org.junit.jupiter.api.*;
+import org.mockito.Mockito;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.boot.test.autoconfigure.web.servlet.WebMvcTest;
 import org.springframework.context.annotation.ComponentScan;
@@ -21,13 +22,11 @@
 import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;
 import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.view;
 
-@WebMvcTest
-@ContextConfiguration(classes = {ResolverConfig.class})
 @TestMethodOrder(MethodOrderer.OrderAnnotation.class)
 public class ViewResolverTest {
 
-    @Autowired
-    private MockMvc mockMvc;
+    private final ResolverConfig config = new ResolverConfig();
+    private final ViewResolverRegistry resolverRegistry = Mockito.mock(ViewResolverRegistry.class);
 
     @Test
     @Order(1)
@@ -58,7 +57,7 @@ void classAnnotatedWithComponentScan() {
     @DisplayName("ComponentScan packages are indicated")
     void ComponentScanHasIndicatedPackages() {
         ComponentScan componentScan = ResolverConfig.class.getAnnotation(ComponentScan.class);
-        assertEquals("com.bobocode.resolver", componentScan.basePackages()[0]);
+        assertEquals("com.bobocode", componentScan.basePackages()[0]);
     }
 
     @Test
@@ -80,11 +79,9 @@ void isConfigurationClassContainsViewResolverMethod() {
     @Test
     @Order(7)
     @SneakyThrows
-    @DisplayName("Get request returns correct view name and URL")
-    void getRequestReturnCorrectUrlAndViewName() {
-        mockMvc.perform(get("/"))
-                .andExpect(status().isOk())
-                .andExpect(view().name("index"))
-                .andExpect(MockMvcResultMatchers.forwardedUrl("/WEB-INF/views/index.jsp"));
+    @DisplayName("View resolver registry has correct prefix and suffix")
+    void viewResolverRegistryHasCorrectPrefixAndSuffix() {
+        config.getClass().getMethod("configureViewResolvers", ViewResolverRegistry.class).invoke(config, resolverRegistry);
+        Mockito.verify(resolverRegistry).jsp("/WEB-INF/views/", ".jsp");
     }
 }