Skip to content

Commit f3f2f8d

Browse files
starfolkai[bot]starfolkbotclaude
authored
ci: fold test_transformers into the sharded nox job (#692)
## Summary - Drop the standalone `transformers-py` job; `test_transformers` now runs alongside every other session under the sharded `nox` matrix. - Move the Hugging Face model cache into the `nox` job so shards still avoid re-downloading models across runs. - Update `checks-passed` to no longer gate on `transformers-py`. ## Test plan - [ ] CI on this PR: confirm `test_transformers(...)` lands in some shard and passes on Linux. - [ ] Watch Windows shards — this is a scope expansion vs. the old Ubuntu-only job. If they flake, add a `session.skip` for `sys.platform == "win32"` in `noxfile.py:test_transformers`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- sfk:created-approved-by --> Created by @AbhiPrasad <!-- sfk:slack-thread --> [Slack thread](https://braintrustdata.slack.com/archives/C0AQDETAVT3/p1786736441809709?thread_ts=1786736441.809709&cid=C0AQDETAVT3) Co-authored-by: Starfolk <noreply@starfolk.ai> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
1 parent 4c64aed commit f3f2f8d

1 file changed

Lines changed: 3 additions & 27 deletions

File tree

.github/workflows/checks.yaml

Lines changed: 3 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -131,40 +131,18 @@ jobs:
131131
dir="$HOME/.cache/braintrust/livekit-server"
132132
mkdir -p "$dir"
133133
echo "BRAINTRUST_LIVEKIT_SERVER_DIR=$dir" >> "$GITHUB_ENV"
134-
- name: Run nox tests (shard ${{ matrix.shard }}/6)
135-
shell: bash
136-
run: |
137-
mise exec python@${{ matrix.python-version }} -- python ./py/scripts/nox-matrix.py ${{ matrix.shard }} 6 \
138-
--exclude-static-checks \
139-
--exclude-session-prefix test_transformers
140-
141-
transformers-py:
142-
runs-on: ubuntu-24.04
143-
timeout-minutes: 30
144-
strategy:
145-
fail-fast: false
146-
# Serialize jobs so later Python versions can restore the model cache
147-
# saved by the first job instead of downloading the same models in parallel.
148-
max-parallel: 1
149-
matrix:
150-
python-version: ["3.10", "3.11", "3.12", "3.13", "3.14"]
151-
steps:
152-
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
153-
- name: Setup Python environment
154-
uses: ./.github/actions/setup-python-env
155-
with:
156-
python-version: ${{ matrix.python-version }}
157134
- name: Cache Hugging Face models
158135
uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
159136
with:
160137
path: ~/.cache/huggingface/hub
161138
key: huggingface-transformers-${{ runner.os }}-${{ runner.arch }}-${{ matrix.python-version }}-${{ hashFiles('py/src/braintrust/integrations/transformers/test_transformers.py') }}
162139
restore-keys: |
163140
huggingface-transformers-${{ runner.os }}-${{ runner.arch }}-
164-
- name: Test Transformers integration
141+
- name: Run nox tests (shard ${{ matrix.shard }}/6)
165142
shell: bash
166143
run: |
167-
mise exec -- uv run --project ./py nox -f ./py/noxfile.py -s test_transformers
144+
mise exec python@${{ matrix.python-version }} -- python ./py/scripts/nox-matrix.py ${{ matrix.shard }} 6 \
145+
--exclude-static-checks
168146
169147
adk-py:
170148
uses: ./.github/workflows/adk-py-test.yaml
@@ -203,7 +181,6 @@ jobs:
203181
- static_checks
204182
- smoke
205183
- nox
206-
- transformers-py
207184
- adk-py
208185
- langchain-py
209186
- upload-wheel
@@ -230,7 +207,6 @@ jobs:
230207
check_result "static_checks" "${{ needs.static_checks.result }}"
231208
check_result "smoke" "${{ needs.smoke.result }}"
232209
check_result "nox" "${{ needs.nox.result }}"
233-
check_result "transformers-py" "${{ needs['transformers-py'].result }}"
234210
check_result "adk-py" "${{ needs['adk-py'].result }}"
235211
check_result "langchain-py" "${{ needs['langchain-py'].result }}"
236212
check_result "upload-wheel" "${{ needs['upload-wheel'].result }}"

0 commit comments

Comments
 (0)