Server/CLI: Optimize console output

Only log screenshot URLs for failed tests, still always create them,
can always be accessed on browserstack.com/automate.

Degrade the "Exiting" logs to debug, not needed in normal operations.

Update logs for finished workers to use less color, slightly more compact format.

Fix bug in formatTraceback, where a falsy actual or expected value would cause
nothing to be printed.

Updates tests/test.rby to match the new finished console output.

Author: jzaefferer

bin/cli.js

@@ -92,11 +92,11 @@ function cleanUpAndExit(signal, status) {
   }
 
   if (signal == 'SIGTERM') {
-    logger.info("Exiting");
+    logger.debug("Exiting");
     process.exit(status);
   } else {
     terminateAllWorkers(function() {
-      logger.info("Exiting");
+      logger.debug("Exiting");
       process.exit(1);
     });
   }

lib/server.js

@@ -144,7 +144,7 @@ exports.Server = function Server(bsClient, workers) {
       if (details.message) {
         output += ", " + details.message;
       }
-      if (details.actual && details.expected) {
+      if (details.actual != null && details.expected != null) {
         output += "\n" + chalk.blue("Expected: ") + details.expected +
           "\n" + chalk.blue("  Actual: ") + details.actual;
       }
@@ -187,7 +187,7 @@ exports.Server = function Server(bsClient, workers) {
     "_progress": function progressHandler(uri, body, request, response) {
       var uuid = request.headers['x-worker-uuid'];
       var worker = workers[uuid] || {};
-      query = "";
+      var query = null;
       try {
         query = parseBody(body);
       } catch(e) {
@@ -197,14 +197,14 @@ exports.Server = function Server(bsClient, workers) {
 
       if (query.tracebacks) {
         query.tracebacks.forEach(function(traceback) {
-          logger.info(chalk.red("[%s] Error:"), getTestBrowserInfo(worker), formatTraceback(traceback));
+          logger.info("[%s] " + chalk.red("Error:"), getTestBrowserInfo(worker), formatTraceback(traceback));
         });
       }
       response.end();
     },
 
     "_report": function reportHandler(uri, body, request, response) {
-      query = null;
+      var query = null;
       try {
         query = parseBody(body);
       } catch (e) {}
@@ -216,20 +216,21 @@ exports.Server = function Server(bsClient, workers) {
         logger.info("[%s] Null response from remote Browser", request.headers['x-browser-string']);
       } else {
         if (query.tracebacks && query.tracebacks.length > 0) {
-          logger.info(chalk["red"]("[%s] Tracebacks:"), getTestBrowserInfo(worker));
+          logger.info("[%s] " + chalk["red"]("Tracebacks:"), getTestBrowserInfo(worker));
           query.tracebacks.forEach(function(traceback) {
             logger.info(traceback);
           });
         }
         var color = query.failed ? "red" : "green";
-        logger.info(chalk[color]("[%s] Completed in %d milliseconds. %d of %d passed, %d failed."), getTestBrowserInfo(worker), query.runtime, query.passed, query.total, query.failed);
+        logger.info("[%s] " + chalk[color](query.failed ? "Failed:" : "Passed:") + " %d tests, %d passed, %d failed; ran for %dms", getTestBrowserInfo(worker), query.total, query.passed, query.failed, query.runtime);
         config.status += query.failed;
       }
 
+      // TODO remove this check, must always be true due to `worker` usage above
       if (worker) {
         bsClient.takeScreenshot(worker.id, function(error, screenshot) {
-          if (!error && screenshot.url) {
-            logger.info('[%s] ' + chalk['yellow']('Screenshot') + ': %s', getTestBrowserInfo(worker), screenshot.url);
+          if (!error && screenshot.url && query && query.failed) {
+            logger.info('[%s] ' + chalk.yellow('Screenshot:') + ' %s', getTestBrowserInfo(worker), screenshot.url);
           }
 
           checkAndTerminateWorker(worker, function(reusedWorker) {

tests/test.rb

@@ -12,7 +12,7 @@ def runBg(cmd, linestomatch, genre, test_strings)
     matched_counter = 0
     IO.popen(cmd) {|io|
       io.each {|line|
-        if line.match(/Completed in /)
+        if line.match(/ran for/)
           counter += 1
           puts "[#{genre.upcase}] : " + line
           test_strings.each do |test_string|
@@ -45,27 +45,27 @@ def run_project(reponame, test_framework, passed_array, browser_url)
     sleep(1)
     execute("cd #{repo_path}#{reponame} && git clean -f -d && git reset --hard")
   end
-  
+
   def qunit
-    run_project("underscorejs", "qunit", ["631 of 631 passed"], "test/index.html")
-    run_project("Modernizr", "qunit", ["20 of 41 passed"], "test/index.html")
+    run_project("underscorejs", "qunit", ["631 passed"], "test/index.html")
+    run_project("Modernizr", "qunit", ["20 passed"], "test/index.html")
     # https://github.com/bitovi/funcunit/
     # https://github.com/twbs/bootstrap
   end
 
   def mocha
-    run_project("url.js", "mocha", ["35 of 35 passed"], "test.html")    
+    run_project("url.js", "mocha", ["35 passed"], "test.html")
     # https://github.com/browserstack/microjungle
     # https://github.com/dhimil/mocha
     # https://github.com/auth0/auth0.js
   end
 
   def jasmine
-    run_project("mout", "jasmine", ["978 of 978 passed"], "tests/runner.html")
+    run_project("mout", "jasmine", ["978 passed"], "tests/runner.html")
   end
 
   def jasmine2
-    run_project("Comparatorsjs", "jasmine2", ["6 of 6 passed"], "comparators.spec-runner.html")
+    run_project("Comparatorsjs", "jasmine2", ["6 passed"], "comparators.spec-runner.html")
   end
 
   def run