From 8f357617e09e26fc77db4c4ab376e811f35ded94 Mon Sep 17 00:00:00 2001 From: Till Schneidereit Date: Fri, 21 Feb 2025 10:13:21 -0600 Subject: [PATCH] Remove warning about stubbed imports The warning added in #185 turns out to be too noisy: there are too many situations in which an import exists, but should be stubbed. In particular once StarlingMonkey is updated to include https://github.com/bytecodealliance/StarlingMonkey/pull/218, the warning would essentially be shown for every component, because in most cases, the target world won't contain the necessary interfaces, by design. --- crates/spidermonkey-embedding-splicer/src/stub_wasi.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/crates/spidermonkey-embedding-splicer/src/stub_wasi.rs b/crates/spidermonkey-embedding-splicer/src/stub_wasi.rs index 8379391c..640761c6 100644 --- a/crates/spidermonkey-embedding-splicer/src/stub_wasi.rs +++ b/crates/spidermonkey-embedding-splicer/src/stub_wasi.rs @@ -48,7 +48,6 @@ where let mut builder = FunctionBuilder::new(params.as_slice(), results.as_slice()); let _args = stub(&mut builder)?; - println!("Warning: the component import '{full_import}#{name}' isn't listed in the target WIT world, and will abort execution when called."); builder.replace_import_in_module(module, iid); return Ok(Some(fid));