From 3fcfd5f930a9f547e5b0e703329b5039a7b4e592 Mon Sep 17 00:00:00 2001 From: Pat Hickey Date: Tue, 22 Apr 2025 16:45:30 -0700 Subject: [PATCH 1/2] expose comoponentizejs's debugBuild option on command line using the same --use-debug-build flag that componentizejs's own cli uses. --- src/cmd/componentize.js | 1 + src/jco.js | 1 + 2 files changed, 2 insertions(+) diff --git a/src/cmd/componentize.js b/src/cmd/componentize.js index 38d453024..f4de1ee7a 100644 --- a/src/cmd/componentize.js +++ b/src/cmd/componentize.js @@ -27,6 +27,7 @@ export async function componentize(jsSource, opts) { disableFeatures: opts.disable, enableFeatures: opts.enable, preview2Adapter: opts.preview2Adapter, + debugBuild: opts.useDebugBuild, }); component = result.component; } catch (err) { diff --git a/src/jco.js b/src/jco.js index 3bf212a06..1e35dd4a5 100755 --- a/src/jco.js +++ b/src/jco.js @@ -41,6 +41,7 @@ program.command('componentize') .addOption(new Option('-d, --disable ', 'disable WASI features').choices(['clocks', 'http', 'random', 'stdio', 'all'])) // .addOption(new Option('-e, --enable ', 'enable WASI features').choices(['http'])) .option('--preview2-adapter ', 'provide a custom preview2 adapter path') + .option('--use-debug-build', 'use a debug build of StarlingMonkey') .requiredOption('-o, --out ', 'output component file') .action(asyncAction(componentize)); From ec059cdf8e6542182fe15c405c21ad40506c38a9 Mon Sep 17 00:00:00 2001 From: Pat Hickey Date: Wed, 23 Apr 2025 09:16:05 -0700 Subject: [PATCH 2/2] code review --- src/cmd/componentize.js | 2 +- src/jco.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/cmd/componentize.js b/src/cmd/componentize.js index f4de1ee7a..b17107379 100644 --- a/src/cmd/componentize.js +++ b/src/cmd/componentize.js @@ -27,7 +27,7 @@ export async function componentize(jsSource, opts) { disableFeatures: opts.disable, enableFeatures: opts.enable, preview2Adapter: opts.preview2Adapter, - debugBuild: opts.useDebugBuild, + debugBuild: opts.debugStarlingmonkeyBuild, }); component = result.component; } catch (err) { diff --git a/src/jco.js b/src/jco.js index 1e35dd4a5..846ce04c0 100755 --- a/src/jco.js +++ b/src/jco.js @@ -41,7 +41,7 @@ program.command('componentize') .addOption(new Option('-d, --disable ', 'disable WASI features').choices(['clocks', 'http', 'random', 'stdio', 'all'])) // .addOption(new Option('-e, --enable ', 'enable WASI features').choices(['http'])) .option('--preview2-adapter ', 'provide a custom preview2 adapter path') - .option('--use-debug-build', 'use a debug build of StarlingMonkey') + .option('--debug-starlingmonkey-build', 'use a debug build of StarlingMonkey') .requiredOption('-o, --out ', 'output component file') .action(asyncAction(componentize));