Commit de254c6
fix: typo in cmakeListsPath for turbo native modules (#629)
<!-- Please provide enough information so that others can review your
pull request. -->
<!-- Keep pull requests small and focused on a single change. -->
### Summary
<!-- What existing problem does the pull request solve? Can you solve
the issue with a different approach? -->
It fixes #627, as we were having the same issue in our react native
project.
When opting in Turbo Native Modules or Fabric Views, `cmakeListPath` in
generated `react-native.config.js` was not consistent with the hierarchy
generated by CodeGen.
This fix corrects the path as stated by document.
If my fix isn't correct, feel free to correct me.
Thank you.
### Test plan
<!-- List the steps with which we can test this change. Provide
screenshots if this changes anything visual. -->
- Select 'Turbo module - requires new arch (experimental)' to create
Turbo native module and include it into the project
- Build for android with `npx react-native run-android` to validate the
fix was correct.
---------
Co-authored-by: withSang <withsang@mpaghq.com>
Co-authored-by: Burak Güner <md.burak.guner@gmail.com>1 parent 639f545 commit de254c6
File tree
4 files changed
+16
-0
lines changed- packages/create-react-native-library/templates
- native-library-mixed
- native-library-new
- native-view-mixed
- native-view-new
4 files changed
+16
-0
lines changedLines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
9 | 13 | | |
10 | 14 | | |
11 | 15 | | |
| |||
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
9 | 13 | | |
10 | 14 | | |
11 | 15 | | |
| |||
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
9 | 13 | | |
10 | 14 | | |
11 | 15 | | |
| |||
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
9 | 13 | | |
10 | 14 | | |
11 | 15 | | |
| |||
0 commit comments