Skip to content

Commit ee36ff9

Browse files
committed
ci: pin pnpm/action-setup to v6.1.0
The floating v6 major tag hasn't been moved past v6.0.10, one release behind v6.1.0 (adds pnpm v12 support), so plain @v6 usage was not actually running the latest available version. Pin to the exact tag, matching how hendrikmuhs/ccache-action is already handled, and note why in the same comment block. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017iWrfmJFUyb3g3SyqgAGb8
1 parent ffb77e8 commit ee36ff9

2 files changed

Lines changed: 17 additions & 12 deletions

File tree

.github/workflows/check.yml

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,10 @@ concurrency:
3737
# hendrikmuhs/ccache-action is pinned to an exact patch, not a floating major:
3838
# its v1 / v1.2 tags still point at a Node.js 20 build, which the runners now
3939
# warn about. Float again once upstream moves them to >= v1.2.22.
40+
#
41+
# pnpm/action-setup is likewise pinned to an exact tag: upstream's floating v6
42+
# hasn't been moved past v6.0.10 yet, one release behind v6.1.0 (adds pnpm v12
43+
# support). Move back to floating v6 once it catches up.
4044

4145
jobs:
4246
lint:
@@ -47,7 +51,7 @@ jobs:
4751
- uses: actions/setup-node@v7
4852
with:
4953
node-version: lts/krypton
50-
- uses: pnpm/action-setup@v6
54+
- uses: pnpm/action-setup@v6.1.0
5155
with:
5256
cache: true
5357
- name: Setup cpp tools
@@ -97,7 +101,7 @@ jobs:
97101
- uses: actions/setup-node@v7
98102
with:
99103
node-version: lts/krypton
100-
- uses: pnpm/action-setup@v6
104+
- uses: pnpm/action-setup@v6.1.0
101105
with:
102106
cache: true
103107
- name: Setup cpp tools
@@ -137,7 +141,7 @@ jobs:
137141
- uses: actions/setup-node@v7
138142
with:
139143
node-version: lts/krypton
140-
- uses: pnpm/action-setup@v6
144+
- uses: pnpm/action-setup@v6.1.0
141145
with:
142146
cache: true
143147
- name: Setup cpp tools
@@ -167,7 +171,7 @@ jobs:
167171
- uses: actions/setup-node@v7
168172
with:
169173
node-version: lts/krypton
170-
- uses: pnpm/action-setup@v6
174+
- uses: pnpm/action-setup@v6.1.0
171175
with:
172176
cache: true
173177
# Device names change with every Xcode release, so pick one dynamically.
@@ -268,7 +272,7 @@ jobs:
268272
- uses: actions/setup-node@v7
269273
with:
270274
node-version: lts/krypton
271-
- uses: pnpm/action-setup@v6
275+
- uses: pnpm/action-setup@v6.1.0
272276
with:
273277
cache: true
274278
- name: Setup cpp tools
@@ -317,7 +321,7 @@ jobs:
317321
- uses: actions/setup-node@v7
318322
with:
319323
node-version: lts/krypton
320-
- uses: pnpm/action-setup@v6
324+
- uses: pnpm/action-setup@v6.1.0
321325
with:
322326
cache: true
323327
- name: Setup cpp tools
@@ -408,7 +412,7 @@ jobs:
408412
- uses: actions/setup-node@v7
409413
with:
410414
node-version: lts/krypton
411-
- uses: pnpm/action-setup@v6
415+
- uses: pnpm/action-setup@v6.1.0
412416
with:
413417
cache: true
414418
- name: Setup cpp tools

.github/workflows/release.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,9 @@ on:
2020
# refreshing the "Version Packages" pull request until someone approves. The
2121
# two jobs that must not overlap carry their own groups instead.
2222

23-
# Node.js is set up before pnpm, and hendrikmuhs/ccache-action is pinned to an
24-
# exact patch rather than a floating major. See the note in check.yml for why.
23+
# Node.js is set up before pnpm, and hendrikmuhs/ccache-action and
24+
# pnpm/action-setup are pinned to exact versions rather than floating majors.
25+
# See the note in check.yml for why.
2526

2627
jobs:
2728
# changesets/action's sub-actions split the "what should happen?" decision out
@@ -42,7 +43,7 @@ jobs:
4243
- uses: actions/setup-node@v7
4344
with:
4445
node-version: lts/krypton
45-
- uses: pnpm/action-setup@v6
46+
- uses: pnpm/action-setup@v6.1.0
4647
with:
4748
cache: true
4849
# select-mode runs the locally installed @changesets/cli, so the workspace
@@ -75,7 +76,7 @@ jobs:
7576
- uses: actions/setup-node@v7
7677
with:
7778
node-version: lts/krypton
78-
- uses: pnpm/action-setup@v6
79+
- uses: pnpm/action-setup@v6.1.0
7980
with:
8081
cache: true
8182
- run: pnpm install
@@ -103,7 +104,7 @@ jobs:
103104
- uses: actions/setup-node@v7
104105
with:
105106
node-version: lts/krypton
106-
- uses: pnpm/action-setup@v6
107+
- uses: pnpm/action-setup@v6.1.0
107108
with:
108109
cache: true
109110
- name: Setup cpp tools

0 commit comments

Comments
 (0)