Missing enable-cleanup-monitoring Annotation on CAPApplication

[xyunxylona]

Upstream code:
https://github.com/cap-js/cap-operator-plugin/blob/v0.14.0/lib/util.js#L252-L271 - writeCAPApplicationCRO() generates the CAPApplication metadata. No reference to sme.sap.com/enable-cleanup-monitoring exists anywhere in the repo.

Problem:
The plugin does not generate the sme.sap.com/enable-cleanup-monitoring: "true" annotation on the CAPApplication resource. Without it, old CAPApplicationVersion resources accumulate indefinitely after each Helm upgrade/ArgoCD sync. Each stale version spawns its own set of workloads, causing duplicate pods, resource waste, and potential routing conflicts.

The CAP Operator already supports this annotation and will automatically delete old CAPApplicationVersion resources no longer serving any tenants.

Expected behavior:
Add sme.sap.com/enable-cleanup-monitoring: "true" as a default annotation on the CAPApplication resource, or provide a configuration option. The annotation is inert until Prometheus is configured on the operator side, so enabling it by default is safe.

Severity:
Medium - stale CAPApplicationVersions accumulate over time.

[anirudhprasad-sap]

Hi @xyunxylona ,

Enabling sme.sap.com/enable-cleanup-monitoring: "true" by default is not straightforward. During an upgrade, some background jobs from the previous application version may still be running, and removing them immediately after the upgrade could introduce inconsistencies in the application. For this reason, we recommend that applications configure this setting manually, based on their specific use cases.

For applications with such complex scenarios, we recommend using a template-based chart with the CAP Operator during the initial setup, and then customizing it as needed to fit the application’s specific requirements. Maybe this is something that you could consider.

But we will also provide an option to configure this in the values.yaml.

[anirudhprasad-sap]

Annotation sme.sap.com/enable-cleanup-monitoring: "true" is now defaulted from version https://github.com/cap-js/cap-operator-plugin/releases/tag/v0.15.0 onwards.