diff --git a/README.md b/README.md index 745b538..c508d38 100644 --- a/README.md +++ b/README.md @@ -93,7 +93,7 @@ Receipts are a different artifact from certificates, with a different trust root (`/.well-known/certifieddata-public-key.pem` rather than the keys document). ```bash -npx @certifieddata/verify --type receipt +npx --package github:certifieddata/verify cd-verify --type receipt ``` The canonicalization, the exact bytes that are signed, and the test vectors are diff --git a/RECEIPT-VERIFICATION.md b/RECEIPT-VERIFICATION.md index d3dc1ea..c056da9 100644 --- a/RECEIPT-VERIFICATION.md +++ b/RECEIPT-VERIFICATION.md @@ -119,9 +119,17 @@ Note the key id: **`ed25519-prod-2025-02`**. Some older documentation shows ### Reproduce it ```bash -npx @certifieddata/verify 2492a060-8fbc-40ae-beab-7258aefb0608 --type receipt +npx --package github:certifieddata/verify cd-verify 2492a060-8fbc-40ae-beab-7258aefb0608 --type receipt ``` +> **Windows note:** invoke the `cd-verify` bin explicitly, as above. The short +> form `npx github:certifieddata/verify …` selects the bin named `verify`, and +> `verify` is a **cmd.exe built-in command** — cmd intercepts the bare name +> before PATH is consulted, so on Windows the built-in swallows the invocation +> (exit 1, no output). POSIX shells have no such built-in, so the short form +> works there. CI missed this because tests spawn the shim by *path*, and +> built-ins only shadow *bare names*. + Expected: ``` @@ -147,15 +155,15 @@ In `fixtures/`: With the repo checked out: ```bash -npx github:certifieddata/verify fixtures/valid-receipt.json --type receipt # VALID -npx github:certifieddata/verify fixtures/tampered-receipt.json --type receipt # INVALID +npx -p github:certifieddata/verify cd-verify fixtures/valid-receipt.json --type receipt # VALID +npx -p github:certifieddata/verify cd-verify fixtures/tampered-receipt.json --type receipt # INVALID ``` Without checking anything out — pipe the fixture in on stdin: ```bash curl -s https://raw.githubusercontent.com/certifieddata/verify/main/fixtures/tampered-receipt.json \ - | npx github:certifieddata/verify - --type receipt + | npx -p github:certifieddata/verify cd-verify - --type receipt # → ✗ INVALID ed25519 signature does not verify against the RFC 8785 canonical payload ``` diff --git a/dist/bin-invocation.test.js b/dist/bin-invocation.test.js index a231246..9e863c7 100644 --- a/dist/bin-invocation.test.js +++ b/dist/bin-invocation.test.js @@ -152,6 +152,41 @@ test("invoking through a symlinked path still runs — no silent no-op", () => { rmSync(dir, { recursive: true, force: true }); } }); +// ── Bare-name invocation through the shell ────────────────────────────────── +// +// npx invokes the selected bin as a BARE NAME through the platform shell. On +// Windows, cmd.exe built-ins shadow bare names before PATH is consulted — and +// `verify` IS a cmd.exe built-in (it toggles disk write verification). So +// `npx github:certifieddata/verify …` silently dies on Windows: cmd's built-in +// swallows the name, prints "An incorrect parameter was entered for the +// command." to a console nobody sees, and exits 1 with no output. +// +// Every other test here spawns the shim by PATH, which built-ins cannot +// shadow — which is exactly why six green CI legs, including two on Windows, +// shipped this. This test does what npx does: bare name, through the shell, +// with .bin on PATH. +// +// `verify` itself is unfixable on Windows (you cannot beat a cmd built-in), so +// the documented cross-platform command uses `cd-verify`, and THIS test pins +// that guarantee. The `verify` alias stays for POSIX convenience only. +test("documented bin `cd-verify` works as a bare name through the shell", () => { + assert.ok(binPath, "bin was not installed — setup failed"); + const binDir = dirname(binPath); + const r = spawnSync("cd-verify", ["--version"], { + encoding: "utf8", + shell: true, // bare name + shell = the npx invocation shape + env: { + ...process.env, + NO_COLOR: "1", + PATH: `${binDir}${isWindows ? ";" : ":"}${process.env.PATH ?? ""}`, + Path: `${binDir};${process.env.Path ?? process.env.PATH ?? ""}`, + }, + }); + const combined = (r.stdout ?? "") + (r.stderr ?? ""); + assert.notEqual(combined.trim(), "", "cd-verify produced no output as a bare shell name — the documented command is broken"); + assert.match(r.stdout ?? "", /@certifieddata\/verify/); + assert.equal(r.status, 0, `combined: ${combined}`); +}); // ── Network: the case the reviewer reproduced ─────────────────────────────── test("bin fails closed on a nonsense id — never exit 0", async () => { const r = runBin(["00000000-0000-0000-0000-000000000000"]); diff --git a/dist/bin-invocation.test.js.map b/dist/bin-invocation.test.js.map index 521c851..b06fcbd 100644 --- a/dist/bin-invocation.test.js.map +++ b/dist/bin-invocation.test.js.map @@ -1 +1 @@ -{"version":3,"file":"bin-invocation.test.js","sourceRoot":"","sources":["../src/bin-invocation.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GAkCG;AAEH,OAAO,EAAE,IAAI,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,WAAW,CAAC;AAChD,OAAO,MAAM,MAAM,oBAAoB,CAAC;AACxC,OAAO,EAAE,YAAY,EAAE,SAAS,EAAE,MAAM,oBAAoB,CAAC;AAC7D,OAAO,EAAE,WAAW,EAAE,MAAM,EAAE,UAAU,EAAE,WAAW,EAAE,WAAW,EAAE,MAAM,SAAS,CAAC;AACpF,OAAO,EAAE,MAAM,EAAE,MAAM,SAAS,CAAC;AACjC,OAAO,EAAE,aAAa,EAAE,MAAM,UAAU,CAAC;AACzC,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AAE1C,MAAM,IAAI,GAAG,OAAO,CAAC,aAAa,CAAC,MAAM,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC;AACrD,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC;AAClC,MAAM,SAAS,GAAG,OAAO,CAAC,QAAQ,KAAK,OAAO,CAAC;AAE/C,IAAI,OAAO,GAAkB,IAAI,CAAC;AAClC,IAAI,OAAO,GAAkB,IAAI,CAAC;AAElC,MAAM,CAAC,GAAG,EAAE;IACV,IAAI,CAAC;QACH,OAAO,GAAG,WAAW,CAAC,IAAI,CAAC,MAAM,EAAE,EAAE,eAAe,CAAC,CAAC,CAAC;QAEvD,6EAA6E;QAC7E,2DAA2D;QAC3D,MAAM,OAAO,GAAG,YAAY,CAAC,KAAK,EAAE,CAAC,MAAM,EAAE,UAAU,EAAE,oBAAoB,EAAE,OAAO,CAAC,EAAE;YACvF,GAAG,EAAE,QAAQ;YACb,QAAQ,EAAE,MAAM;YAChB,KAAK,EAAE,SAAS;SACjB,CAAC;aACC,IAAI,EAAE;aACN,KAAK,CAAC,IAAI,CAAC;aACX,GAAG,EAAG,CAAC;QAEV,YAAY,CAAC,KAAK,EAAE,CAAC,MAAM,EAAE,IAAI,CAAC,EAAE,EAAE,GAAG,EAAE,OAAO,EAAE,KAAK,EAAE,QAAQ,EAAE,KAAK,EAAE,SAAS,EAAE,CAAC,CAAC;QACzF,YAAY,CAAC,KAAK,EAAE,CAAC,SAAS,EAAE,IAAI,CAAC,OAAO,EAAE,OAAO,CAAC,CAAC,EAAE;YACvD,GAAG,EAAE,OAAO;YACZ,KAAK,EAAE,QAAQ;YACf,KAAK,EAAE,SAAS;SACjB,CAAC,CAAC;QAEH,MAAM,MAAM,GAAG,IAAI,CAAC,OAAO,EAAE,cAAc,EAAE,MAAM,CAAC,CAAC;QACrD,MAAM,SAAS,GAAG,IAAI,CAAC,MAAM,EAAE,SAAS,CAAC,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC;QACpE,OAAO,GAAG,UAAU,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,IAAI,CAAC;QAEnD,IAAI,CAAC,OAAO,EAAE,CAAC;YACb,MAAM,IAAI,KAAK,CACb,qDAAqD,WAAW,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CACtF,CAAC;QACJ,CAAC;IACH,CAAC;IAAC,OAAO,CAAC,EAAE,CAAC;QACX,yEAAyE;QACzE,2EAA2E;QAC3E,sCAAsC;QACtC,OAAO,CAAC,KAAK,CAAC,kCAAmC,CAAW,CAAC,OAAO,EAAE,CAAC,CAAC;IAC1E,CAAC;AACH,CAAC,CAAC,CAAC;AAEH,KAAK,CAAC,GAAG,EAAE;IACT,IAAI,OAAO;QAAE,MAAM,CAAC,OAAO,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC;AACjE,CAAC,CAAC,CAAC;AAEH,SAAS,MAAM,CAAC,IAAc;IAC5B,MAAM,CAAC,EAAE,CAAC,OAAO,EAAE,wDAAwD,CAAC,CAAC;IAC7E,MAAM,CAAC,GAAG,SAAS,CAAC,OAAQ,EAAE,IAAI,EAAE;QAClC,QAAQ,EAAE,MAAM;QAChB,GAAG,EAAE,EAAE,GAAG,OAAO,CAAC,GAAG,EAAE,QAAQ,EAAE,GAAG,EAAE;QACtC,KAAK,EAAE,SAAS;KACjB,CAAC,CAAC;IACH,OAAO;QACL,MAAM,EAAE,CAAC,CAAC,MAAM,IAAI,EAAE;QACtB,MAAM,EAAE,CAAC,CAAC,MAAM,IAAI,EAAE;QACtB,IAAI,EAAE,CAAC,CAAC,MAAM,IAAI,CAAC,CAAC;QACpB,QAAQ,EAAE,CAAC,CAAC,CAAC,MAAM,IAAI,EAAE,CAAC,GAAG,CAAC,CAAC,CAAC,MAAM,IAAI,EAAE,CAAC;KAC9C,CAAC;AACJ,CAAC;AAED,+EAA+E;AAE/E,IAAI,CAAC,2CAA2C,EAAE,GAAG,EAAE;IACrD,MAAM,CAAC,GAAG,MAAM,CAAC,CAAC,WAAW,CAAC,CAAC,CAAC;IAChC,6EAA6E;IAC7E,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,QAAQ,CAAC,IAAI,EAAE,EAAE,EAAE,EAAE,gDAAgD,CAAC,CAAC;IACzF,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,MAAM,EAAE,wBAAwB,CAAC,CAAC;IACjD,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC;AAC1B,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,6DAA6D,EAAE,GAAG,EAAE;IACvE,6EAA6E;IAC7E,wDAAwD;IACxD,MAAM,CAAC,GAAG,MAAM,CAAC,EAAE,CAAC,CAAC;IACrB,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,QAAQ,CAAC,IAAI,EAAE,EAAE,EAAE,EAAE,gDAAgD,CAAC,CAAC;IACzF,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,IAAI,EAAE,EAAE,EAAE,0BAA0B,CAAC,CAAC,IAAI,eAAe,CAAC,CAAC,QAAQ,EAAE,CAAC,CAAC;AACxF,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,+CAA+C,EAAE,GAAG,EAAE;IACzD,MAAM,CAAC,GAAG,MAAM,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC;IAC7B,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,MAAM,EAAE,aAAa,CAAC,CAAC;IACtC,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC;AAC1B,CAAC,CAAC,CAAC;AAEH,+EAA+E;AAC/E,EAAE;AACF,gFAAgF;AAChF,8EAA8E;AAC9E,gFAAgF;AAChF,wEAAwE;AACxE,EAAE;AACF,yEAAyE;AACzE,8EAA8E;AAC9E,wEAAwE;AACxE,6EAA6E;AAC7E,mDAAmD;AAEnD,IAAI,CAAC,gEAAgE,EAAE,GAAG,EAAE;IAC1E,MAAM,GAAG,GAAG,WAAW,CAAC,IAAI,CAAC,MAAM,EAAE,EAAE,gBAAgB,CAAC,CAAC,CAAC;IAC1D,IAAI,CAAC;QACH,MAAM,IAAI,GAAG,IAAI,CAAC,GAAG,EAAE,aAAa,CAAC,CAAC;QACtC,IAAI,CAAC;YACH,sEAAsE;YACtE,iEAAiE;YACjE,WAAW,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,IAAI,EAAE,UAAU,CAAC,CAAC;QAC5C,CAAC;QAAC,OAAO,CAAC,EAAE,CAAC;YACX,MAAM,CAAC,IAAI,CACT,wDAAyD,CAAW,CAAC,OAAO,IAAI;gBAC9E,8EAA8E;gBAC9E,uDAAuD,CAC1D,CAAC;QACJ,CAAC;QAED,MAAM,CAAC,GAAG,SAAS,CACjB,OAAO,CAAC,QAAQ,EAChB,CAAC,IAAI,CAAC,IAAI,EAAE,QAAQ,CAAC,EAAE,sCAAsC,CAAC,EAC9D,EAAE,QAAQ,EAAE,MAAM,EAAE,GAAG,EAAE,EAAE,GAAG,OAAO,CAAC,GAAG,EAAE,QAAQ,EAAE,GAAG,EAAE,EAAE,CAC7D,CAAC;QACF,MAAM,QAAQ,GAAG,CAAC,CAAC,CAAC,MAAM,IAAI,EAAE,CAAC,GAAG,CAAC,CAAC,CAAC,MAAM,IAAI,EAAE,CAAC,CAAC;QAErD,MAAM,CAAC,QAAQ,CACb,QAAQ,CAAC,IAAI,EAAE,EACf,EAAE,EACF,2EAA2E;YACzE,sDAAsD,CACzD,CAAC;QACF,MAAM,CAAC,QAAQ,CACb,CAAC,CAAC,MAAM,EACR,CAAC,EACD,wEAAwE,CACzE,CAAC;IACJ,CAAC;YAAS,CAAC;QACT,MAAM,CAAC,GAAG,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC;IAChD,CAAC;AACH,CAAC,CAAC,CAAC;AAEH,+EAA+E;AAE/E,IAAI,CAAC,kDAAkD,EAAE,KAAK,IAAI,EAAE;IAClE,MAAM,CAAC,GAAG,MAAM,CAAC,CAAC,sCAAsC,CAAC,CAAC,CAAC;IAE3D,IAAI,uCAAuC,CAAC,IAAI,CAAC,CAAC,CAAC,QAAQ,CAAC,EAAE,CAAC;QAC7D,0EAA0E;QAC1E,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,EAAE,yCAAyC,CAAC,CAAC;QACtE,OAAO;IACT,CAAC;IAED,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,QAAQ,CAAC,IAAI,EAAE,EAAE,EAAE,EAAE,gDAAgD,CAAC,CAAC;IACzF,MAAM,CAAC,QAAQ,CACb,CAAC,CAAC,IAAI,EACN,CAAC,EACD,uFAAuF,CACxF,CAAC;IACF,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,EAAE,6BAA6B,CAAC,CAAC,IAAI,eAAe,CAAC,CAAC,QAAQ,EAAE,CAAC,CAAC;AAC1F,CAAC,CAAC,CAAC"} \ No newline at end of file +{"version":3,"file":"bin-invocation.test.js","sourceRoot":"","sources":["../src/bin-invocation.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GAkCG;AAEH,OAAO,EAAE,IAAI,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,WAAW,CAAC;AAChD,OAAO,MAAM,MAAM,oBAAoB,CAAC;AACxC,OAAO,EAAE,YAAY,EAAE,SAAS,EAAE,MAAM,oBAAoB,CAAC;AAC7D,OAAO,EAAE,WAAW,EAAE,MAAM,EAAE,UAAU,EAAE,WAAW,EAAE,WAAW,EAAE,MAAM,SAAS,CAAC;AACpF,OAAO,EAAE,MAAM,EAAE,MAAM,SAAS,CAAC;AACjC,OAAO,EAAE,aAAa,EAAE,MAAM,UAAU,CAAC;AACzC,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAC;AAE1C,MAAM,IAAI,GAAG,OAAO,CAAC,aAAa,CAAC,MAAM,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC;AACrD,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC;AAClC,MAAM,SAAS,GAAG,OAAO,CAAC,QAAQ,KAAK,OAAO,CAAC;AAE/C,IAAI,OAAO,GAAkB,IAAI,CAAC;AAClC,IAAI,OAAO,GAAkB,IAAI,CAAC;AAElC,MAAM,CAAC,GAAG,EAAE;IACV,IAAI,CAAC;QACH,OAAO,GAAG,WAAW,CAAC,IAAI,CAAC,MAAM,EAAE,EAAE,eAAe,CAAC,CAAC,CAAC;QAEvD,6EAA6E;QAC7E,2DAA2D;QAC3D,MAAM,OAAO,GAAG,YAAY,CAAC,KAAK,EAAE,CAAC,MAAM,EAAE,UAAU,EAAE,oBAAoB,EAAE,OAAO,CAAC,EAAE;YACvF,GAAG,EAAE,QAAQ;YACb,QAAQ,EAAE,MAAM;YAChB,KAAK,EAAE,SAAS;SACjB,CAAC;aACC,IAAI,EAAE;aACN,KAAK,CAAC,IAAI,CAAC;aACX,GAAG,EAAG,CAAC;QAEV,YAAY,CAAC,KAAK,EAAE,CAAC,MAAM,EAAE,IAAI,CAAC,EAAE,EAAE,GAAG,EAAE,OAAO,EAAE,KAAK,EAAE,QAAQ,EAAE,KAAK,EAAE,SAAS,EAAE,CAAC,CAAC;QACzF,YAAY,CAAC,KAAK,EAAE,CAAC,SAAS,EAAE,IAAI,CAAC,OAAO,EAAE,OAAO,CAAC,CAAC,EAAE;YACvD,GAAG,EAAE,OAAO;YACZ,KAAK,EAAE,QAAQ;YACf,KAAK,EAAE,SAAS;SACjB,CAAC,CAAC;QAEH,MAAM,MAAM,GAAG,IAAI,CAAC,OAAO,EAAE,cAAc,EAAE,MAAM,CAAC,CAAC;QACrD,MAAM,SAAS,GAAG,IAAI,CAAC,MAAM,EAAE,SAAS,CAAC,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC;QACpE,OAAO,GAAG,UAAU,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,IAAI,CAAC;QAEnD,IAAI,CAAC,OAAO,EAAE,CAAC;YACb,MAAM,IAAI,KAAK,CACb,qDAAqD,WAAW,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CACtF,CAAC;QACJ,CAAC;IACH,CAAC;IAAC,OAAO,CAAC,EAAE,CAAC;QACX,yEAAyE;QACzE,2EAA2E;QAC3E,sCAAsC;QACtC,OAAO,CAAC,KAAK,CAAC,kCAAmC,CAAW,CAAC,OAAO,EAAE,CAAC,CAAC;IAC1E,CAAC;AACH,CAAC,CAAC,CAAC;AAEH,KAAK,CAAC,GAAG,EAAE;IACT,IAAI,OAAO;QAAE,MAAM,CAAC,OAAO,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC;AACjE,CAAC,CAAC,CAAC;AAEH,SAAS,MAAM,CAAC,IAAc;IAC5B,MAAM,CAAC,EAAE,CAAC,OAAO,EAAE,wDAAwD,CAAC,CAAC;IAC7E,MAAM,CAAC,GAAG,SAAS,CAAC,OAAQ,EAAE,IAAI,EAAE;QAClC,QAAQ,EAAE,MAAM;QAChB,GAAG,EAAE,EAAE,GAAG,OAAO,CAAC,GAAG,EAAE,QAAQ,EAAE,GAAG,EAAE;QACtC,KAAK,EAAE,SAAS;KACjB,CAAC,CAAC;IACH,OAAO;QACL,MAAM,EAAE,CAAC,CAAC,MAAM,IAAI,EAAE;QACtB,MAAM,EAAE,CAAC,CAAC,MAAM,IAAI,EAAE;QACtB,IAAI,EAAE,CAAC,CAAC,MAAM,IAAI,CAAC,CAAC;QACpB,QAAQ,EAAE,CAAC,CAAC,CAAC,MAAM,IAAI,EAAE,CAAC,GAAG,CAAC,CAAC,CAAC,MAAM,IAAI,EAAE,CAAC;KAC9C,CAAC;AACJ,CAAC;AAED,+EAA+E;AAE/E,IAAI,CAAC,2CAA2C,EAAE,GAAG,EAAE;IACrD,MAAM,CAAC,GAAG,MAAM,CAAC,CAAC,WAAW,CAAC,CAAC,CAAC;IAChC,6EAA6E;IAC7E,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,QAAQ,CAAC,IAAI,EAAE,EAAE,EAAE,EAAE,gDAAgD,CAAC,CAAC;IACzF,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,MAAM,EAAE,wBAAwB,CAAC,CAAC;IACjD,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC;AAC1B,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,6DAA6D,EAAE,GAAG,EAAE;IACvE,6EAA6E;IAC7E,wDAAwD;IACxD,MAAM,CAAC,GAAG,MAAM,CAAC,EAAE,CAAC,CAAC;IACrB,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,QAAQ,CAAC,IAAI,EAAE,EAAE,EAAE,EAAE,gDAAgD,CAAC,CAAC;IACzF,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,IAAI,EAAE,EAAE,EAAE,0BAA0B,CAAC,CAAC,IAAI,eAAe,CAAC,CAAC,QAAQ,EAAE,CAAC,CAAC;AACxF,CAAC,CAAC,CAAC;AAEH,IAAI,CAAC,+CAA+C,EAAE,GAAG,EAAE;IACzD,MAAM,CAAC,GAAG,MAAM,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC;IAC7B,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,MAAM,EAAE,aAAa,CAAC,CAAC;IACtC,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC;AAC1B,CAAC,CAAC,CAAC;AAEH,+EAA+E;AAC/E,EAAE;AACF,gFAAgF;AAChF,8EAA8E;AAC9E,gFAAgF;AAChF,wEAAwE;AACxE,EAAE;AACF,yEAAyE;AACzE,8EAA8E;AAC9E,wEAAwE;AACxE,6EAA6E;AAC7E,mDAAmD;AAEnD,IAAI,CAAC,gEAAgE,EAAE,GAAG,EAAE;IAC1E,MAAM,GAAG,GAAG,WAAW,CAAC,IAAI,CAAC,MAAM,EAAE,EAAE,gBAAgB,CAAC,CAAC,CAAC;IAC1D,IAAI,CAAC;QACH,MAAM,IAAI,GAAG,IAAI,CAAC,GAAG,EAAE,aAAa,CAAC,CAAC;QACtC,IAAI,CAAC;YACH,sEAAsE;YACtE,iEAAiE;YACjE,WAAW,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,IAAI,EAAE,UAAU,CAAC,CAAC;QAC5C,CAAC;QAAC,OAAO,CAAC,EAAE,CAAC;YACX,MAAM,CAAC,IAAI,CACT,wDAAyD,CAAW,CAAC,OAAO,IAAI;gBAC9E,8EAA8E;gBAC9E,uDAAuD,CAC1D,CAAC;QACJ,CAAC;QAED,MAAM,CAAC,GAAG,SAAS,CACjB,OAAO,CAAC,QAAQ,EAChB,CAAC,IAAI,CAAC,IAAI,EAAE,QAAQ,CAAC,EAAE,sCAAsC,CAAC,EAC9D,EAAE,QAAQ,EAAE,MAAM,EAAE,GAAG,EAAE,EAAE,GAAG,OAAO,CAAC,GAAG,EAAE,QAAQ,EAAE,GAAG,EAAE,EAAE,CAC7D,CAAC;QACF,MAAM,QAAQ,GAAG,CAAC,CAAC,CAAC,MAAM,IAAI,EAAE,CAAC,GAAG,CAAC,CAAC,CAAC,MAAM,IAAI,EAAE,CAAC,CAAC;QAErD,MAAM,CAAC,QAAQ,CACb,QAAQ,CAAC,IAAI,EAAE,EACf,EAAE,EACF,2EAA2E;YACzE,sDAAsD,CACzD,CAAC;QACF,MAAM,CAAC,QAAQ,CACb,CAAC,CAAC,MAAM,EACR,CAAC,EACD,wEAAwE,CACzE,CAAC;IACJ,CAAC;YAAS,CAAC;QACT,MAAM,CAAC,GAAG,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC;IAChD,CAAC;AACH,CAAC,CAAC,CAAC;AAEH,+EAA+E;AAC/E,EAAE;AACF,6EAA6E;AAC7E,8EAA8E;AAC9E,0EAA0E;AAC1E,+EAA+E;AAC/E,wEAAwE;AACxE,kEAAkE;AAClE,EAAE;AACF,wEAAwE;AACxE,6EAA6E;AAC7E,4EAA4E;AAC5E,qBAAqB;AACrB,EAAE;AACF,+EAA+E;AAC/E,6EAA6E;AAC7E,uEAAuE;AAEvE,IAAI,CAAC,mEAAmE,EAAE,GAAG,EAAE;IAC7E,MAAM,CAAC,EAAE,CAAC,OAAO,EAAE,sCAAsC,CAAC,CAAC;IAC3D,MAAM,MAAM,GAAG,OAAO,CAAC,OAAQ,CAAC,CAAC;IACjC,MAAM,CAAC,GAAG,SAAS,CAAC,WAAW,EAAE,CAAC,WAAW,CAAC,EAAE;QAC9C,QAAQ,EAAE,MAAM;QAChB,KAAK,EAAE,IAAI,EAAE,+CAA+C;QAC5D,GAAG,EAAE;YACH,GAAG,OAAO,CAAC,GAAG;YACd,QAAQ,EAAE,GAAG;YACb,IAAI,EAAE,GAAG,MAAM,GAAG,SAAS,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,GAAG,GAAG,OAAO,CAAC,GAAG,CAAC,IAAI,IAAI,EAAE,EAAE;YAClE,IAAI,EAAE,GAAG,MAAM,IAAI,OAAO,CAAC,GAAG,CAAC,IAAI,IAAI,OAAO,CAAC,GAAG,CAAC,IAAI,IAAI,EAAE,EAAE;SAChE;KACF,CAAC,CAAC;IACH,MAAM,QAAQ,GAAG,CAAC,CAAC,CAAC,MAAM,IAAI,EAAE,CAAC,GAAG,CAAC,CAAC,CAAC,MAAM,IAAI,EAAE,CAAC,CAAC;IACrD,MAAM,CAAC,QAAQ,CACb,QAAQ,CAAC,IAAI,EAAE,EACf,EAAE,EACF,sFAAsF,CACvF,CAAC;IACF,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,MAAM,IAAI,EAAE,EAAE,wBAAwB,CAAC,CAAC;IACvD,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,MAAM,EAAE,CAAC,EAAE,aAAa,QAAQ,EAAE,CAAC,CAAC;AACrD,CAAC,CAAC,CAAC;AAEH,+EAA+E;AAE/E,IAAI,CAAC,kDAAkD,EAAE,KAAK,IAAI,EAAE;IAClE,MAAM,CAAC,GAAG,MAAM,CAAC,CAAC,sCAAsC,CAAC,CAAC,CAAC;IAE3D,IAAI,uCAAuC,CAAC,IAAI,CAAC,CAAC,CAAC,QAAQ,CAAC,EAAE,CAAC;QAC7D,0EAA0E;QAC1E,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,EAAE,yCAAyC,CAAC,CAAC;QACtE,OAAO;IACT,CAAC;IAED,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,QAAQ,CAAC,IAAI,EAAE,EAAE,EAAE,EAAE,gDAAgD,CAAC,CAAC;IACzF,MAAM,CAAC,QAAQ,CACb,CAAC,CAAC,IAAI,EACN,CAAC,EACD,uFAAuF,CACxF,CAAC;IACF,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,EAAE,6BAA6B,CAAC,CAAC,IAAI,eAAe,CAAC,CAAC,QAAQ,EAAE,CAAC,CAAC;AAC1F,CAAC,CAAC,CAAC"} \ No newline at end of file diff --git a/src/bin-invocation.test.ts b/src/bin-invocation.test.ts index 77e9996..7b71c95 100644 --- a/src/bin-invocation.test.ts +++ b/src/bin-invocation.test.ts @@ -183,6 +183,47 @@ test("invoking through a symlinked path still runs — no silent no-op", () => { } }); +// ── Bare-name invocation through the shell ────────────────────────────────── +// +// npx invokes the selected bin as a BARE NAME through the platform shell. On +// Windows, cmd.exe built-ins shadow bare names before PATH is consulted — and +// `verify` IS a cmd.exe built-in (it toggles disk write verification). So +// `npx github:certifieddata/verify …` silently dies on Windows: cmd's built-in +// swallows the name, prints "An incorrect parameter was entered for the +// command." to a console nobody sees, and exits 1 with no output. +// +// Every other test here spawns the shim by PATH, which built-ins cannot +// shadow — which is exactly why six green CI legs, including two on Windows, +// shipped this. This test does what npx does: bare name, through the shell, +// with .bin on PATH. +// +// `verify` itself is unfixable on Windows (you cannot beat a cmd built-in), so +// the documented cross-platform command uses `cd-verify`, and THIS test pins +// that guarantee. The `verify` alias stays for POSIX convenience only. + +test("documented bin `cd-verify` works as a bare name through the shell", () => { + assert.ok(binPath, "bin was not installed — setup failed"); + const binDir = dirname(binPath!); + const r = spawnSync("cd-verify", ["--version"], { + encoding: "utf8", + shell: true, // bare name + shell = the npx invocation shape + env: { + ...process.env, + NO_COLOR: "1", + PATH: `${binDir}${isWindows ? ";" : ":"}${process.env.PATH ?? ""}`, + Path: `${binDir};${process.env.Path ?? process.env.PATH ?? ""}`, + }, + }); + const combined = (r.stdout ?? "") + (r.stderr ?? ""); + assert.notEqual( + combined.trim(), + "", + "cd-verify produced no output as a bare shell name — the documented command is broken", + ); + assert.match(r.stdout ?? "", /@certifieddata\/verify/); + assert.equal(r.status, 0, `combined: ${combined}`); +}); + // ── Network: the case the reviewer reproduced ─────────────────────────────── test("bin fails closed on a nonsense id — never exit 0", async () => {