ci(repo): enforce bundlewatch bundle-size budgets (#8752)

Author: jacekradko

.changeset/bundlewatch-ui-shared-browser-budget.md

@@ -0,0 +1,2 @@
+---
+---

.github/workflows/ci.yml

@@ -138,21 +138,17 @@ jobs:
           path: .turbo/runs
           retention-days: 5
 
-  static-analysis:
+  bundle-size:
     needs: [check-permissions, build-packages]
-    name: Static analysis
+    name: Bundle size
     permissions:
       contents: read
-      actions: write # needed for actions/upload-artifact
     runs-on: "blacksmith-8vcpu-ubuntu-2204"
     defaults:
       run:
         shell: bash
     timeout-minutes: ${{ vars.TIMEOUT_MINUTES_NORMAL && fromJSON(vars.TIMEOUT_MINUTES_NORMAL) || 10 }}
 
-    env:
-      TURBO_SUMMARIZE: false
-
     steps:
       - name: Checkout Repo
         uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
@@ -169,21 +165,57 @@ jobs:
         with:
           cache-enabled: true
           turbo-signature: ${{ secrets.TURBO_REMOTE_CACHE_SIGNATURE_KEY }}
-          turbo-summarize: ${{ env.TURBO_SUMMARIZE }}
           turbo-team: ${{ vars.TURBO_TEAM }}
           turbo-token: ${{ secrets.TURBO_TOKEN }}
 
+      # No continue-on-error: an over-budget chunk fails this job, which is the gate.
+      # Enforcement rides on this job's exit code, not the `bundlewatch` commit status
+      # (which collides across packages and can be masked by a sibling's pass).
       - name: Check size using bundlewatch
-        continue-on-error: true
         env:
           BUNDLEWATCH_GITHUB_TOKEN: ${{ secrets.BUNDLEWATCH_GITHUB_TOKEN }}
-          CI_BRANCH: ${{ github.ref	}}
+          CI_BRANCH: ${{ github.ref }}
           CI_BRANCH_BASE: refs/heads/main
-          CI_COMMIT_SHA: ${{ github.event.pull_request.head.sha }}
+          CI_COMMIT_SHA: ${{ github.event_name == 'merge_group' && github.event.merge_group.head_sha || github.event.pull_request.head.sha }}
           CI_REPO_NAME: ${{ vars.REPO_NAME }}
           CI_REPO_OWNER: ${{ vars.REPO_OWNER }}
         run: pnpm turbo bundlewatch $TURBO_ARGS
 
+  static-analysis:
+    needs: [check-permissions, build-packages]
+    name: Static analysis
+    permissions:
+      contents: read
+      actions: write # needed for actions/upload-artifact
+    runs-on: "blacksmith-8vcpu-ubuntu-2204"
+    defaults:
+      run:
+        shell: bash
+    timeout-minutes: ${{ vars.TIMEOUT_MINUTES_NORMAL && fromJSON(vars.TIMEOUT_MINUTES_NORMAL) || 10 }}
+
+    env:
+      TURBO_SUMMARIZE: false
+
+    steps:
+      - name: Checkout Repo
+        uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
+        with:
+          persist-credentials: false
+          fetch-depth: 1
+          fetch-tags: false
+          filter: "blob:none"
+          show-progress: false
+
+      - name: Setup
+        id: config
+        uses: ./.github/actions/init-blacksmith
+        with:
+          cache-enabled: true
+          turbo-signature: ${{ secrets.TURBO_REMOTE_CACHE_SIGNATURE_KEY }}
+          turbo-summarize: ${{ env.TURBO_SUMMARIZE }}
+          turbo-team: ${{ vars.TURBO_TEAM }}
+          turbo-token: ${{ secrets.TURBO_TOKEN }}
+
       - name: Lint packages using publint
         run: pnpm turbo lint:publint $TURBO_ARGS
 

packages/ui/bundlewatch.config.json

@@ -2,6 +2,7 @@
   "files": [
     { "path": "./dist/ui.browser.js", "maxSize": "42KB" },
     { "path": "./dist/ui.legacy.browser.js", "maxSize": "84KB" },
+    { "path": "./dist/ui.shared.browser.js", "maxSize": "40KB" },
     { "path": "./dist/framework*.js", "maxSize": "44KB" },
     { "path": "./dist/vendors*.js", "maxSize": "73KB" },
     { "path": "./dist/ui-common*.js", "maxSize": "130KB" },
@@ -32,6 +33,6 @@
     { "path": "./dist/op-plans-page*.js", "maxSize": "3KB" },
     { "path": "./dist/statement-page*.js", "maxSize": "5KB" },
     { "path": "./dist/payment-attempt-page*.js", "maxSize": "4KB" },
-    { "path": "./dist/web3-solana-wallet-buttons*.js", "maxSize": "79KB" }
+    { "path": "./dist/web3-solana-wallet-buttons*.js", "maxSize": "85KB" }
   ]
 }