Skip to content

Commit fd6ce60

Browse files
committed
[Tests] Remove Laravel 5.x semver check from tests
1 parent 6378576 commit fd6ce60

File tree

2 files changed

+5
-12
lines changed

2 files changed

+5
-12
lines changed

composer.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,7 @@
3838
},
3939
"require-dev": {
4040
"ext-sqlite3": "*",
41-
"cloudcreativity/json-api-testing": "^2.0",
42-
"composer/semver": "^1.5",
41+
"cloudcreativity/json-api-testing": "^2.1",
4342
"guzzlehttp/guzzle": "^6.3",
4443
"mockery/mockery": "^1.1",
4544
"orchestra/testbench": "^4.0",
@@ -78,7 +77,7 @@
7877
}
7978
}
8079
},
81-
"minimum-stability": "stable",
80+
"minimum-stability": "dev",
8281
"prefer-stable": true,
8382
"config": {
8483
"sort-packages": true

tests/lib/Integration/Eloquent/ResourceTest.php

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919

2020
use Carbon\Carbon;
2121
use CloudCreativity\LaravelJsonApi\Tests\Integration\TestCase;
22-
use Composer\Semver\Semver;
2322
use DummyApp\Comment;
2423
use DummyApp\Post;
2524
use DummyApp\Tag;
@@ -712,14 +711,9 @@ public function testDelete()
712711
return $post->is($actual);
713712
});
714713

715-
/**
716-
* Force deleted event was added in Laravel 5.6.
717-
*/
718-
if (Semver::satisfies($this->app->version(), '>=5.6')) {
719-
Event::assertDispatched("eloquent.forceDeleted: " . Post::class, function ($name, $actual) use ($post) {
720-
return $post->is($actual);
721-
});
722-
}
714+
Event::assertDispatched("eloquent.forceDeleted: " . Post::class, function ($name, $actual) use ($post) {
715+
return $post->is($actual);
716+
});
723717
}
724718

725719
/**

0 commit comments

Comments
 (0)