From 091f2d0613d244e3e8549128010203e56b442c67 Mon Sep 17 00:00:00 2001 From: Hood Chatham Date: Mon, 14 Sep 2026 12:12:49 -0700 Subject: [PATCH] chore: Clean up ruff rules Remove some unused ignores, for remainder add description --- packages/django-cf/django_cf/db/base_engine.py | 2 +- .../asgi-ws-disconnect/tests/test_ws_disconnect.py | 4 +--- ruff.toml | 8 ++------ 3 files changed, 4 insertions(+), 10 deletions(-) diff --git a/packages/django-cf/django_cf/db/base_engine.py b/packages/django-cf/django_cf/db/base_engine.py index 6af0f608..7ff587c5 100644 --- a/packages/django-cf/django_cf/db/base_engine.py +++ b/packages/django-cf/django_cf/db/base_engine.py @@ -161,7 +161,7 @@ def last_executed_query(self, cursor, sql, params): def bulk_insert_sql(self, fields, placeholder_rows): placeholder_rows_sql = (", ".join(row) for row in placeholder_rows) - values_sql = ", ".join("(%s)" % sql for sql in placeholder_rows_sql) + values_sql = ", ".join(f"({sql})" for sql in placeholder_rows_sql) return "VALUES " + values_sql diff --git a/packages/runtime-sdk/tests/workerd-test/asgi-ws-disconnect/tests/test_ws_disconnect.py b/packages/runtime-sdk/tests/workerd-test/asgi-ws-disconnect/tests/test_ws_disconnect.py index 7b478538..d3afd2e1 100644 --- a/packages/runtime-sdk/tests/workerd-test/asgi-ws-disconnect/tests/test_ws_disconnect.py +++ b/packages/runtime-sdk/tests/workerd-test/asgi-ws-disconnect/tests/test_ws_disconnect.py @@ -1,5 +1,6 @@ import asyncio import contextlib +import json import pytest from pyodide.ffi import create_proxy, to_js @@ -61,9 +62,6 @@ async def _ws_connect(path): ) -import json - - async def _events(): response = await asyncio.wait_for( env.SELF.fetch("http://example.com/ws-events"), TIMEOUT_S diff --git a/ruff.toml b/ruff.toml index ac0ef09f..98718701 100644 --- a/ruff.toml +++ b/ruff.toml @@ -18,15 +18,11 @@ select = [ ] ignore = [ "C901", # Too complex - "E402", - "E501", - "E731", - "E741", + "E501", # Line too long "PLR0911", # Too many return statements "PLR0915", # Too many statements "PLR2004", # Magic value - "PLW2901", - "UP031", + "PLW2901", # loop variable overwritten by assignment "UP038", # Use X | Y instead of (X, Y) ] flake8-comprehensions.allow-dict-calls-with-keyword-arguments = true