From 8f23dad9e2fda671a8ed2c73584b245f3e3226db Mon Sep 17 00:00:00 2001 From: Jochen Ehret Date: Tue, 11 Aug 2026 17:12:52 +0200 Subject: [PATCH 1/3] Add "http_request_timeout" option to storage-cli "connection_config" parameter * this is for gcs, s3 and alioss --- .../storage_cli_config_buildpacks.json.erb | 3 +++ .../storage_cli_config_droplets.json.erb | 3 +++ .../storage_cli_config_packages.json.erb | 3 +++ .../storage_cli_config_resource_pool.json.erb | 3 +++ .../storage_cli_config_buildpacks.json.erb | 5 +++- .../storage_cli_config_droplets.json.erb | 5 +++- .../storage_cli_config_packages.json.erb | 3 +++ .../storage_cli_config_resource_pool.json.erb | 5 +++- .../storage_cli_config_buildpacks.json.erb | 3 +++ .../storage_cli_config_droplets.json.erb | 3 +++ .../storage_cli_config_packages.json.erb | 3 +++ .../storage_cli_config_resource_pool.json.erb | 3 +++ .../storage_cli_config_buildpacks.json.erb | 3 +++ .../storage_cli_config_droplets.json.erb | 3 +++ .../storage_cli_config_packages.json.erb | 3 +++ .../storage_cli_config_resource_pool.json.erb | 3 +++ .../storage_cli_config_buildpacks.json.erb | 3 +++ .../storage_cli_config_droplets.json.erb | 3 +++ .../storage_cli_config_packages.json.erb | 5 +++- .../storage_cli_config_resource_pool.json.erb | 5 +++- .../storage_cli_config_jsons_spec.rb | 26 +++++++++++++++---- .../storage_cli_config_jsons_spec.rb | 26 +++++++++++++++---- .../storage_cli_config_jsons_spec.rb | 26 +++++++++++++++---- .../storage_cli_config_jsons_spec.rb | 26 +++++++++++++++---- 24 files changed, 149 insertions(+), 25 deletions(-) diff --git a/jobs/blobstore_benchmark/templates/storage_cli_config_buildpacks.json.erb b/jobs/blobstore_benchmark/templates/storage_cli_config_buildpacks.json.erb index 5478b5a47a..8b6e775cda 100644 --- a/jobs/blobstore_benchmark/templates/storage_cli_config_buildpacks.json.erb +++ b/jobs/blobstore_benchmark/templates/storage_cli_config_buildpacks.json.erb @@ -42,6 +42,7 @@ if provider == "gcs" options["bucket_name"] = l.p("#{scope}.bucket_name") add_optional(options, "storage_class", l.p("#{scope}.storage_class", nil)) add_optional(options, "encryption_key", l.p("#{scope}.encryption_key", nil)) + add_optional(options, "http_request_timeout", l.p("#{scope}.http_request_timeout", nil)) end if provider == "s3" @@ -77,6 +78,7 @@ if provider == "s3" add_optional(options, "request_checksum_calculation_enabled", l.p("#{scope}.request_checksum_calculation_enabled", nil)) add_optional(options, "response_checksum_calculation_enabled", l.p("#{scope}.response_checksum_calculation_enabled", nil)) add_optional(options, "uploader_request_checksum_calculation_enabled", l.p("#{scope}.uploader_request_checksum_calculation_enabled", nil)) + add_optional(options, "http_request_timeout", l.p("#{scope}.http_request_timeout", nil)) end if provider == "alioss" @@ -85,6 +87,7 @@ if provider == "alioss" options["access_key_secret"] = l.p("#{scope}.aliyun_accesskey_secret") options["endpoint"] = l.p("#{scope}.aliyun_oss_endpoint") options["bucket_name"] = l.p("#{scope}.aliyun_oss_bucket") + add_optional(options, "http_request_timeout", l.p("#{scope}.http_request_timeout", nil)) end diff --git a/jobs/blobstore_benchmark/templates/storage_cli_config_droplets.json.erb b/jobs/blobstore_benchmark/templates/storage_cli_config_droplets.json.erb index 69d70c40f8..1d9c822064 100644 --- a/jobs/blobstore_benchmark/templates/storage_cli_config_droplets.json.erb +++ b/jobs/blobstore_benchmark/templates/storage_cli_config_droplets.json.erb @@ -42,6 +42,7 @@ if provider == "gcs" options["bucket_name"] = l.p("#{scope}.bucket_name") add_optional(options, "storage_class", l.p("#{scope}.storage_class", nil)) add_optional(options, "encryption_key", l.p("#{scope}.encryption_key", nil)) + add_optional(options, "http_request_timeout", l.p("#{scope}.http_request_timeout", nil)) end if provider == "s3" @@ -77,6 +78,7 @@ if provider == "s3" add_optional(options, "request_checksum_calculation_enabled", l.p("#{scope}.request_checksum_calculation_enabled", nil)) add_optional(options, "response_checksum_calculation_enabled", l.p("#{scope}.response_checksum_calculation_enabled", nil)) add_optional(options, "uploader_request_checksum_calculation_enabled", l.p("#{scope}.uploader_request_checksum_calculation_enabled", nil)) + add_optional(options, "http_request_timeout", l.p("#{scope}.http_request_timeout", nil)) end if provider == "alioss" @@ -85,6 +87,7 @@ if provider == "alioss" options["access_key_secret"] = l.p("#{scope}.aliyun_accesskey_secret") options["endpoint"] = l.p("#{scope}.aliyun_oss_endpoint") options["bucket_name"] = l.p("#{scope}.aliyun_oss_bucket") + add_optional(options, "http_request_timeout", l.p("#{scope}.http_request_timeout", nil)) end diff --git a/jobs/blobstore_benchmark/templates/storage_cli_config_packages.json.erb b/jobs/blobstore_benchmark/templates/storage_cli_config_packages.json.erb index 4208fffd2f..f9e34e12f8 100644 --- a/jobs/blobstore_benchmark/templates/storage_cli_config_packages.json.erb +++ b/jobs/blobstore_benchmark/templates/storage_cli_config_packages.json.erb @@ -42,6 +42,7 @@ if provider == "gcs" options["bucket_name"] = l.p("#{scope}.bucket_name") add_optional(options, "storage_class", l.p("#{scope}.storage_class", nil)) add_optional(options, "encryption_key", l.p("#{scope}.encryption_key", nil)) + add_optional(options, "http_request_timeout", l.p("#{scope}.http_request_timeout", nil)) end if provider == "s3" @@ -77,6 +78,7 @@ if provider == "s3" add_optional(options, "request_checksum_calculation_enabled", l.p("#{scope}.request_checksum_calculation_enabled", nil)) add_optional(options, "response_checksum_calculation_enabled", l.p("#{scope}.response_checksum_calculation_enabled", nil)) add_optional(options, "uploader_request_checksum_calculation_enabled", l.p("#{scope}.uploader_request_checksum_calculation_enabled", nil)) + add_optional(options, "http_request_timeout", l.p("#{scope}.http_request_timeout", nil)) end if provider == "alioss" @@ -85,6 +87,7 @@ if provider == "alioss" options["access_key_secret"] = l.p("#{scope}.aliyun_accesskey_secret") options["endpoint"] = l.p("#{scope}.aliyun_oss_endpoint") options["bucket_name"] = l.p("#{scope}.aliyun_oss_bucket") + add_optional(options, "http_request_timeout", l.p("#{scope}.http_request_timeout", nil)) end diff --git a/jobs/blobstore_benchmark/templates/storage_cli_config_resource_pool.json.erb b/jobs/blobstore_benchmark/templates/storage_cli_config_resource_pool.json.erb index 1fa2c8549c..87004362bf 100644 --- a/jobs/blobstore_benchmark/templates/storage_cli_config_resource_pool.json.erb +++ b/jobs/blobstore_benchmark/templates/storage_cli_config_resource_pool.json.erb @@ -42,6 +42,7 @@ if provider == "gcs" options["bucket_name"] = l.p("#{scope}.bucket_name") add_optional(options, "storage_class", l.p("#{scope}.storage_class", nil)) add_optional(options, "encryption_key", l.p("#{scope}.encryption_key", nil)) + add_optional(options, "http_request_timeout", l.p("#{scope}.http_request_timeout", nil)) end if provider == "s3" @@ -77,6 +78,7 @@ if provider == "s3" add_optional(options, "request_checksum_calculation_enabled", l.p("#{scope}.request_checksum_calculation_enabled", nil)) add_optional(options, "response_checksum_calculation_enabled", l.p("#{scope}.response_checksum_calculation_enabled", nil)) add_optional(options, "uploader_request_checksum_calculation_enabled", l.p("#{scope}.uploader_request_checksum_calculation_enabled", nil)) + add_optional(options, "http_request_timeout", l.p("#{scope}.http_request_timeout", nil)) end if provider == "alioss" @@ -85,6 +87,7 @@ if provider == "alioss" options["access_key_secret"] = l.p("#{scope}.aliyun_accesskey_secret") options["endpoint"] = l.p("#{scope}.aliyun_oss_endpoint") options["bucket_name"] = l.p("#{scope}.aliyun_oss_bucket") + add_optional(options, "http_request_timeout", l.p("#{scope}.http_request_timeout", nil)) end diff --git a/jobs/cc_deployment_updater/templates/storage_cli_config_buildpacks.json.erb b/jobs/cc_deployment_updater/templates/storage_cli_config_buildpacks.json.erb index afdf3a07a5..8b6e775cda 100644 --- a/jobs/cc_deployment_updater/templates/storage_cli_config_buildpacks.json.erb +++ b/jobs/cc_deployment_updater/templates/storage_cli_config_buildpacks.json.erb @@ -42,6 +42,7 @@ if provider == "gcs" options["bucket_name"] = l.p("#{scope}.bucket_name") add_optional(options, "storage_class", l.p("#{scope}.storage_class", nil)) add_optional(options, "encryption_key", l.p("#{scope}.encryption_key", nil)) + add_optional(options, "http_request_timeout", l.p("#{scope}.http_request_timeout", nil)) end if provider == "s3" @@ -77,6 +78,7 @@ if provider == "s3" add_optional(options, "request_checksum_calculation_enabled", l.p("#{scope}.request_checksum_calculation_enabled", nil)) add_optional(options, "response_checksum_calculation_enabled", l.p("#{scope}.response_checksum_calculation_enabled", nil)) add_optional(options, "uploader_request_checksum_calculation_enabled", l.p("#{scope}.uploader_request_checksum_calculation_enabled", nil)) + add_optional(options, "http_request_timeout", l.p("#{scope}.http_request_timeout", nil)) end if provider == "alioss" @@ -85,6 +87,7 @@ if provider == "alioss" options["access_key_secret"] = l.p("#{scope}.aliyun_accesskey_secret") options["endpoint"] = l.p("#{scope}.aliyun_oss_endpoint") options["bucket_name"] = l.p("#{scope}.aliyun_oss_bucket") + add_optional(options, "http_request_timeout", l.p("#{scope}.http_request_timeout", nil)) end @@ -107,6 +110,6 @@ if provider == "dav" options["tls"]={"cert"=>{"ca"=>ca_cert}} end end - + -%> <%= JSON.pretty_generate(options) %> diff --git a/jobs/cc_deployment_updater/templates/storage_cli_config_droplets.json.erb b/jobs/cc_deployment_updater/templates/storage_cli_config_droplets.json.erb index d4ee28965a..1d9c822064 100644 --- a/jobs/cc_deployment_updater/templates/storage_cli_config_droplets.json.erb +++ b/jobs/cc_deployment_updater/templates/storage_cli_config_droplets.json.erb @@ -42,6 +42,7 @@ if provider == "gcs" options["bucket_name"] = l.p("#{scope}.bucket_name") add_optional(options, "storage_class", l.p("#{scope}.storage_class", nil)) add_optional(options, "encryption_key", l.p("#{scope}.encryption_key", nil)) + add_optional(options, "http_request_timeout", l.p("#{scope}.http_request_timeout", nil)) end if provider == "s3" @@ -77,6 +78,7 @@ if provider == "s3" add_optional(options, "request_checksum_calculation_enabled", l.p("#{scope}.request_checksum_calculation_enabled", nil)) add_optional(options, "response_checksum_calculation_enabled", l.p("#{scope}.response_checksum_calculation_enabled", nil)) add_optional(options, "uploader_request_checksum_calculation_enabled", l.p("#{scope}.uploader_request_checksum_calculation_enabled", nil)) + add_optional(options, "http_request_timeout", l.p("#{scope}.http_request_timeout", nil)) end if provider == "alioss" @@ -85,8 +87,9 @@ if provider == "alioss" options["access_key_secret"] = l.p("#{scope}.aliyun_accesskey_secret") options["endpoint"] = l.p("#{scope}.aliyun_oss_endpoint") options["bucket_name"] = l.p("#{scope}.aliyun_oss_bucket") + add_optional(options, "http_request_timeout", l.p("#{scope}.http_request_timeout", nil)) end - + if provider == "dav" options["provider"] = "dav" diff --git a/jobs/cc_deployment_updater/templates/storage_cli_config_packages.json.erb b/jobs/cc_deployment_updater/templates/storage_cli_config_packages.json.erb index 4208fffd2f..f9e34e12f8 100644 --- a/jobs/cc_deployment_updater/templates/storage_cli_config_packages.json.erb +++ b/jobs/cc_deployment_updater/templates/storage_cli_config_packages.json.erb @@ -42,6 +42,7 @@ if provider == "gcs" options["bucket_name"] = l.p("#{scope}.bucket_name") add_optional(options, "storage_class", l.p("#{scope}.storage_class", nil)) add_optional(options, "encryption_key", l.p("#{scope}.encryption_key", nil)) + add_optional(options, "http_request_timeout", l.p("#{scope}.http_request_timeout", nil)) end if provider == "s3" @@ -77,6 +78,7 @@ if provider == "s3" add_optional(options, "request_checksum_calculation_enabled", l.p("#{scope}.request_checksum_calculation_enabled", nil)) add_optional(options, "response_checksum_calculation_enabled", l.p("#{scope}.response_checksum_calculation_enabled", nil)) add_optional(options, "uploader_request_checksum_calculation_enabled", l.p("#{scope}.uploader_request_checksum_calculation_enabled", nil)) + add_optional(options, "http_request_timeout", l.p("#{scope}.http_request_timeout", nil)) end if provider == "alioss" @@ -85,6 +87,7 @@ if provider == "alioss" options["access_key_secret"] = l.p("#{scope}.aliyun_accesskey_secret") options["endpoint"] = l.p("#{scope}.aliyun_oss_endpoint") options["bucket_name"] = l.p("#{scope}.aliyun_oss_bucket") + add_optional(options, "http_request_timeout", l.p("#{scope}.http_request_timeout", nil)) end diff --git a/jobs/cc_deployment_updater/templates/storage_cli_config_resource_pool.json.erb b/jobs/cc_deployment_updater/templates/storage_cli_config_resource_pool.json.erb index f43306b978..87004362bf 100644 --- a/jobs/cc_deployment_updater/templates/storage_cli_config_resource_pool.json.erb +++ b/jobs/cc_deployment_updater/templates/storage_cli_config_resource_pool.json.erb @@ -42,6 +42,7 @@ if provider == "gcs" options["bucket_name"] = l.p("#{scope}.bucket_name") add_optional(options, "storage_class", l.p("#{scope}.storage_class", nil)) add_optional(options, "encryption_key", l.p("#{scope}.encryption_key", nil)) + add_optional(options, "http_request_timeout", l.p("#{scope}.http_request_timeout", nil)) end if provider == "s3" @@ -77,6 +78,7 @@ if provider == "s3" add_optional(options, "request_checksum_calculation_enabled", l.p("#{scope}.request_checksum_calculation_enabled", nil)) add_optional(options, "response_checksum_calculation_enabled", l.p("#{scope}.response_checksum_calculation_enabled", nil)) add_optional(options, "uploader_request_checksum_calculation_enabled", l.p("#{scope}.uploader_request_checksum_calculation_enabled", nil)) + add_optional(options, "http_request_timeout", l.p("#{scope}.http_request_timeout", nil)) end if provider == "alioss" @@ -85,8 +87,9 @@ if provider == "alioss" options["access_key_secret"] = l.p("#{scope}.aliyun_accesskey_secret") options["endpoint"] = l.p("#{scope}.aliyun_oss_endpoint") options["bucket_name"] = l.p("#{scope}.aliyun_oss_bucket") + add_optional(options, "http_request_timeout", l.p("#{scope}.http_request_timeout", nil)) end - + if provider == "dav" options["provider"] = "dav" diff --git a/jobs/cloud_controller_clock/templates/storage_cli_config_buildpacks.json.erb b/jobs/cloud_controller_clock/templates/storage_cli_config_buildpacks.json.erb index 75cf93c566..4c44d52f12 100644 --- a/jobs/cloud_controller_clock/templates/storage_cli_config_buildpacks.json.erb +++ b/jobs/cloud_controller_clock/templates/storage_cli_config_buildpacks.json.erb @@ -40,6 +40,7 @@ if provider == "gcs" options["bucket_name"] = p("#{scope}.bucket_name") add_optional(options, "storage_class", p("#{scope}.storage_class", nil)) add_optional(options, "encryption_key", p("#{scope}.encryption_key", nil)) + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) end if provider == "s3" @@ -75,6 +76,7 @@ if provider == "s3" add_optional(options, "request_checksum_calculation_enabled", p("#{scope}.request_checksum_calculation_enabled", nil)) add_optional(options, "response_checksum_calculation_enabled", p("#{scope}.response_checksum_calculation_enabled", nil)) add_optional(options, "uploader_request_checksum_calculation_enabled", p("#{scope}.uploader_request_checksum_calculation_enabled", nil)) + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) end if provider == "alioss" @@ -83,6 +85,7 @@ if provider == "alioss" options["access_key_secret"] = p("#{scope}.aliyun_accesskey_secret") options["endpoint"] = p("#{scope}.aliyun_oss_endpoint") options["bucket_name"] = p("#{scope}.aliyun_oss_bucket") + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) end diff --git a/jobs/cloud_controller_clock/templates/storage_cli_config_droplets.json.erb b/jobs/cloud_controller_clock/templates/storage_cli_config_droplets.json.erb index 7a9f52e63f..43d88f2140 100644 --- a/jobs/cloud_controller_clock/templates/storage_cli_config_droplets.json.erb +++ b/jobs/cloud_controller_clock/templates/storage_cli_config_droplets.json.erb @@ -40,6 +40,7 @@ if provider == "gcs" options["bucket_name"] = p("#{scope}.bucket_name") add_optional(options, "storage_class", p("#{scope}.storage_class", nil)) add_optional(options, "encryption_key", p("#{scope}.encryption_key", nil)) + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) end if provider == "s3" @@ -75,6 +76,7 @@ if provider == "s3" add_optional(options, "request_checksum_calculation_enabled", p("#{scope}.request_checksum_calculation_enabled", nil)) add_optional(options, "response_checksum_calculation_enabled", p("#{scope}.response_checksum_calculation_enabled", nil)) add_optional(options, "uploader_request_checksum_calculation_enabled", p("#{scope}.uploader_request_checksum_calculation_enabled", nil)) + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) end if provider == "alioss" @@ -83,6 +85,7 @@ if provider == "alioss" options["access_key_secret"] = p("#{scope}.aliyun_accesskey_secret") options["endpoint"] = p("#{scope}.aliyun_oss_endpoint") options["bucket_name"] = p("#{scope}.aliyun_oss_bucket") + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) end diff --git a/jobs/cloud_controller_clock/templates/storage_cli_config_packages.json.erb b/jobs/cloud_controller_clock/templates/storage_cli_config_packages.json.erb index 8e5af19330..86c65bad80 100644 --- a/jobs/cloud_controller_clock/templates/storage_cli_config_packages.json.erb +++ b/jobs/cloud_controller_clock/templates/storage_cli_config_packages.json.erb @@ -40,6 +40,7 @@ if provider == "gcs" options["bucket_name"] = p("#{scope}.bucket_name") add_optional(options, "storage_class", p("#{scope}.storage_class", nil)) add_optional(options, "encryption_key", p("#{scope}.encryption_key", nil)) + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) end if provider == "s3" @@ -75,6 +76,7 @@ if provider == "s3" add_optional(options, "request_checksum_calculation_enabled", p("#{scope}.request_checksum_calculation_enabled", nil)) add_optional(options, "response_checksum_calculation_enabled", p("#{scope}.response_checksum_calculation_enabled", nil)) add_optional(options, "uploader_request_checksum_calculation_enabled", p("#{scope}.uploader_request_checksum_calculation_enabled", nil)) + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) end if provider == "alioss" @@ -83,6 +85,7 @@ if provider == "alioss" options["access_key_secret"] = p("#{scope}.aliyun_accesskey_secret") options["endpoint"] = p("#{scope}.aliyun_oss_endpoint") options["bucket_name"] = p("#{scope}.aliyun_oss_bucket") + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) end diff --git a/jobs/cloud_controller_clock/templates/storage_cli_config_resource_pool.json.erb b/jobs/cloud_controller_clock/templates/storage_cli_config_resource_pool.json.erb index 3ee5a48aca..00ad02fb6d 100644 --- a/jobs/cloud_controller_clock/templates/storage_cli_config_resource_pool.json.erb +++ b/jobs/cloud_controller_clock/templates/storage_cli_config_resource_pool.json.erb @@ -40,6 +40,7 @@ if provider == "gcs" options["bucket_name"] = p("#{scope}.bucket_name") add_optional(options, "storage_class", p("#{scope}.storage_class", nil)) add_optional(options, "encryption_key", p("#{scope}.encryption_key", nil)) + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) end if provider == "s3" @@ -75,6 +76,7 @@ if provider == "s3" add_optional(options, "request_checksum_calculation_enabled", p("#{scope}.request_checksum_calculation_enabled", nil)) add_optional(options, "response_checksum_calculation_enabled", p("#{scope}.response_checksum_calculation_enabled", nil)) add_optional(options, "uploader_request_checksum_calculation_enabled", p("#{scope}.uploader_request_checksum_calculation_enabled", nil)) + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) end if provider == "alioss" @@ -83,6 +85,7 @@ if provider == "alioss" options["access_key_secret"] = p("#{scope}.aliyun_accesskey_secret") options["endpoint"] = p("#{scope}.aliyun_oss_endpoint") options["bucket_name"] = p("#{scope}.aliyun_oss_bucket") + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) end diff --git a/jobs/cloud_controller_ng/templates/storage_cli_config_buildpacks.json.erb b/jobs/cloud_controller_ng/templates/storage_cli_config_buildpacks.json.erb index 75cf93c566..4c44d52f12 100644 --- a/jobs/cloud_controller_ng/templates/storage_cli_config_buildpacks.json.erb +++ b/jobs/cloud_controller_ng/templates/storage_cli_config_buildpacks.json.erb @@ -40,6 +40,7 @@ if provider == "gcs" options["bucket_name"] = p("#{scope}.bucket_name") add_optional(options, "storage_class", p("#{scope}.storage_class", nil)) add_optional(options, "encryption_key", p("#{scope}.encryption_key", nil)) + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) end if provider == "s3" @@ -75,6 +76,7 @@ if provider == "s3" add_optional(options, "request_checksum_calculation_enabled", p("#{scope}.request_checksum_calculation_enabled", nil)) add_optional(options, "response_checksum_calculation_enabled", p("#{scope}.response_checksum_calculation_enabled", nil)) add_optional(options, "uploader_request_checksum_calculation_enabled", p("#{scope}.uploader_request_checksum_calculation_enabled", nil)) + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) end if provider == "alioss" @@ -83,6 +85,7 @@ if provider == "alioss" options["access_key_secret"] = p("#{scope}.aliyun_accesskey_secret") options["endpoint"] = p("#{scope}.aliyun_oss_endpoint") options["bucket_name"] = p("#{scope}.aliyun_oss_bucket") + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) end diff --git a/jobs/cloud_controller_ng/templates/storage_cli_config_droplets.json.erb b/jobs/cloud_controller_ng/templates/storage_cli_config_droplets.json.erb index 7a9f52e63f..43d88f2140 100644 --- a/jobs/cloud_controller_ng/templates/storage_cli_config_droplets.json.erb +++ b/jobs/cloud_controller_ng/templates/storage_cli_config_droplets.json.erb @@ -40,6 +40,7 @@ if provider == "gcs" options["bucket_name"] = p("#{scope}.bucket_name") add_optional(options, "storage_class", p("#{scope}.storage_class", nil)) add_optional(options, "encryption_key", p("#{scope}.encryption_key", nil)) + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) end if provider == "s3" @@ -75,6 +76,7 @@ if provider == "s3" add_optional(options, "request_checksum_calculation_enabled", p("#{scope}.request_checksum_calculation_enabled", nil)) add_optional(options, "response_checksum_calculation_enabled", p("#{scope}.response_checksum_calculation_enabled", nil)) add_optional(options, "uploader_request_checksum_calculation_enabled", p("#{scope}.uploader_request_checksum_calculation_enabled", nil)) + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) end if provider == "alioss" @@ -83,6 +85,7 @@ if provider == "alioss" options["access_key_secret"] = p("#{scope}.aliyun_accesskey_secret") options["endpoint"] = p("#{scope}.aliyun_oss_endpoint") options["bucket_name"] = p("#{scope}.aliyun_oss_bucket") + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) end diff --git a/jobs/cloud_controller_ng/templates/storage_cli_config_packages.json.erb b/jobs/cloud_controller_ng/templates/storage_cli_config_packages.json.erb index 8e5af19330..86c65bad80 100644 --- a/jobs/cloud_controller_ng/templates/storage_cli_config_packages.json.erb +++ b/jobs/cloud_controller_ng/templates/storage_cli_config_packages.json.erb @@ -40,6 +40,7 @@ if provider == "gcs" options["bucket_name"] = p("#{scope}.bucket_name") add_optional(options, "storage_class", p("#{scope}.storage_class", nil)) add_optional(options, "encryption_key", p("#{scope}.encryption_key", nil)) + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) end if provider == "s3" @@ -75,6 +76,7 @@ if provider == "s3" add_optional(options, "request_checksum_calculation_enabled", p("#{scope}.request_checksum_calculation_enabled", nil)) add_optional(options, "response_checksum_calculation_enabled", p("#{scope}.response_checksum_calculation_enabled", nil)) add_optional(options, "uploader_request_checksum_calculation_enabled", p("#{scope}.uploader_request_checksum_calculation_enabled", nil)) + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) end if provider == "alioss" @@ -83,6 +85,7 @@ if provider == "alioss" options["access_key_secret"] = p("#{scope}.aliyun_accesskey_secret") options["endpoint"] = p("#{scope}.aliyun_oss_endpoint") options["bucket_name"] = p("#{scope}.aliyun_oss_bucket") + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) end diff --git a/jobs/cloud_controller_ng/templates/storage_cli_config_resource_pool.json.erb b/jobs/cloud_controller_ng/templates/storage_cli_config_resource_pool.json.erb index 3ee5a48aca..00ad02fb6d 100644 --- a/jobs/cloud_controller_ng/templates/storage_cli_config_resource_pool.json.erb +++ b/jobs/cloud_controller_ng/templates/storage_cli_config_resource_pool.json.erb @@ -40,6 +40,7 @@ if provider == "gcs" options["bucket_name"] = p("#{scope}.bucket_name") add_optional(options, "storage_class", p("#{scope}.storage_class", nil)) add_optional(options, "encryption_key", p("#{scope}.encryption_key", nil)) + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) end if provider == "s3" @@ -75,6 +76,7 @@ if provider == "s3" add_optional(options, "request_checksum_calculation_enabled", p("#{scope}.request_checksum_calculation_enabled", nil)) add_optional(options, "response_checksum_calculation_enabled", p("#{scope}.response_checksum_calculation_enabled", nil)) add_optional(options, "uploader_request_checksum_calculation_enabled", p("#{scope}.uploader_request_checksum_calculation_enabled", nil)) + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) end if provider == "alioss" @@ -83,6 +85,7 @@ if provider == "alioss" options["access_key_secret"] = p("#{scope}.aliyun_accesskey_secret") options["endpoint"] = p("#{scope}.aliyun_oss_endpoint") options["bucket_name"] = p("#{scope}.aliyun_oss_bucket") + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) end diff --git a/jobs/cloud_controller_worker/templates/storage_cli_config_buildpacks.json.erb b/jobs/cloud_controller_worker/templates/storage_cli_config_buildpacks.json.erb index 75cf93c566..4c44d52f12 100644 --- a/jobs/cloud_controller_worker/templates/storage_cli_config_buildpacks.json.erb +++ b/jobs/cloud_controller_worker/templates/storage_cli_config_buildpacks.json.erb @@ -40,6 +40,7 @@ if provider == "gcs" options["bucket_name"] = p("#{scope}.bucket_name") add_optional(options, "storage_class", p("#{scope}.storage_class", nil)) add_optional(options, "encryption_key", p("#{scope}.encryption_key", nil)) + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) end if provider == "s3" @@ -75,6 +76,7 @@ if provider == "s3" add_optional(options, "request_checksum_calculation_enabled", p("#{scope}.request_checksum_calculation_enabled", nil)) add_optional(options, "response_checksum_calculation_enabled", p("#{scope}.response_checksum_calculation_enabled", nil)) add_optional(options, "uploader_request_checksum_calculation_enabled", p("#{scope}.uploader_request_checksum_calculation_enabled", nil)) + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) end if provider == "alioss" @@ -83,6 +85,7 @@ if provider == "alioss" options["access_key_secret"] = p("#{scope}.aliyun_accesskey_secret") options["endpoint"] = p("#{scope}.aliyun_oss_endpoint") options["bucket_name"] = p("#{scope}.aliyun_oss_bucket") + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) end diff --git a/jobs/cloud_controller_worker/templates/storage_cli_config_droplets.json.erb b/jobs/cloud_controller_worker/templates/storage_cli_config_droplets.json.erb index 7a9f52e63f..43d88f2140 100644 --- a/jobs/cloud_controller_worker/templates/storage_cli_config_droplets.json.erb +++ b/jobs/cloud_controller_worker/templates/storage_cli_config_droplets.json.erb @@ -40,6 +40,7 @@ if provider == "gcs" options["bucket_name"] = p("#{scope}.bucket_name") add_optional(options, "storage_class", p("#{scope}.storage_class", nil)) add_optional(options, "encryption_key", p("#{scope}.encryption_key", nil)) + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) end if provider == "s3" @@ -75,6 +76,7 @@ if provider == "s3" add_optional(options, "request_checksum_calculation_enabled", p("#{scope}.request_checksum_calculation_enabled", nil)) add_optional(options, "response_checksum_calculation_enabled", p("#{scope}.response_checksum_calculation_enabled", nil)) add_optional(options, "uploader_request_checksum_calculation_enabled", p("#{scope}.uploader_request_checksum_calculation_enabled", nil)) + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) end if provider == "alioss" @@ -83,6 +85,7 @@ if provider == "alioss" options["access_key_secret"] = p("#{scope}.aliyun_accesskey_secret") options["endpoint"] = p("#{scope}.aliyun_oss_endpoint") options["bucket_name"] = p("#{scope}.aliyun_oss_bucket") + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) end diff --git a/jobs/cloud_controller_worker/templates/storage_cli_config_packages.json.erb b/jobs/cloud_controller_worker/templates/storage_cli_config_packages.json.erb index 467dcff293..86c65bad80 100644 --- a/jobs/cloud_controller_worker/templates/storage_cli_config_packages.json.erb +++ b/jobs/cloud_controller_worker/templates/storage_cli_config_packages.json.erb @@ -40,6 +40,7 @@ if provider == "gcs" options["bucket_name"] = p("#{scope}.bucket_name") add_optional(options, "storage_class", p("#{scope}.storage_class", nil)) add_optional(options, "encryption_key", p("#{scope}.encryption_key", nil)) + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) end if provider == "s3" @@ -75,6 +76,7 @@ if provider == "s3" add_optional(options, "request_checksum_calculation_enabled", p("#{scope}.request_checksum_calculation_enabled", nil)) add_optional(options, "response_checksum_calculation_enabled", p("#{scope}.response_checksum_calculation_enabled", nil)) add_optional(options, "uploader_request_checksum_calculation_enabled", p("#{scope}.uploader_request_checksum_calculation_enabled", nil)) + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) end if provider == "alioss" @@ -83,8 +85,9 @@ if provider == "alioss" options["access_key_secret"] = p("#{scope}.aliyun_accesskey_secret") options["endpoint"] = p("#{scope}.aliyun_oss_endpoint") options["bucket_name"] = p("#{scope}.aliyun_oss_bucket") + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) end - + if provider == "dav" options["provider"] = "dav" diff --git a/jobs/cloud_controller_worker/templates/storage_cli_config_resource_pool.json.erb b/jobs/cloud_controller_worker/templates/storage_cli_config_resource_pool.json.erb index a7805201f3..00ad02fb6d 100644 --- a/jobs/cloud_controller_worker/templates/storage_cli_config_resource_pool.json.erb +++ b/jobs/cloud_controller_worker/templates/storage_cli_config_resource_pool.json.erb @@ -40,6 +40,7 @@ if provider == "gcs" options["bucket_name"] = p("#{scope}.bucket_name") add_optional(options, "storage_class", p("#{scope}.storage_class", nil)) add_optional(options, "encryption_key", p("#{scope}.encryption_key", nil)) + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) end if provider == "s3" @@ -75,6 +76,7 @@ if provider == "s3" add_optional(options, "request_checksum_calculation_enabled", p("#{scope}.request_checksum_calculation_enabled", nil)) add_optional(options, "response_checksum_calculation_enabled", p("#{scope}.response_checksum_calculation_enabled", nil)) add_optional(options, "uploader_request_checksum_calculation_enabled", p("#{scope}.uploader_request_checksum_calculation_enabled", nil)) + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) end if provider == "alioss" @@ -83,8 +85,9 @@ if provider == "alioss" options["access_key_secret"] = p("#{scope}.aliyun_accesskey_secret") options["endpoint"] = p("#{scope}.aliyun_oss_endpoint") options["bucket_name"] = p("#{scope}.aliyun_oss_bucket") + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) end - + if provider == "dav" options["provider"] = "dav" diff --git a/spec/cc_deployment_updater/storage_cli_config_jsons_spec.rb b/spec/cc_deployment_updater/storage_cli_config_jsons_spec.rb index ba2fc4900f..f80aa8f550 100644 --- a/spec/cc_deployment_updater/storage_cli_config_jsons_spec.rb +++ b/spec/cc_deployment_updater/storage_cli_config_jsons_spec.rb @@ -192,7 +192,8 @@ def props_for_provider(provider) 'single_upload_threshold' => 2048, 'request_checksum_calculation_enabled' => false, 'response_checksum_calculation_enabled' => false, - 'uploader_request_checksum_calculation_enabled' => false + 'uploader_request_checksum_calculation_enabled' => false, + 'http_request_timeout' => '30s' }) json = YAML.safe_load(template.render(props, consumes: links)) @@ -222,7 +223,8 @@ def props_for_provider(provider) 'single_upload_threshold' => 2048, 'request_checksum_calculation_enabled' => false, 'response_checksum_calculation_enabled' => false, - 'uploader_request_checksum_calculation_enabled' => false + 'uploader_request_checksum_calculation_enabled' => false, + 'http_request_timeout' => '30s' ) end end @@ -265,8 +267,8 @@ def props_for_provider(provider) 'bucket_name' => 'bucket', 'google_json_key_string' => '{}', 'storage_class' => 'STANDARD', - 'encryption_key' => 'key' - + 'encryption_key' => 'key', + 'http_request_timeout' => '30s' }) json = YAML.safe_load(template.render(props, consumes: links)) @@ -276,7 +278,8 @@ def props_for_provider(provider) 'json_key' => '{}', 'credentials_source' => 'static', 'storage_class' => 'STANDARD', - 'encryption_key' => 'key' + 'encryption_key' => 'key', + 'http_request_timeout' => '30s' ) end end @@ -315,6 +318,19 @@ def props_for_provider(provider) 'bucket_name' => 'bucket' ) end + + it 'includes http_request_timeout when provided' do + set(link_props, keypath, { + 'provider' => 'alioss', + 'aliyun_accesskey_id' => 'key', + 'aliyun_accesskey_secret' => 'secret', + 'aliyun_oss_endpoint' => 'alioss.com', + 'aliyun_oss_bucket' => 'bucket', + 'http_request_timeout' => '30s' + }) + json = YAML.safe_load(template.render(props, consumes: links)) + expect(json).to include('http_request_timeout' => '30s') + end end end end diff --git a/spec/cloud_controller_clock/storage_cli_config_jsons_spec.rb b/spec/cloud_controller_clock/storage_cli_config_jsons_spec.rb index 2b9f75e4bf..2a719ed606 100644 --- a/spec/cloud_controller_clock/storage_cli_config_jsons_spec.rb +++ b/spec/cloud_controller_clock/storage_cli_config_jsons_spec.rb @@ -169,7 +169,8 @@ def props_for_provider(provider) 'single_upload_threshold' => 2048, 'request_checksum_calculation_enabled' => false, 'response_checksum_calculation_enabled' => false, - 'uploader_request_checksum_calculation_enabled' => false + 'uploader_request_checksum_calculation_enabled' => false, + 'http_request_timeout' => '30s' }) json = YAML.safe_load(template.render(props, consumes: links)) @@ -199,7 +200,8 @@ def props_for_provider(provider) 'single_upload_threshold' => 2048, 'request_checksum_calculation_enabled' => false, 'response_checksum_calculation_enabled' => false, - 'uploader_request_checksum_calculation_enabled' => false + 'uploader_request_checksum_calculation_enabled' => false, + 'http_request_timeout' => '30s' ) end end @@ -234,8 +236,8 @@ def props_for_provider(provider) 'bucket_name' => 'bucket', 'google_json_key_string' => '{}', 'storage_class' => 'STANDARD', - 'encryption_key' => 'key' - + 'encryption_key' => 'key', + 'http_request_timeout' => '30s' }) json = YAML.safe_load(template.render(props, consumes: links)) @@ -245,7 +247,8 @@ def props_for_provider(provider) 'json_key' => '{}', 'credentials_source' => 'static', 'storage_class' => 'STANDARD', - 'encryption_key' => 'key' + 'encryption_key' => 'key', + 'http_request_timeout' => '30s' ) end end @@ -276,6 +279,19 @@ def props_for_provider(provider) 'bucket_name' => 'bucket' ) end + + it 'includes http_request_timeout when provided' do + set(props, keypath, { + 'provider' => 'alioss', + 'aliyun_accesskey_id' => 'key', + 'aliyun_accesskey_secret' => 'secret', + 'aliyun_oss_endpoint' => 'alioss.com', + 'aliyun_oss_bucket' => 'bucket', + 'http_request_timeout' => '30s' + }) + json = YAML.safe_load(template.render(props, consumes: links)) + expect(json).to include('http_request_timeout' => '30s') + end end end end diff --git a/spec/cloud_controller_ng/storage_cli_config_jsons_spec.rb b/spec/cloud_controller_ng/storage_cli_config_jsons_spec.rb index d408f0ca7b..e4fe760aaf 100644 --- a/spec/cloud_controller_ng/storage_cli_config_jsons_spec.rb +++ b/spec/cloud_controller_ng/storage_cli_config_jsons_spec.rb @@ -169,7 +169,8 @@ def props_for_provider(provider) 'single_upload_threshold' => 2048, 'request_checksum_calculation_enabled' => false, 'response_checksum_calculation_enabled' => false, - 'uploader_request_checksum_calculation_enabled' => false + 'uploader_request_checksum_calculation_enabled' => false, + 'http_request_timeout' => '30s' }) json = YAML.safe_load(template.render(props, consumes: links)) @@ -199,7 +200,8 @@ def props_for_provider(provider) 'single_upload_threshold' => 2048, 'request_checksum_calculation_enabled' => false, 'response_checksum_calculation_enabled' => false, - 'uploader_request_checksum_calculation_enabled' => false + 'uploader_request_checksum_calculation_enabled' => false, + 'http_request_timeout' => '30s' ) end end @@ -234,8 +236,8 @@ def props_for_provider(provider) 'bucket_name' => 'bucket', 'google_json_key_string' => '{}', 'storage_class' => 'STANDARD', - 'encryption_key' => 'key' - + 'encryption_key' => 'key', + 'http_request_timeout' => '30s' }) json = YAML.safe_load(template.render(props, consumes: links)) @@ -245,7 +247,8 @@ def props_for_provider(provider) 'json_key' => '{}', 'credentials_source' => 'static', 'storage_class' => 'STANDARD', - 'encryption_key' => 'key' + 'encryption_key' => 'key', + 'http_request_timeout' => '30s' ) end end @@ -276,6 +279,19 @@ def props_for_provider(provider) 'bucket_name' => 'bucket' ) end + + it 'includes http_request_timeout when provided' do + set(props, keypath, { + 'provider' => 'alioss', + 'aliyun_accesskey_id' => 'key', + 'aliyun_accesskey_secret' => 'secret', + 'aliyun_oss_endpoint' => 'alioss.com', + 'aliyun_oss_bucket' => 'bucket', + 'http_request_timeout' => '30s' + }) + json = YAML.safe_load(template.render(props, consumes: links)) + expect(json).to include('http_request_timeout' => '30s') + end end end end diff --git a/spec/cloud_controller_worker/storage_cli_config_jsons_spec.rb b/spec/cloud_controller_worker/storage_cli_config_jsons_spec.rb index 23cf5a90c4..e5e667d725 100644 --- a/spec/cloud_controller_worker/storage_cli_config_jsons_spec.rb +++ b/spec/cloud_controller_worker/storage_cli_config_jsons_spec.rb @@ -169,7 +169,8 @@ def props_for_provider(provider) 'single_upload_threshold' => 2048, 'request_checksum_calculation_enabled' => false, 'response_checksum_calculation_enabled' => false, - 'uploader_request_checksum_calculation_enabled' => false + 'uploader_request_checksum_calculation_enabled' => false, + 'http_request_timeout' => '30s' }) json = YAML.safe_load(template.render(props, consumes: links)) @@ -199,7 +200,8 @@ def props_for_provider(provider) 'single_upload_threshold' => 2048, 'request_checksum_calculation_enabled' => false, 'response_checksum_calculation_enabled' => false, - 'uploader_request_checksum_calculation_enabled' => false + 'uploader_request_checksum_calculation_enabled' => false, + 'http_request_timeout' => '30s' ) end end @@ -234,8 +236,8 @@ def props_for_provider(provider) 'bucket_name' => 'bucket', 'google_json_key_string' => '{}', 'storage_class' => 'STANDARD', - 'encryption_key' => 'key' - + 'encryption_key' => 'key', + 'http_request_timeout' => '30s' }) json = YAML.safe_load(template.render(props, consumes: links)) @@ -245,7 +247,8 @@ def props_for_provider(provider) 'json_key' => '{}', 'credentials_source' => 'static', 'storage_class' => 'STANDARD', - 'encryption_key' => 'key' + 'encryption_key' => 'key', + 'http_request_timeout' => '30s' ) end end @@ -276,6 +279,19 @@ def props_for_provider(provider) 'bucket_name' => 'bucket' ) end + + it 'includes http_request_timeout when provided' do + set(props, keypath, { + 'provider' => 'alioss', + 'aliyun_accesskey_id' => 'key', + 'aliyun_accesskey_secret' => 'secret', + 'aliyun_oss_endpoint' => 'alioss.com', + 'aliyun_oss_bucket' => 'bucket', + 'http_request_timeout' => '30s' + }) + json = YAML.safe_load(template.render(props, consumes: links)) + expect(json).to include('http_request_timeout' => '30s') + end end end end From b2849c229120c60f3e40339dfb935d2ed280ebf4 Mon Sep 17 00:00:00 2001 From: Jochen Ehret Date: Fri, 14 Aug 2026 13:36:36 +0200 Subject: [PATCH 2/3] Add "http_request_timeout" option to "azurebs" connection_config --- .../storage_cli_config_buildpacks.json.erb | 1 + .../storage_cli_config_droplets.json.erb | 1 + .../storage_cli_config_packages.json.erb | 1 + .../storage_cli_config_resource_pool.json.erb | 1 + .../storage_cli_config_buildpacks.json.erb | 1 + .../storage_cli_config_droplets.json.erb | 1 + .../storage_cli_config_packages.json.erb | 1 + .../storage_cli_config_resource_pool.json.erb | 1 + .../storage_cli_config_buildpacks.json.erb | 1 + .../storage_cli_config_droplets.json.erb | 1 + .../storage_cli_config_packages.json.erb | 1 + .../storage_cli_config_resource_pool.json.erb | 1 + .../storage_cli_config_buildpacks.json.erb | 1 + .../storage_cli_config_droplets.json.erb | 1 + .../storage_cli_config_packages.json.erb | 1 + .../storage_cli_config_resource_pool.json.erb | 1 + .../storage_cli_config_buildpacks.json.erb | 1 + .../storage_cli_config_droplets.json.erb | 1 + .../storage_cli_config_packages.json.erb | 1 + .../storage_cli_config_resource_pool.json.erb | 1 + .../storage_cli_config_jsons_spec.rb | 23 +++++++++++++++++++ .../storage_cli_config_jsons_spec.rb | 23 +++++++++++++++++++ .../storage_cli_config_jsons_spec.rb | 23 +++++++++++++++++++ .../storage_cli_config_jsons_spec.rb | 23 +++++++++++++++++++ 24 files changed, 112 insertions(+) diff --git a/jobs/blobstore_benchmark/templates/storage_cli_config_buildpacks.json.erb b/jobs/blobstore_benchmark/templates/storage_cli_config_buildpacks.json.erb index 8b6e775cda..babfd8996e 100644 --- a/jobs/blobstore_benchmark/templates/storage_cli_config_buildpacks.json.erb +++ b/jobs/blobstore_benchmark/templates/storage_cli_config_buildpacks.json.erb @@ -32,6 +32,7 @@ if provider == "azurebs" options["account_key"] = l.p("#{scope}.azure_storage_access_key") add_optional(options, "environment", l.p("#{scope}.environment", "AzureCloud")) add_optional(options, "put_timeout_in_seconds", l.p("#{scope}.put_timeout_in_seconds", nil)) + add_optional(options, "http_request_timeout", l.p("#{scope}.http_request_timeout", nil)) options = cli_cfg_with_default_timeout(options, 'storage_cli') end diff --git a/jobs/blobstore_benchmark/templates/storage_cli_config_droplets.json.erb b/jobs/blobstore_benchmark/templates/storage_cli_config_droplets.json.erb index 1d9c822064..c9cbafd38a 100644 --- a/jobs/blobstore_benchmark/templates/storage_cli_config_droplets.json.erb +++ b/jobs/blobstore_benchmark/templates/storage_cli_config_droplets.json.erb @@ -32,6 +32,7 @@ if provider == "azurebs" options["account_key"] = l.p("#{scope}.azure_storage_access_key") add_optional(options, "environment", l.p("#{scope}.environment", "AzureCloud")) add_optional(options, "put_timeout_in_seconds", l.p("#{scope}.put_timeout_in_seconds", nil)) + add_optional(options, "http_request_timeout", l.p("#{scope}.http_request_timeout", nil)) options = cli_cfg_with_default_timeout(options, 'storage_cli') end diff --git a/jobs/blobstore_benchmark/templates/storage_cli_config_packages.json.erb b/jobs/blobstore_benchmark/templates/storage_cli_config_packages.json.erb index f9e34e12f8..08aecc5f16 100644 --- a/jobs/blobstore_benchmark/templates/storage_cli_config_packages.json.erb +++ b/jobs/blobstore_benchmark/templates/storage_cli_config_packages.json.erb @@ -32,6 +32,7 @@ if provider == "azurebs" options["account_key"] = l.p("#{scope}.azure_storage_access_key") add_optional(options, "environment", l.p("#{scope}.environment", "AzureCloud")) add_optional(options, "put_timeout_in_seconds", l.p("#{scope}.put_timeout_in_seconds", nil)) + add_optional(options, "http_request_timeout", l.p("#{scope}.http_request_timeout", nil)) options = cli_cfg_with_default_timeout(options, 'storage_cli') end diff --git a/jobs/blobstore_benchmark/templates/storage_cli_config_resource_pool.json.erb b/jobs/blobstore_benchmark/templates/storage_cli_config_resource_pool.json.erb index 87004362bf..e8daeb4bed 100644 --- a/jobs/blobstore_benchmark/templates/storage_cli_config_resource_pool.json.erb +++ b/jobs/blobstore_benchmark/templates/storage_cli_config_resource_pool.json.erb @@ -32,6 +32,7 @@ if provider == "azurebs" options["account_key"] = l.p("#{scope}.azure_storage_access_key") add_optional(options, "environment", l.p("#{scope}.environment", "AzureCloud")) add_optional(options, "put_timeout_in_seconds", l.p("#{scope}.put_timeout_in_seconds", nil)) + add_optional(options, "http_request_timeout", l.p("#{scope}.http_request_timeout", nil)) options = cli_cfg_with_default_timeout(options, 'storage_cli') end diff --git a/jobs/cc_deployment_updater/templates/storage_cli_config_buildpacks.json.erb b/jobs/cc_deployment_updater/templates/storage_cli_config_buildpacks.json.erb index 8b6e775cda..babfd8996e 100644 --- a/jobs/cc_deployment_updater/templates/storage_cli_config_buildpacks.json.erb +++ b/jobs/cc_deployment_updater/templates/storage_cli_config_buildpacks.json.erb @@ -32,6 +32,7 @@ if provider == "azurebs" options["account_key"] = l.p("#{scope}.azure_storage_access_key") add_optional(options, "environment", l.p("#{scope}.environment", "AzureCloud")) add_optional(options, "put_timeout_in_seconds", l.p("#{scope}.put_timeout_in_seconds", nil)) + add_optional(options, "http_request_timeout", l.p("#{scope}.http_request_timeout", nil)) options = cli_cfg_with_default_timeout(options, 'storage_cli') end diff --git a/jobs/cc_deployment_updater/templates/storage_cli_config_droplets.json.erb b/jobs/cc_deployment_updater/templates/storage_cli_config_droplets.json.erb index 1d9c822064..c9cbafd38a 100644 --- a/jobs/cc_deployment_updater/templates/storage_cli_config_droplets.json.erb +++ b/jobs/cc_deployment_updater/templates/storage_cli_config_droplets.json.erb @@ -32,6 +32,7 @@ if provider == "azurebs" options["account_key"] = l.p("#{scope}.azure_storage_access_key") add_optional(options, "environment", l.p("#{scope}.environment", "AzureCloud")) add_optional(options, "put_timeout_in_seconds", l.p("#{scope}.put_timeout_in_seconds", nil)) + add_optional(options, "http_request_timeout", l.p("#{scope}.http_request_timeout", nil)) options = cli_cfg_with_default_timeout(options, 'storage_cli') end diff --git a/jobs/cc_deployment_updater/templates/storage_cli_config_packages.json.erb b/jobs/cc_deployment_updater/templates/storage_cli_config_packages.json.erb index f9e34e12f8..08aecc5f16 100644 --- a/jobs/cc_deployment_updater/templates/storage_cli_config_packages.json.erb +++ b/jobs/cc_deployment_updater/templates/storage_cli_config_packages.json.erb @@ -32,6 +32,7 @@ if provider == "azurebs" options["account_key"] = l.p("#{scope}.azure_storage_access_key") add_optional(options, "environment", l.p("#{scope}.environment", "AzureCloud")) add_optional(options, "put_timeout_in_seconds", l.p("#{scope}.put_timeout_in_seconds", nil)) + add_optional(options, "http_request_timeout", l.p("#{scope}.http_request_timeout", nil)) options = cli_cfg_with_default_timeout(options, 'storage_cli') end diff --git a/jobs/cc_deployment_updater/templates/storage_cli_config_resource_pool.json.erb b/jobs/cc_deployment_updater/templates/storage_cli_config_resource_pool.json.erb index 87004362bf..e8daeb4bed 100644 --- a/jobs/cc_deployment_updater/templates/storage_cli_config_resource_pool.json.erb +++ b/jobs/cc_deployment_updater/templates/storage_cli_config_resource_pool.json.erb @@ -32,6 +32,7 @@ if provider == "azurebs" options["account_key"] = l.p("#{scope}.azure_storage_access_key") add_optional(options, "environment", l.p("#{scope}.environment", "AzureCloud")) add_optional(options, "put_timeout_in_seconds", l.p("#{scope}.put_timeout_in_seconds", nil)) + add_optional(options, "http_request_timeout", l.p("#{scope}.http_request_timeout", nil)) options = cli_cfg_with_default_timeout(options, 'storage_cli') end diff --git a/jobs/cloud_controller_clock/templates/storage_cli_config_buildpacks.json.erb b/jobs/cloud_controller_clock/templates/storage_cli_config_buildpacks.json.erb index 4c44d52f12..61d009cf08 100644 --- a/jobs/cloud_controller_clock/templates/storage_cli_config_buildpacks.json.erb +++ b/jobs/cloud_controller_clock/templates/storage_cli_config_buildpacks.json.erb @@ -30,6 +30,7 @@ if provider == "azurebs" options["account_key"] = p("#{scope}.azure_storage_access_key") add_optional(options, "environment", p("#{scope}.environment", "AzureCloud")) add_optional(options, "put_timeout_in_seconds", p("#{scope}.put_timeout_in_seconds", nil)) + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) options = cli_cfg_with_default_timeout(options, 'storage_cli') end diff --git a/jobs/cloud_controller_clock/templates/storage_cli_config_droplets.json.erb b/jobs/cloud_controller_clock/templates/storage_cli_config_droplets.json.erb index 43d88f2140..96ce2243a4 100644 --- a/jobs/cloud_controller_clock/templates/storage_cli_config_droplets.json.erb +++ b/jobs/cloud_controller_clock/templates/storage_cli_config_droplets.json.erb @@ -30,6 +30,7 @@ if provider == "azurebs" options["account_key"] = p("#{scope}.azure_storage_access_key") add_optional(options, "environment", p("#{scope}.environment", "AzureCloud")) add_optional(options, "put_timeout_in_seconds", p("#{scope}.put_timeout_in_seconds", nil)) + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) options = cli_cfg_with_default_timeout(options, 'storage_cli') end diff --git a/jobs/cloud_controller_clock/templates/storage_cli_config_packages.json.erb b/jobs/cloud_controller_clock/templates/storage_cli_config_packages.json.erb index 86c65bad80..774fb89732 100644 --- a/jobs/cloud_controller_clock/templates/storage_cli_config_packages.json.erb +++ b/jobs/cloud_controller_clock/templates/storage_cli_config_packages.json.erb @@ -30,6 +30,7 @@ if provider == "azurebs" options["account_key"] = p("#{scope}.azure_storage_access_key") add_optional(options, "environment", p("#{scope}.environment", "AzureCloud")) add_optional(options, "put_timeout_in_seconds", p("#{scope}.put_timeout_in_seconds", nil)) + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) options = cli_cfg_with_default_timeout(options, 'storage_cli') end diff --git a/jobs/cloud_controller_clock/templates/storage_cli_config_resource_pool.json.erb b/jobs/cloud_controller_clock/templates/storage_cli_config_resource_pool.json.erb index 00ad02fb6d..aeef150bf1 100644 --- a/jobs/cloud_controller_clock/templates/storage_cli_config_resource_pool.json.erb +++ b/jobs/cloud_controller_clock/templates/storage_cli_config_resource_pool.json.erb @@ -30,6 +30,7 @@ if provider == "azurebs" options["account_key"] = p("#{scope}.azure_storage_access_key") add_optional(options, "environment", p("#{scope}.environment", "AzureCloud")) add_optional(options, "put_timeout_in_seconds", p("#{scope}.put_timeout_in_seconds", nil)) + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) options = cli_cfg_with_default_timeout(options, 'storage_cli') end diff --git a/jobs/cloud_controller_ng/templates/storage_cli_config_buildpacks.json.erb b/jobs/cloud_controller_ng/templates/storage_cli_config_buildpacks.json.erb index 4c44d52f12..61d009cf08 100644 --- a/jobs/cloud_controller_ng/templates/storage_cli_config_buildpacks.json.erb +++ b/jobs/cloud_controller_ng/templates/storage_cli_config_buildpacks.json.erb @@ -30,6 +30,7 @@ if provider == "azurebs" options["account_key"] = p("#{scope}.azure_storage_access_key") add_optional(options, "environment", p("#{scope}.environment", "AzureCloud")) add_optional(options, "put_timeout_in_seconds", p("#{scope}.put_timeout_in_seconds", nil)) + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) options = cli_cfg_with_default_timeout(options, 'storage_cli') end diff --git a/jobs/cloud_controller_ng/templates/storage_cli_config_droplets.json.erb b/jobs/cloud_controller_ng/templates/storage_cli_config_droplets.json.erb index 43d88f2140..96ce2243a4 100644 --- a/jobs/cloud_controller_ng/templates/storage_cli_config_droplets.json.erb +++ b/jobs/cloud_controller_ng/templates/storage_cli_config_droplets.json.erb @@ -30,6 +30,7 @@ if provider == "azurebs" options["account_key"] = p("#{scope}.azure_storage_access_key") add_optional(options, "environment", p("#{scope}.environment", "AzureCloud")) add_optional(options, "put_timeout_in_seconds", p("#{scope}.put_timeout_in_seconds", nil)) + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) options = cli_cfg_with_default_timeout(options, 'storage_cli') end diff --git a/jobs/cloud_controller_ng/templates/storage_cli_config_packages.json.erb b/jobs/cloud_controller_ng/templates/storage_cli_config_packages.json.erb index 86c65bad80..774fb89732 100644 --- a/jobs/cloud_controller_ng/templates/storage_cli_config_packages.json.erb +++ b/jobs/cloud_controller_ng/templates/storage_cli_config_packages.json.erb @@ -30,6 +30,7 @@ if provider == "azurebs" options["account_key"] = p("#{scope}.azure_storage_access_key") add_optional(options, "environment", p("#{scope}.environment", "AzureCloud")) add_optional(options, "put_timeout_in_seconds", p("#{scope}.put_timeout_in_seconds", nil)) + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) options = cli_cfg_with_default_timeout(options, 'storage_cli') end diff --git a/jobs/cloud_controller_ng/templates/storage_cli_config_resource_pool.json.erb b/jobs/cloud_controller_ng/templates/storage_cli_config_resource_pool.json.erb index 00ad02fb6d..aeef150bf1 100644 --- a/jobs/cloud_controller_ng/templates/storage_cli_config_resource_pool.json.erb +++ b/jobs/cloud_controller_ng/templates/storage_cli_config_resource_pool.json.erb @@ -30,6 +30,7 @@ if provider == "azurebs" options["account_key"] = p("#{scope}.azure_storage_access_key") add_optional(options, "environment", p("#{scope}.environment", "AzureCloud")) add_optional(options, "put_timeout_in_seconds", p("#{scope}.put_timeout_in_seconds", nil)) + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) options = cli_cfg_with_default_timeout(options, 'storage_cli') end diff --git a/jobs/cloud_controller_worker/templates/storage_cli_config_buildpacks.json.erb b/jobs/cloud_controller_worker/templates/storage_cli_config_buildpacks.json.erb index 4c44d52f12..61d009cf08 100644 --- a/jobs/cloud_controller_worker/templates/storage_cli_config_buildpacks.json.erb +++ b/jobs/cloud_controller_worker/templates/storage_cli_config_buildpacks.json.erb @@ -30,6 +30,7 @@ if provider == "azurebs" options["account_key"] = p("#{scope}.azure_storage_access_key") add_optional(options, "environment", p("#{scope}.environment", "AzureCloud")) add_optional(options, "put_timeout_in_seconds", p("#{scope}.put_timeout_in_seconds", nil)) + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) options = cli_cfg_with_default_timeout(options, 'storage_cli') end diff --git a/jobs/cloud_controller_worker/templates/storage_cli_config_droplets.json.erb b/jobs/cloud_controller_worker/templates/storage_cli_config_droplets.json.erb index 43d88f2140..96ce2243a4 100644 --- a/jobs/cloud_controller_worker/templates/storage_cli_config_droplets.json.erb +++ b/jobs/cloud_controller_worker/templates/storage_cli_config_droplets.json.erb @@ -30,6 +30,7 @@ if provider == "azurebs" options["account_key"] = p("#{scope}.azure_storage_access_key") add_optional(options, "environment", p("#{scope}.environment", "AzureCloud")) add_optional(options, "put_timeout_in_seconds", p("#{scope}.put_timeout_in_seconds", nil)) + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) options = cli_cfg_with_default_timeout(options, 'storage_cli') end diff --git a/jobs/cloud_controller_worker/templates/storage_cli_config_packages.json.erb b/jobs/cloud_controller_worker/templates/storage_cli_config_packages.json.erb index 86c65bad80..774fb89732 100644 --- a/jobs/cloud_controller_worker/templates/storage_cli_config_packages.json.erb +++ b/jobs/cloud_controller_worker/templates/storage_cli_config_packages.json.erb @@ -30,6 +30,7 @@ if provider == "azurebs" options["account_key"] = p("#{scope}.azure_storage_access_key") add_optional(options, "environment", p("#{scope}.environment", "AzureCloud")) add_optional(options, "put_timeout_in_seconds", p("#{scope}.put_timeout_in_seconds", nil)) + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) options = cli_cfg_with_default_timeout(options, 'storage_cli') end diff --git a/jobs/cloud_controller_worker/templates/storage_cli_config_resource_pool.json.erb b/jobs/cloud_controller_worker/templates/storage_cli_config_resource_pool.json.erb index 00ad02fb6d..aeef150bf1 100644 --- a/jobs/cloud_controller_worker/templates/storage_cli_config_resource_pool.json.erb +++ b/jobs/cloud_controller_worker/templates/storage_cli_config_resource_pool.json.erb @@ -30,6 +30,7 @@ if provider == "azurebs" options["account_key"] = p("#{scope}.azure_storage_access_key") add_optional(options, "environment", p("#{scope}.environment", "AzureCloud")) add_optional(options, "put_timeout_in_seconds", p("#{scope}.put_timeout_in_seconds", nil)) + add_optional(options, "http_request_timeout", p("#{scope}.http_request_timeout", nil)) options = cli_cfg_with_default_timeout(options, 'storage_cli') end diff --git a/spec/cc_deployment_updater/storage_cli_config_jsons_spec.rb b/spec/cc_deployment_updater/storage_cli_config_jsons_spec.rb index f80aa8f550..1055c8c133 100644 --- a/spec/cc_deployment_updater/storage_cli_config_jsons_spec.rb +++ b/spec/cc_deployment_updater/storage_cli_config_jsons_spec.rb @@ -105,6 +105,29 @@ def props_for_provider(provider) json = YAML.safe_load(template.render(props, consumes: links)) expect(json['put_timeout_in_seconds']).to eq('7') end + + it 'passes http_request_timeout when provided' do + set(link_props, keypath, { + 'provider' => 'azurebs', + 'azure_storage_account_name' => 'acc', + 'azure_storage_access_key' => 'key', + 'container_name' => 'cont', + 'http_request_timeout' => '30s' + }) + json = YAML.safe_load(template.render(props, consumes: links)) + expect(json['http_request_timeout']).to eq('30s') + end + + it 'omits http_request_timeout when not provided' do + set(link_props, keypath, { + 'provider' => 'azurebs', + 'azure_storage_account_name' => 'acc', + 'azure_storage_access_key' => 'key', + 'container_name' => 'cont' + }) + json = YAML.safe_load(template.render(props, consumes: links)) + expect(json).not_to have_key('http_request_timeout') + end end end end diff --git a/spec/cloud_controller_clock/storage_cli_config_jsons_spec.rb b/spec/cloud_controller_clock/storage_cli_config_jsons_spec.rb index 2a719ed606..c8019a218c 100644 --- a/spec/cloud_controller_clock/storage_cli_config_jsons_spec.rb +++ b/spec/cloud_controller_clock/storage_cli_config_jsons_spec.rb @@ -90,6 +90,29 @@ def props_for_provider(provider) json = YAML.safe_load(template.render(props, consumes: links)) expect(json['put_timeout_in_seconds']).to eq('7') end + + it 'passes http_request_timeout when provided' do + set(props, keypath, { + 'provider' => 'azurebs', + 'azure_storage_account_name' => 'acc', + 'azure_storage_access_key' => 'key', + 'container_name' => 'cont', + 'http_request_timeout' => '30s' + }) + json = YAML.safe_load(template.render(props, consumes: links)) + expect(json['http_request_timeout']).to eq('30s') + end + + it 'omits http_request_timeout when not provided' do + set(props, keypath, { + 'provider' => 'azurebs', + 'azure_storage_account_name' => 'acc', + 'azure_storage_access_key' => 'key', + 'container_name' => 'cont' + }) + json = YAML.safe_load(template.render(props, consumes: links)) + expect(json).not_to have_key('http_request_timeout') + end end end end diff --git a/spec/cloud_controller_ng/storage_cli_config_jsons_spec.rb b/spec/cloud_controller_ng/storage_cli_config_jsons_spec.rb index e4fe760aaf..5a7d69b185 100644 --- a/spec/cloud_controller_ng/storage_cli_config_jsons_spec.rb +++ b/spec/cloud_controller_ng/storage_cli_config_jsons_spec.rb @@ -90,6 +90,29 @@ def props_for_provider(provider) json = YAML.safe_load(template.render(props, consumes: links)) expect(json['put_timeout_in_seconds']).to eq('7') end + + it 'passes http_request_timeout when provided' do + set(props, keypath, { + 'provider' => 'azurebs', + 'azure_storage_account_name' => 'acc', + 'azure_storage_access_key' => 'key', + 'container_name' => 'cont', + 'http_request_timeout' => '30s' + }) + json = YAML.safe_load(template.render(props, consumes: links)) + expect(json['http_request_timeout']).to eq('30s') + end + + it 'omits http_request_timeout when not provided' do + set(props, keypath, { + 'provider' => 'azurebs', + 'azure_storage_account_name' => 'acc', + 'azure_storage_access_key' => 'key', + 'container_name' => 'cont' + }) + json = YAML.safe_load(template.render(props, consumes: links)) + expect(json).not_to have_key('http_request_timeout') + end end end end diff --git a/spec/cloud_controller_worker/storage_cli_config_jsons_spec.rb b/spec/cloud_controller_worker/storage_cli_config_jsons_spec.rb index e5e667d725..2b64e7fdcf 100644 --- a/spec/cloud_controller_worker/storage_cli_config_jsons_spec.rb +++ b/spec/cloud_controller_worker/storage_cli_config_jsons_spec.rb @@ -90,6 +90,29 @@ def props_for_provider(provider) json = YAML.safe_load(template.render(props, consumes: links)) expect(json['put_timeout_in_seconds']).to eq('7') end + + it 'passes http_request_timeout when provided' do + set(props, keypath, { + 'provider' => 'azurebs', + 'azure_storage_account_name' => 'acc', + 'azure_storage_access_key' => 'key', + 'container_name' => 'cont', + 'http_request_timeout' => '30s' + }) + json = YAML.safe_load(template.render(props, consumes: links)) + expect(json['http_request_timeout']).to eq('30s') + end + + it 'omits http_request_timeout when not provided' do + set(props, keypath, { + 'provider' => 'azurebs', + 'azure_storage_account_name' => 'acc', + 'azure_storage_access_key' => 'key', + 'container_name' => 'cont' + }) + json = YAML.safe_load(template.render(props, consumes: links)) + expect(json).not_to have_key('http_request_timeout') + end end end end From 30658191608172db652464a0873b1220a9dd2535 Mon Sep 17 00:00:00 2001 From: Jochen Ehret Date: Fri, 14 Aug 2026 13:43:39 +0200 Subject: [PATCH 3/3] Align storage-cli test descriptions --- spec/cc_deployment_updater/storage_cli_config_jsons_spec.rb | 4 ++-- spec/cloud_controller_clock/storage_cli_config_jsons_spec.rb | 4 ++-- spec/cloud_controller_ng/storage_cli_config_jsons_spec.rb | 4 ++-- spec/cloud_controller_worker/storage_cli_config_jsons_spec.rb | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/spec/cc_deployment_updater/storage_cli_config_jsons_spec.rb b/spec/cc_deployment_updater/storage_cli_config_jsons_spec.rb index 1055c8c133..55f76648e7 100644 --- a/spec/cc_deployment_updater/storage_cli_config_jsons_spec.rb +++ b/spec/cc_deployment_updater/storage_cli_config_jsons_spec.rb @@ -106,7 +106,7 @@ def props_for_provider(provider) expect(json['put_timeout_in_seconds']).to eq('7') end - it 'passes http_request_timeout when provided' do + it 'includes http_request_timeout when provided' do set(link_props, keypath, { 'provider' => 'azurebs', 'azure_storage_account_name' => 'acc', @@ -118,7 +118,7 @@ def props_for_provider(provider) expect(json['http_request_timeout']).to eq('30s') end - it 'omits http_request_timeout when not provided' do + it 'excludes http_request_timeout when not provided' do set(link_props, keypath, { 'provider' => 'azurebs', 'azure_storage_account_name' => 'acc', diff --git a/spec/cloud_controller_clock/storage_cli_config_jsons_spec.rb b/spec/cloud_controller_clock/storage_cli_config_jsons_spec.rb index c8019a218c..50de9833fe 100644 --- a/spec/cloud_controller_clock/storage_cli_config_jsons_spec.rb +++ b/spec/cloud_controller_clock/storage_cli_config_jsons_spec.rb @@ -91,7 +91,7 @@ def props_for_provider(provider) expect(json['put_timeout_in_seconds']).to eq('7') end - it 'passes http_request_timeout when provided' do + it 'includes http_request_timeout when provided' do set(props, keypath, { 'provider' => 'azurebs', 'azure_storage_account_name' => 'acc', @@ -103,7 +103,7 @@ def props_for_provider(provider) expect(json['http_request_timeout']).to eq('30s') end - it 'omits http_request_timeout when not provided' do + it 'excludes http_request_timeout when not provided' do set(props, keypath, { 'provider' => 'azurebs', 'azure_storage_account_name' => 'acc', diff --git a/spec/cloud_controller_ng/storage_cli_config_jsons_spec.rb b/spec/cloud_controller_ng/storage_cli_config_jsons_spec.rb index 5a7d69b185..1e2ebcb481 100644 --- a/spec/cloud_controller_ng/storage_cli_config_jsons_spec.rb +++ b/spec/cloud_controller_ng/storage_cli_config_jsons_spec.rb @@ -91,7 +91,7 @@ def props_for_provider(provider) expect(json['put_timeout_in_seconds']).to eq('7') end - it 'passes http_request_timeout when provided' do + it 'includes http_request_timeout when provided' do set(props, keypath, { 'provider' => 'azurebs', 'azure_storage_account_name' => 'acc', @@ -103,7 +103,7 @@ def props_for_provider(provider) expect(json['http_request_timeout']).to eq('30s') end - it 'omits http_request_timeout when not provided' do + it 'excludes http_request_timeout when not provided' do set(props, keypath, { 'provider' => 'azurebs', 'azure_storage_account_name' => 'acc', diff --git a/spec/cloud_controller_worker/storage_cli_config_jsons_spec.rb b/spec/cloud_controller_worker/storage_cli_config_jsons_spec.rb index 2b64e7fdcf..293158714e 100644 --- a/spec/cloud_controller_worker/storage_cli_config_jsons_spec.rb +++ b/spec/cloud_controller_worker/storage_cli_config_jsons_spec.rb @@ -91,7 +91,7 @@ def props_for_provider(provider) expect(json['put_timeout_in_seconds']).to eq('7') end - it 'passes http_request_timeout when provided' do + it 'includes http_request_timeout when provided' do set(props, keypath, { 'provider' => 'azurebs', 'azure_storage_account_name' => 'acc', @@ -103,7 +103,7 @@ def props_for_provider(provider) expect(json['http_request_timeout']).to eq('30s') end - it 'omits http_request_timeout when not provided' do + it 'excludes http_request_timeout when not provided' do set(props, keypath, { 'provider' => 'azurebs', 'azure_storage_account_name' => 'acc',