Skip to content

feat: add link decoration design tokens#4531

Merged
mxschll merged 2 commits into
mainfrom
dev-v3-schomax-link-tokens
May 20, 2026
Merged

feat: add link decoration design tokens#4531
mxschll merged 2 commits into
mainfrom
dev-v3-schomax-link-tokens

Conversation

@mxschll
Copy link
Copy Markdown
Member

@mxschll mxschll commented May 18, 2026

Description

Adds new tokens for theming link decoration.

Related links, issue #, if available: n/a

How has this been tested?

Pipeline is green. Was green. We're green again.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mxschll mxschll changed the title feat: add link decoration design tokens [DO NOT MERGE] feat: add link decoration design tokens May 18, 2026
@mxschll mxschll force-pushed the dev-v3-schomax-link-tokens branch from f1e19b9 to 8a4cd4d Compare May 18, 2026 13:49
@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.42%. Comparing base (ff4e6e2) to head (49d7a31).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4531   +/-   ##
=======================================
  Coverage   97.42%   97.42%           
=======================================
  Files         939      939           
  Lines       29645    29645           
  Branches    10772    10771    -1     
=======================================
  Hits        28883    28883           
- Misses        715      755   +40     
+ Partials       47        7   -40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mxschll mxschll force-pushed the dev-v3-schomax-link-tokens branch from 8a4cd4d to f7931e2 Compare May 18, 2026 19:02
@mxschll mxschll changed the title [DO NOT MERGE] feat: add link decoration design tokens feat: add link decoration design tokens May 18, 2026
Comment thread src/link/constants.scss
'text-underline-offset': 0.25em,
'text-decoration-thickness': 2px,
'text-decoration-thickness': awsui.$font-decoration-thickness-link-display-l,
),
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one uses 2px, so we use a different token. If necessary, we can split the others up too, but there's currently no need for it.

Comment thread src/internal/styles/links.scss
@mxschll mxschll requested a review from NathanZlion May 19, 2026 10:28
@mxschll mxschll force-pushed the dev-v3-schomax-link-tokens branch from 88febec to eead091 Compare May 19, 2026 16:23
@mxschll mxschll force-pushed the dev-v3-schomax-link-tokens branch from eead091 to 3e958e0 Compare May 19, 2026 20:03
Copy link
Copy Markdown
Member

@NathanZlion NathanZlion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Solid 😉 to me

@mxschll mxschll added this pull request to the merge queue May 20, 2026
Merged via the queue into main with commit 7c2631d May 20, 2026
52 checks passed
@mxschll mxschll deleted the dev-v3-schomax-link-tokens branch May 20, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants