Skip to content

Commit bfb560d

Browse files
claudiacodacyclaude
andcommitted
docs(review): note ignored-card rendering convention in gemini styleguide
Record that printIgnoredIssueCard deliberately omits the false-positive warning (the ignore reason already conveys FP status) and that the shared layout lives in printIssueCardBody, so reviewers stop flagging it as a parity gap. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent 4e21ae8 commit bfb560d

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

.gemini/styleguide.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,14 @@ concerns.
3030
versions (no `^`/`~`) for reproducibility and to avoid dependency-confusion
3131
risk. Flagging an unpinned range is correct; suggesting a range is not.
3232

33+
## CLI output / rendering
34+
- `src/utils/formatting.ts` has two issue-card renderers that differ **on
35+
purpose**: `printIgnoredIssueCard` omits the "Potential false positive"
36+
warning that `printIssueCard` shows, because an ignored issue already surfaces
37+
its ignore reason (usually `FalsePositive`) on the metadata line. Don't flag
38+
the missing warning as a parity gap. The shared header/message/file-line block
39+
is factored into `printIssueCardBody`; the trailing sections diverge by design.
40+
3341
## Generated files
3442
- `package-lock.json` and everything under `src/api/client/**` are generated.
3543
Complexity, duplication, and size findings on these are false positives.

0 commit comments

Comments
 (0)