From 17019e99a087dfe8d28e933253d130397e163f3d Mon Sep 17 00:00:00 2001
From: breville <brendan@code.org>
Date: Sun, 8 Mar 2026 13:00:17 +0000
Subject: [PATCH 1/2] Screenreader updates

---
 src/oceans/components/common/Guide.jsx | 45 +++++++++++------------
 src/oceans/components/common/index.jsx | 51 +++++++++++++++-----------
 src/oceans/styles/index.js             | 10 ++++-
 3 files changed, 60 insertions(+), 46 deletions(-)

diff --git a/src/oceans/components/common/Guide.jsx b/src/oceans/components/common/Guide.jsx
index cc1f342c..445e1852 100644
--- a/src/oceans/components/common/Guide.jsx
+++ b/src/oceans/components/common/Guide.jsx
@@ -42,7 +42,7 @@ let UnwrappedGuide = class Guide extends React.Component {
       this.guideDialogRef &&
       this.guideDialogRef.current
     ) {
-      this.guideDialogRef.current.focus();
+      this.guideDialogRef.current.focus({focusVisible: false});
       this.lastFocusedGuideId = currentGuideId;
     } else if (!currentGuide) {
       this.lastFocusedGuideId = null;
@@ -53,7 +53,7 @@ let UnwrappedGuide = class Guide extends React.Component {
     setState({guideShowing: true, guideTypingTimer: undefined});
   }
 
-  onGuideKeyDown = (e) => {
+  onGuideKeyDown = e => {
     if (e.key === ' ' || e.key === 'Enter' || e.key === 'Spacebar') {
       e.preventDefault();
       this.onGuideClick();
@@ -74,14 +74,18 @@ let UnwrappedGuide = class Guide extends React.Component {
         {skipCallback: true}
       );
     } else {
-      // This click did not start text to speech, so attempt
-      // to dismiss the guide.
-      const dismissed = guide.dismissCurrentGuide();
-      if (dismissed) {
-        if (state.textToSpeechLocale) {
-          stopTextToSpeech();
+      // Make sure we don't try and dismiss a guide if it's
+      // not modal.
+      if (currentGuide && !currentGuide.noDimBackground) {
+        // This click did not start text to speech, so attempt
+        // to dismiss the guide.
+        const dismissed = guide.dismissCurrentGuide();
+        if (dismissed) {
+          if (state.textToSpeechLocale) {
+            stopTextToSpeech();
+          }
+          soundLibrary.playSound('other');
         }
-        soundLibrary.playSound('other');
       }
     }
   };
@@ -101,10 +105,7 @@ let UnwrappedGuide = class Guide extends React.Component {
     // Do nothing if there is no current guide, or if we've already started
     // text to speech for the current guide (which might have finished
     // playing by now).
-    if (
-      !currentGuide ||
-      state.textToSpeechCurrentGuide === currentGuide
-    ) {
+    if (!currentGuide || state.textToSpeechCurrentGuide === currentGuide) {
       return false;
     }
 
@@ -183,14 +184,9 @@ let UnwrappedGuide = class Guide extends React.Component {
               key={currentGuide.id}
               style={guideBgStyle}
               onClick={this.onGuideClick}
-              onKeyDown={this.onGuideKeyDown}
-              tabIndex={0}
-              role="button"
-              aria-label={I18n.t('continue')}
               id="uitest-dismiss-guide"
             >
               <div
-                ref={this.guideDialogRef}
                 aria-labelledby="guide-heading"
                 tabIndex={-1}
                 className="guide-dialog"
@@ -206,11 +202,6 @@ let UnwrappedGuide = class Guide extends React.Component {
                     </div>
                   )}
 
-
-                  {/* Visually hidden aria-live region for screen readers */}
-                  <div style={{position: 'absolute', left: '-9999px', width: '1px', height: '1px', overflow: 'hidden'}} aria-live="polite">
-                    {currentGuide.textFn(getState())}
-                  </div>
                   {/* Visible Typist animation for sighted users */}
                   <div style={styles.guideTypingText} aria-hidden="true">
                     <Typist
@@ -230,7 +221,13 @@ let UnwrappedGuide = class Guide extends React.Component {
                         : styles.guideFinalTextContainer
                     }
                   >
-                    <div style={styles.guideFinalText} aria-hidden="true">
+                    <div
+                      ref={this.guideDialogRef}
+                      aria-live="polite"
+                      tabIndex={0}
+                      onKeyDown={this.onGuideKeyDown}
+                      style={styles.guideFinalText}
+                    >
                       {currentGuide.textFn(getState())}
                     </div>
                   </div>
diff --git a/src/oceans/components/common/index.jsx b/src/oceans/components/common/index.jsx
index 139c3cf7..3e705f4f 100644
--- a/src/oceans/components/common/index.jsx
+++ b/src/oceans/components/common/index.jsx
@@ -1,34 +1,43 @@
-import React from 'react'
-import PropTypes from 'prop-types'
+import React from 'react';
+import PropTypes from 'prop-types';
 
-import styles from "@ml/oceans/styles";
+import styles from '@ml/oceans/styles';
+import guide from '@ml/oceans/models/guide';
+import Guide from '@ml/oceans/components/common/Guide';
+import Button from '@ml/oceans/components/common/Button';
+import ConfirmationDialog from '@ml/oceans/components/common/ConfirmationDialog';
+import loadingGif from '@public/images/loading.gif';
 
-import Guide from "@ml/oceans/components/common/Guide";
-import Button from "@ml/oceans/components/common/Button";
-import ConfirmationDialog from "@ml/oceans/components/common/ConfirmationDialog";
-import loadingGif from "@public/images/loading.gif";
+class Body extends React.Component {
+  static propTypes = {
+    children: PropTypes.node,
+    onClick: PropTypes.func
+  };
 
-const Body = ({onClick, children}) => (
-  <div style={styles.body} onClick={onClick}>
-    {children}
-    <Guide />
-  </div>
-)
-Body.propTypes = {
-  children: PropTypes.node,
-  onClick: PropTypes.func
+  render() {
+    const currentGuide = guide?.getCurrentGuide();
+    const modalGuide = currentGuide && !currentGuide.noDimBackground;
+
+    return (
+      <div style={styles.body} onClick={this.props.onClick}>
+        <div style={styles.bodyChildren} inert={modalGuide ? '' : undefined}>
+          {this.props.children}
+        </div>
+        <Guide />
+      </div>
+    );
+  }
 }
 
-const Content = ({children}) => (<div style={styles.content}>{children}</div>)
+const Content = ({children}) => <div style={styles.content}>{children}</div>;
 Content.propTypes = {
   children: PropTypes.node
 };
 
 const Loading = () => (
   <Body>
-    <img src={loadingGif} style={styles.loading} alt="Loading"/>
+    <img src={loadingGif} style={styles.loading} alt="Loading" />
   </Body>
-)
-
+);
 
-export {Body, Content, Loading, Guide, Button, ConfirmationDialog}
+export {Body, Content, Loading, Guide, Button, ConfirmationDialog};
diff --git a/src/oceans/styles/index.js b/src/oceans/styles/index.js
index 03e15c2a..a2cafb64 100644
--- a/src/oceans/styles/index.js
+++ b/src/oceans/styles/index.js
@@ -6,6 +6,13 @@ const styles = {
     width: '100%',
     paddingTop: '56.25%' // for 16:9
   },
+  bodyChildren: {
+    position: 'absolute',
+    top: 0,
+    left: 0,
+    width: '100%',
+    height: '100%'
+  },
   content: {
     position: 'absolute',
     top: 0,
@@ -418,7 +425,8 @@ const styles = {
     cursor: 'pointer',
     height: '100%',
     border: 'none',
-    padding: '10px',
+    padding: '12%',
+    display: 'flex',
     margin: 0,
     ':focus': {
       position: 'relative',

From 57fd1ecc99c7b3b28f5f3b3ee257eecb3be13fd0 Mon Sep 17 00:00:00 2001
From: breville <brendan@code.org>
Date: Mon, 9 Mar 2026 03:35:44 +0000
Subject: [PATCH 2/2] Allow guide focus-visible to be seen

---
 src/oceans/styles/index.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/oceans/styles/index.js b/src/oceans/styles/index.js
index a2cafb64..ffea9ed9 100644
--- a/src/oceans/styles/index.js
+++ b/src/oceans/styles/index.js
@@ -528,7 +528,7 @@ const styles = {
   },
   guideFinalText: {
     padding: 20,
-    opacity: 0
+    color: 'rgba(0,0,0,0)'
   },
   guideClickToContinueReminderContainer: {
     position: 'absolute',