fix(build): add test-utils to convention plugin for Robolectric SDK pin

bmc08gt · bmc08gt · commit e9bc21dfa00a · 2026-06-05T09:05:37.000-04:00
Include :libs:test-utils as a testImplementation dependency in the
base library convention plugin so all modules pick up the
robolectric.properties file pinning SDK to 36. Remove the now-redundant
manual declarations from 15 individual modules.
diff --git a/apps/flipcash/features/cash/build.gradle.kts b/apps/flipcash/features/cash/build.gradle.kts
@@ -11,7 +11,6 @@ dependencies {
     testImplementation(libs.bundles.unit.testing)
     testImplementation(libs.mockito.kotlin)
     testImplementation(libs.robolectric)
-    testImplementation(project(":libs:test-utils"))
 
     implementation(libs.kotlin.stdlib)
     implementation(project(":apps:flipcash:shared:amount-entry"))
diff --git a/apps/flipcash/features/contact-verification/build.gradle.kts b/apps/flipcash/features/contact-verification/build.gradle.kts
@@ -10,7 +10,6 @@ dependencies {
     testImplementation(kotlin("test"))
     testImplementation(libs.bundles.unit.testing)
     testImplementation(libs.mockito.kotlin)
-    testImplementation(project(":libs:test-utils"))
 
     implementation(libs.bundles.kotlinx.serialization)
 
diff --git a/apps/flipcash/features/direct-send/build.gradle.kts b/apps/flipcash/features/direct-send/build.gradle.kts
@@ -11,7 +11,6 @@ dependencies {
     testImplementation(libs.bundles.unit.testing)
     testImplementation(libs.mockito.kotlin)
     testImplementation(libs.robolectric)
-    testImplementation(project(":libs:test-utils"))
 
     implementation(libs.kotlin.stdlib)
     implementation(project(":apps:flipcash:shared:amount-entry"))
diff --git a/apps/flipcash/features/login/build.gradle.kts b/apps/flipcash/features/login/build.gradle.kts
@@ -10,7 +10,6 @@ dependencies {
     testImplementation(kotlin("test"))
     testImplementation(libs.bundles.unit.testing)
     testImplementation(libs.mockito.kotlin)
-    testImplementation(project(":libs:test-utils"))
 
     implementation(project(":apps:flipcash:shared:accesskey"))
     implementation(project(":apps:flipcash:shared:analytics"))
diff --git a/apps/flipcash/features/myaccount/build.gradle.kts b/apps/flipcash/features/myaccount/build.gradle.kts
@@ -10,7 +10,6 @@ dependencies {
     testImplementation(kotlin("test"))
     testImplementation(libs.bundles.unit.testing)
     testImplementation(libs.bundles.compose.ui.testing)
-    testImplementation(project(":libs:test-utils"))
 
     implementation(project(":apps:flipcash:shared:authentication"))
     implementation(project(":apps:flipcash:shared:contacts"))
diff --git a/apps/flipcash/features/transactions/build.gradle.kts b/apps/flipcash/features/transactions/build.gradle.kts
@@ -10,7 +10,6 @@ dependencies {
     testImplementation(kotlin("test"))
     testImplementation(libs.bundles.unit.testing)
     testImplementation(libs.mockito.kotlin)
-    testImplementation(project(":libs:test-utils"))
 
     implementation(libs.compose.paging)
 
diff --git a/apps/flipcash/features/withdrawal/build.gradle.kts b/apps/flipcash/features/withdrawal/build.gradle.kts
@@ -10,7 +10,6 @@ dependencies {
     testImplementation(kotlin("test"))
     testImplementation(libs.bundles.unit.testing)
     testImplementation(libs.bundles.compose.ui.testing)
-    testImplementation(project(":libs:test-utils"))
 
     implementation(project(":apps:flipcash:shared:amount-entry"))
     implementation(project(":apps:flipcash:shared:activityfeed"))
diff --git a/apps/flipcash/shared/amount-entry/build.gradle.kts b/apps/flipcash/shared/amount-entry/build.gradle.kts
@@ -10,5 +10,4 @@ dependencies {
     testImplementation(kotlin("test"))
     testImplementation(libs.bundles.unit.testing)
     testImplementation(libs.bundles.compose.ui.testing)
-    testImplementation(project(":libs:test-utils"))
 }
diff --git a/apps/flipcash/shared/onramp/deeplinks/build.gradle.kts b/apps/flipcash/shared/onramp/deeplinks/build.gradle.kts
@@ -9,7 +9,6 @@ android {
 dependencies {
     testImplementation(kotlin("test"))
     testImplementation(libs.bundles.unit.testing)
-    testImplementation(project(":libs:test-utils"))
 
     implementation(libs.bundles.kotlinx.serialization)
     implementation(libs.phantom.connect) {
diff --git a/apps/flipcash/shared/session/build.gradle.kts b/apps/flipcash/shared/session/build.gradle.kts
@@ -9,7 +9,6 @@ android {
 dependencies {
     testImplementation(kotlin("test"))
     testImplementation(libs.bundles.unit.testing)
-    testImplementation(project(":libs:test-utils"))
 
     implementation(project(":apps:flipcash:shared:contacts"))
     implementation(project(":apps:flipcash:shared:activityfeed"))
diff --git a/apps/flipcash/shared/tokens/build.gradle.kts b/apps/flipcash/shared/tokens/build.gradle.kts
@@ -10,7 +10,6 @@ dependencies {
     testImplementation(kotlin("test"))
     testImplementation(libs.bundles.unit.testing)
     testImplementation(libs.mockito.kotlin)
-    testImplementation(project(":libs:test-utils"))
 
     api(project(":apps:flipcash:shared:tokens:core"))
 
diff --git a/apps/flipcash/shared/userflags/build.gradle.kts b/apps/flipcash/shared/userflags/build.gradle.kts
@@ -22,5 +22,4 @@ dependencies {
     testImplementation(kotlin("test"))
     testImplementation(libs.bundles.unit.testing)
     testImplementation(libs.mockito.kotlin)
-    testImplementation(project(":libs:test-utils"))
 }
diff --git a/apps/flipcash/shared/workers/build.gradle.kts b/apps/flipcash/shared/workers/build.gradle.kts
@@ -20,5 +20,4 @@ dependencies {
     testImplementation(libs.bundles.unit.testing)
     testImplementation(libs.robolectric)
     testImplementation(libs.androidx.work.testing)
-    testImplementation(project(":libs:test-utils"))
 }
diff --git a/build-logic/convention/src/main/kotlin/AndroidLibraryConventionPlugin.kt b/build-logic/convention/src/main/kotlin/AndroidLibraryConventionPlugin.kt
@@ -72,6 +72,10 @@ class AndroidLibraryConventionPlugin : Plugin<Project> {
                 // AGP's built-in Kotlin no longer auto-selects the kotlin-test
                 // JUnit variant, so provide it explicitly for all library modules.
                 "testImplementation"(libs.findLibrary("kotlin-test-junit").get())
+                // Provides robolectric.properties pinning SDK to 36 (latest Robolectric supports).
+                if (path != ":libs:test-utils") {
+                    "testImplementation"(project(":libs:test-utils"))
+                }
             }
         }
     }
diff --git a/libs/datetime/build.gradle.kts b/libs/datetime/build.gradle.kts
@@ -11,5 +11,4 @@ dependencies {
 
     testImplementation(kotlin("test"))
     testImplementation(libs.robolectric)
-    testImplementation(project(":libs:test-utils"))
 }
diff --git a/libs/logging/build.gradle.kts b/libs/logging/build.gradle.kts
@@ -26,7 +26,6 @@ android {
 dependencies {
     testImplementation(kotlin("test"))
     testImplementation(libs.robolectric)
-    testImplementation(project(":libs:test-utils"))
 
     api(libs.timber)
     implementation(libs.androidx.annotation)

Original file line number	Diff line number	Diff line change
`@@ -10,5 +10,4 @@ dependencies {`
`10`	`10`	`testImplementation(kotlin("test"))`
`11`	`11`	`testImplementation(libs.bundles.unit.testing)`
`12`	`12`	`testImplementation(libs.bundles.compose.ui.testing)`
`13`		`- testImplementation(project(":libs:test-utils"))`
`14`	`13`	`}`