support sub flows by raphael-goetz · Pull Request #980 · code0-tech/sagittarius

This PR replaces the old “function value” (NodeFunctionIdWrapper / node_functions.value_of_node_parameter) mechanism with a first-class SubFlow model that can be used as a node-parameter value, and wires it through GraphQL, persistence, and gRPC serialization. It also adds an optional cast field to flow settings and node parameters.

Changes:

Introduces SubFlow + SubFlowSetting models, tables, factories, and specs; updates NodeParameter to use sub_flow instead of function_value.
Updates Flow create/update GraphQL inputs and response unions to accept/return subFlow values (and removes NodeFunctionIdWrapper).
Adds cast to flow_settings and node_parameters (GraphQL + persistence + gRPC), plus docs updates.

Reviewed changes

Copilot reviewed 43 out of 43 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
spec/requests/graphql/mutation/namespace/projects/flows/update_mutation_spec.rb	Updates mutation spec to send/expect `subFlow` parameter values
spec/requests/graphql/mutation/namespace/projects/flows/create_mutation_spec.rb	Updates mutation spec to send/expect `subFlow` parameter values
spec/models/sub_flow_spec.rb	New model spec for `SubFlow` associations/validation
spec/models/sub_flow_setting_spec.rb	New model spec for `SubFlowSetting` associations/validation
spec/models/node_parameter_spec.rb	Replaces `function_value` expectations with `sub_flow`
spec/models/node_function_spec.rb	Removes `value_of_node_parameter` association expectations
spec/factories/sub_flows.rb	Adds factory for `SubFlow`
spec/factories/sub_flow_settings.rb	Adds factory for `SubFlowSetting`
spec/factories/node_parameters.rb	Removes `function_value` factory attribute
spec/factories/node_functions.rb	Removes `value_of_node_parameter` factory attribute
docs/graphql/union/nodeparametervalue.md	Documents `FlowSubFlow` as a possible union type
docs/graphql/object/nodeparameter.md	Documents new `cast` field on NodeParameter
docs/graphql/object/nodefunctionidwrapper.md	Removes docs for deprecated `NodeFunctionIdWrapper`
docs/graphql/object/flowsubflowsetting.md	Adds docs for `FlowSubFlowSetting`
docs/graphql/object/flowsubflow.md	Adds docs for `FlowSubFlow`
docs/graphql/object/flowsetting.md	Documents new `cast` field on FlowSetting
docs/graphql/input_object/nodeparametervalueinput.md	Replaces `nodeFunctionId` with `subFlow` input
docs/graphql/input_object/nodeparameterinput.md	Documents new `cast` input
docs/graphql/input_object/flowsubflowsettinginput.md	Adds docs for `FlowSubFlowSettingInput`
docs/graphql/input_object/flowsubflowinput.md	Adds docs for `FlowSubFlowInput`
docs/graphql/input_object/flowsettinginput.md	Documents new `cast` input on FlowSettingInput
docs/graphql/enum/errorcodeenum.md	Removes `FUNCTION_VALUE_NOT_FOUND` from documented error codes
db/structure.sql	Reflects schema changes: new tables + cast columns + removed FK/index
db/schema_migrations/20260520120000	Adds checksum entry for the new migration
db/migrate/20260520120000_add_tucana_shared_flow_sub_flows.rb	Adds cast columns, creates sub_flow tables, removes old reference
app/services/namespaces/projects/flows/update_service.rb	Implements `cast` handling and `subFlow` update/clear logic
app/services/error_code.rb	Removes obsolete `function_value_not_found` error code
app/models/sub_flow.rb	New `SubFlow` model with gRPC conversion + validation
app/models/sub_flow_setting.rb	New `SubFlowSetting` model with gRPC conversion
app/models/node_parameter.rb	Switches from `function_value` to `sub_flow`; adds `cast` to gRPC
app/models/node_function.rb	Removes `value_of_node_parameter` association
app/models/flow_setting.rb	Adds `cast` to gRPC serialization
app/graphql/types/node_parameter_value_type.rb	Updates union to include `FlowSubFlow` and resolve `SubFlow`
app/graphql/types/node_parameter_type.rb	Adds `cast` field; returns `sub_flow` as the parameter value
app/graphql/types/node_function_id_wrapper_type.rb	Removes deprecated GraphQL type
app/graphql/types/input/node_parameter_value_input_type.rb	Replaces `nodeFunctionId` with `subFlow`; updates one-of validation
app/graphql/types/input/node_parameter_input_type.rb	Adds `cast` input
app/graphql/types/input/flow_sub_flow_setting_input_type.rb	Adds input type for sub-flow settings
app/graphql/types/input/flow_sub_flow_input_type.rb	Adds input type for sub-flow values
app/graphql/types/input/flow_setting_input_type.rb	Adds `cast` input for flow settings
app/graphql/types/flow_sub_flow_type.rb	Adds GraphQL object type for `FlowSubFlow`
app/graphql/types/flow_sub_flow_setting_type.rb	Adds GraphQL object type for `FlowSubFlowSetting`
app/graphql/types/flow_setting_type.rb	Adds `cast` field to FlowSetting GraphQL type

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Niklas van Schrick <mc.taucher2003@gmail.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 43 out of 43 changed files in this pull request and generated 2 comments.

+  factory :sub_flow do
+    node_parameter
+    starting_node factory: :node_function
+    function_definition { nil }
+    signature { '(): VOID' }


Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>

Taucher2003 · 2026-05-24T18:03:30Z

+  class FlowSubFlowType < Types::BaseObject
+    description 'Represents a sub-flow parameter value.'
+
+    field :function_identifier, String,


While the input type should take the function_identifier, this should provide the resolved FunctionDefinition.

Taucher2003 · 2026-05-24T20:19:44Z

+  def to_grpc
+    Tucana::Shared::SubFlowSetting.new(
+      identifier: identifier,
+      default_value: default_value.nil? ? nil : Tucana::Shared::Value.from_ruby(default_value),


Not sure if that is important for you on the runtime side, but Tucana::Shared::Value.from_ruby(nil) creates a proper NULL_VALUE while using nil is basically that the field is not set.

Taucher2003 · 2026-05-24T20:45:45Z

+
+          sub_flow = node_parameter.sub_flow || node_parameter.build_sub_flow
+          sub_flow.assign_attributes(
+            starting_node_id: starting_node_id,


I would expect that you don't need the persistence of new nodes if you assign the starting_node instead of the starting_node_id

Taucher2003 · 2026-05-24T21:19:45Z

+                                    foreign_key: { to_table: :node_parameters, on_delete: :cascade }
+      t.references :starting_node, null: true, foreign_key: { to_table: :node_functions, on_delete: :restrict }
+      t.references :function_definition, null: true, foreign_key: { on_delete: :restrict }
+      t.text :signature, null: false


Forgot this one, it should also have a limit

Suggested change

t.text :signature, null: false

t.text :signature, null: false, limit: 500

raphael-goetz added 3 commits May 20, 2026 21:08

feat: added sub flows and sub flow settings

f8edfb6

feat: adjusted service layers to new sub flow

3e57aa4

fix: corrected migrations

c79b48e

raphael-goetz marked this pull request as ready for review May 21, 2026 19:17

Copilot AI review requested due to automatic review settings May 21, 2026 19:17

Copilot started reviewing on behalf of raphael-goetz May 21, 2026 19:18 View session

Copilot AI reviewed May 21, 2026

View reviewed changes

Taucher2003 reviewed May 23, 2026

View reviewed changes

raphael-goetz and others added 4 commits May 24, 2026 10:24

Update app/models/node_parameter.rb

9dade74

Co-authored-by: Niklas van Schrick <mc.taucher2003@gmail.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>

Update app/models/sub_flow.rb

9aec8ee

Co-authored-by: Niklas van Schrick <mc.taucher2003@gmail.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>

Apply suggestions from code review

c280de1

Co-authored-by: Niklas van Schrick <mc.taucher2003@gmail.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>

feat: added direct reference to function definition

2b3def6

raphael-goetz requested review from Taucher2003 and Copilot May 24, 2026 09:11

Copilot started reviewing on behalf of raphael-goetz May 24, 2026 09:11 View session

Copilot AI reviewed May 24, 2026

View reviewed changes

Comment thread app/services/namespaces/projects/flows/update_service.rb Outdated

Comment thread spec/factories/sub_flows.rb

Comment on lines +4 to +8

factory :sub_flow do

node_parameter

starting_node factory: :node_function

function_definition { nil }

signature { '(): VOID' }

Potential fix for pull request finding

d47a3ab

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>

Taucher2003 reviewed May 24, 2026

View reviewed changes

	t.text :signature, null: false
	t.text :signature, null: false, limit: 500

Conversation

raphael-goetz commented May 21, 2026

Uh oh!

github-actions Bot commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

GitLab Pipeline Action

General information

Job summaries

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented May 21, 2026 •

edited

Loading