From 78a9336372143d5d7a6fc02f5aa54d647c21cb55 Mon Sep 17 00:00:00 2001 From: ramashishmaurya Date: Tue, 22 Sep 2026 23:40:40 +0530 Subject: [PATCH 1/4] fix: add missing type hints in bedrock embedder --- src/dynavec/embeddings/bedrock.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dynavec/embeddings/bedrock.py b/src/dynavec/embeddings/bedrock.py index 523fdc5..063a821 100644 --- a/src/dynavec/embeddings/bedrock.py +++ b/src/dynavec/embeddings/bedrock.py @@ -39,7 +39,7 @@ def __init__( model_id: str = "amazon.titan-embed-text-v2:0", region: str | None = None, dimension: int | None = None, - boto_session=None, + boto_session= any | None = None, ) -> None: import boto3 # local import keeps base import cheap From 4874e319804505a09cb3f6e70d5c05263d3fa128 Mon Sep 17 00:00:00 2001 From: ramashishmaurya Date: Tue, 22 Sep 2026 23:48:55 +0530 Subject: [PATCH 2/4] fix: add more missing type hints --- .github/workflows/publish.yml | 2 +- src/dynavec/embeddings/bedrock.py | 8 ++++---- src/dynavec/eval/chart.py | 2 ++ 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 6504e46..ea766a1 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -34,4 +34,4 @@ jobs: name: dist path: dist/ - name: Publish to PyPI - uses: pypa/gh-action-pypi-publish@release/v1 + uses: pypa/gh-action-pypi-publish@release/v1 \ No newline at end of file diff --git a/src/dynavec/embeddings/bedrock.py b/src/dynavec/embeddings/bedrock.py index 063a821..141d4b0 100644 --- a/src/dynavec/embeddings/bedrock.py +++ b/src/dynavec/embeddings/bedrock.py @@ -9,7 +9,7 @@ import base64 import json from pathlib import Path -from typing import BinaryIO +from typing import BinaryIO , Any from .base import Embedder, Vector @@ -39,7 +39,7 @@ def __init__( model_id: str = "amazon.titan-embed-text-v2:0", region: str | None = None, dimension: int | None = None, - boto_session= any | None = None, + boto_session: Any | None = None, ) -> None: import boto3 # local import keeps base import cheap @@ -99,7 +99,7 @@ def __init__( self, dimension: int = 1024, region: str | None = None, - boto_session=None, + boto_session: Any | None = None, ) -> None: import boto3 @@ -140,7 +140,7 @@ def _invoke( if text is None and image_base64 is None: raise ValueError("At least one of 'text' or 'image' must be provided.") - body: dict = { + body: dict[str , Any] = { "embeddingConfig": { "outputEmbeddingLength": self.dimension, } diff --git a/src/dynavec/eval/chart.py b/src/dynavec/eval/chart.py index 8772436..32b6140 100644 --- a/src/dynavec/eval/chart.py +++ b/src/dynavec/eval/chart.py @@ -229,3 +229,5 @@ def plot_retrieval_metrics( plt.close(fig) return output_path + + From 5e748c8a3146b2aa408f4dbae712ce5c83ea6f21 Mon Sep 17 00:00:00 2001 From: ramashishmaurya Date: Fri, 25 Sep 2026 11:48:16 +0530 Subject: [PATCH 3/4] Revert accidental changes to publish.yml --- .github/workflows/publish.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index ea766a1..6504e46 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -34,4 +34,4 @@ jobs: name: dist path: dist/ - name: Publish to PyPI - uses: pypa/gh-action-pypi-publish@release/v1 \ No newline at end of file + uses: pypa/gh-action-pypi-publish@release/v1 From ac53673e3030e4d7e41454ec6f937e4783c3b09f Mon Sep 17 00:00:00 2001 From: ramashishmaurya Date: Fri, 25 Sep 2026 12:13:53 +0530 Subject: [PATCH 4/4] style: fix import formatting in bedrock.py --- src/dynavec/embeddings/bedrock.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/dynavec/embeddings/bedrock.py b/src/dynavec/embeddings/bedrock.py index 141d4b0..d1c624f 100644 --- a/src/dynavec/embeddings/bedrock.py +++ b/src/dynavec/embeddings/bedrock.py @@ -9,7 +9,7 @@ import base64 import json from pathlib import Path -from typing import BinaryIO , Any +from typing import Any, BinaryIO from .base import Embedder, Vector