Merge pull request #9048 from codeigniter4/dependabot/composer/rector/rector-1.2.1

chore(deps-dev): update rector/rector requirement from 1.2.0 to 1.2.1

Author: samsonasik

composer.json

@@ -32,7 +32,7 @@
         "phpunit/phpcov": "^9.0.2",
         "phpunit/phpunit": "^10.5.16",
         "predis/predis": "^1.1 || ^2.0",
-        "rector/rector": "1.2.0",
+        "rector/rector": "1.2.1",
         "vimeo/psalm": "^5.0"
     },
     "replace": {

phpstan-baseline.php

@@ -7453,12 +7453,6 @@
 	'count' => 1,
 	'path' => __DIR__ . '/system/Helpers/test_helper.php',
 ];
-$ignoreErrors[] = [
-	// identifier: empty.notAllowed
-	'message' => '#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#',
-	'count' => 1,
-	'path' => __DIR__ . '/system/Helpers/text_helper.php',
-];
 $ignoreErrors[] = [
 	// identifier: missingType.iterableValue
 	'message' => '#^Function strip_slashes\\(\\) has parameter \\$str with no value type specified in iterable type array\\.$#',

system/Helpers/text_helper.php

@@ -310,7 +310,7 @@ function convert_accented_characters(string $str): string
         if (! is_array($arrayFrom)) {
             $config = new ForeignCharacters();
 
-            if (empty($config->characterList) || ! is_array($config->characterList)) {
+            if ($config->characterList === [] || ! is_array($config->characterList)) {
                 $arrayFrom = [];
                 $arrayTo   = [];