Skip to content

Commit 2636541

Browse files
committed
docs: add @todo
1 parent 2c829f3 commit 2636541

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

system/Database/Postgre/Connection.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,9 @@ public function connect(bool $persistent = false)
6565
}
6666

6767
// Convert DSN string
68+
// @TODO This format is for PDO_PGSQL.
69+
// https://www.php.net/manual/en/ref.pdo-pgsql.connection.php
70+
// Should deprecate?
6871
if (mb_strpos($this->DSN, 'pgsql:') === 0) {
6972
$this->convertDSN();
7073
}

tests/system/Database/ConfigTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -198,6 +198,9 @@ public function testConnectionGroupWithDSNPostgreNative(): void
198198
*/
199199
public function testConvertDSN(string $input, string $expected): void
200200
{
201+
// @TODO This format is for PDO_PGSQL.
202+
// https://www.php.net/manual/en/ref.pdo-pgsql.connection.php
203+
// Should deprecate?
201204
$this->dsnGroupPostgreNative['DSN'] = $input;
202205
$conn = Config::connect($this->dsnGroupPostgreNative, false);
203206
$this->assertInstanceOf(BaseConnection::class, $conn);

0 commit comments

Comments
 (0)