fix: properly close PTY sessions during server shutdown (#976)

Add closeAllSessions() method to terminal and PTY services to ensure
all terminal sessions are terminated during server shutdown. This
prevents orphan PTY processes that nodemon and similar tools would
detect as lingering sub-processes.

The cleanup handler now:
- Guards against duplicate cleanup with cleanupInProgress flag
- Closes all PTY sessions before disposing other resources
- Uses a 5-second timeout to force exit if cleanup hangs
- Properly awaits all async cleanup operations

Author: ThomasK33

src/cli/server.ts

@@ -97,16 +97,41 @@ const mockWindow: BrowserWindow = {
   console.log(`Server is running on ${server.baseUrl}`);
 
   // Cleanup on shutdown
-  const cleanup = () => {
+  let cleanupInProgress = false;
+  const cleanup = async () => {
+    if (cleanupInProgress) return;
+    cleanupInProgress = true;
+
     console.log("Shutting down server...");
-    void lockfile
-      .release()
-      .then(() => server.close())
-      .then(() => process.exit(0));
+
+    // Force exit after timeout if cleanup hangs
+    const forceExitTimer = setTimeout(() => {
+      console.log("Cleanup timed out, forcing exit...");
+      process.exit(1);
+    }, 5000);
+
+    try {
+      // Close all PTY sessions first (these are the "sub-processes" nodemon sees)
+      serviceContainer.terminalService.closeAllSessions();
+
+      // Dispose background processes
+      await serviceContainer.dispose();
+
+      // Release lockfile and close server
+      await lockfile.release();
+      await server.close();
+
+      clearTimeout(forceExitTimer);
+      process.exit(0);
+    } catch (err) {
+      console.error("Cleanup error:", err);
+      clearTimeout(forceExitTimer);
+      process.exit(1);
+    }
   };
 
-  process.on("SIGINT", cleanup);
-  process.on("SIGTERM", cleanup);
+  process.on("SIGINT", () => void cleanup());
+  process.on("SIGTERM", () => void cleanup());
 })().catch((error) => {
   console.error("Failed to initialize server:", error);
   process.exit(1);

src/node/services/ptyService.ts

@@ -381,6 +381,16 @@ export class PTYService {
     sessionIds.forEach((id) => this.closeSession(id));
   }
 
+  /**
+   * Close all terminal sessions.
+   * Called during server shutdown to prevent orphan PTY processes.
+   */
+  closeAllSessions(): void {
+    const sessionIds = Array.from(this.sessions.keys());
+    log.info(`Closing all ${sessionIds.length} terminal session(s)`);
+    sessionIds.forEach((id) => this.closeSession(id));
+  }
+
   /**
    * Get all sessions for debugging
    */

src/node/services/terminalService.ts

@@ -545,6 +545,14 @@ export class TerminalService {
     this.ptyService.closeWorkspaceSessions(workspaceId);
   }
 
+  /**
+   * Close all terminal sessions.
+   * Called during server shutdown to prevent orphan PTY processes.
+   */
+  closeAllSessions(): void {
+    this.ptyService.closeAllSessions();
+  }
+
   private cleanup(sessionId: string) {
     this.outputEmitters.delete(sessionId);
     this.exitEmitters.delete(sessionId);