refactor: rename Pending* types and files to remove 'pending' prefix

- PendingReview -> Review
- PendingReviewStatus -> ReviewStatus
- usePendingReviews -> useReviews (file and hook)
- PendingReviewsBanner -> ReviewsBanner (file and component)
- UsePendingReviewsReturn -> UseReviewsReturn
- setPendingReviews -> setReviews, createPendingReview -> createReview
- Update all story names to remove 'Pending' prefix

Author: ammar-agent

src/browser/components/AIView.tsx

@@ -50,8 +50,8 @@ import { useAutoCompactionSettings } from "../hooks/useAutoCompactionSettings";
 import { useSendMessageOptions } from "@/browser/hooks/useSendMessageOptions";
 import { useForceCompaction } from "@/browser/hooks/useForceCompaction";
 import { useAPI } from "@/browser/contexts/API";
-import { usePendingReviews } from "@/browser/hooks/usePendingReviews";
-import { PendingReviewsBanner } from "./PendingReviewsBanner";
+import { useReviews } from "@/browser/hooks/useReviews";
+import { ReviewsBanner } from "./ReviewsBanner";
 import type { ReviewNoteData } from "@/common/types/review";
 
 interface AIViewProps {
@@ -109,8 +109,8 @@ const AIViewInner: React.FC<AIViewProps> = ({
   const aggregator = useWorkspaceAggregator(workspaceId);
   const workspaceUsage = useWorkspaceUsage(workspaceId);
 
-  // Pending reviews state
-  const pendingReviews = usePendingReviews(workspaceId);
+  // Reviews state
+  const reviews = useReviews(workspaceId);
   const { options } = useProviderOptions();
   const use1M = options.anthropic?.use1MContext ?? false;
   // Get pending model for auto-compaction settings (threshold is per-model)
@@ -219,13 +219,13 @@ const AIViewInner: React.FC<AIViewProps> = ({
     chatInputAPI.current = api;
   }, []);
 
-  // Handler for review notes from Code Review tab - adds to pending reviews (starts attached)
+  // Handler for review notes from Code Review tab - adds review (starts attached)
   const handleReviewNote = useCallback(
     (data: ReviewNoteData) => {
-      pendingReviews.addReview(data);
+      reviews.addReview(data);
       // New reviews start with status "attached" so they appear in chat input immediately
     },
-    [pendingReviews]
+    [reviews]
   );
 
   // Handler for manual compaction from CompactionWarning click
@@ -617,7 +617,7 @@ const AIViewInner: React.FC<AIViewProps> = ({
             onCompactClick={handleCompactClick}
           />
         )}
-        <PendingReviewsBanner workspaceId={workspaceId} />
+        <ReviewsBanner workspaceId={workspaceId} />
         <ChatInput
           variant="workspace"
           workspaceId={workspaceId}
@@ -633,10 +633,10 @@ const AIViewInner: React.FC<AIViewProps> = ({
           canInterrupt={canInterrupt}
           onReady={handleChatInputReady}
           autoCompactionCheck={autoCompactionResult}
-          attachedReviews={pendingReviews.attachedReviews}
-          onDetachReview={pendingReviews.detachReview}
-          onCheckReviews={(ids) => ids.forEach((id) => pendingReviews.checkReview(id))}
-          onUpdateReviewNote={pendingReviews.updateReviewNote}
+          attachedReviews={reviews.attachedReviews}
+          onDetachReview={reviews.detachReview}
+          onCheckReviews={(ids) => ids.forEach((id) => reviews.checkReview(id))}
+          onUpdateReviewNote={reviews.updateReviewNote}
         />
       </div>
 

src/browser/components/ChatInput/types.ts

@@ -2,7 +2,7 @@ import type { ImagePart } from "@/common/orpc/types";
 import type { FrontendWorkspaceMetadata } from "@/common/types/workspace";
 import type { TelemetryRuntimeType } from "@/common/telemetry/payload";
 import type { AutoCompactionCheckResult } from "@/browser/utils/compaction/autoCompactionCheck";
-import type { PendingReview } from "@/common/types/review";
+import type { Review } from "@/common/types/review";
 
 export interface ChatInputAPI {
   focus: () => void;
@@ -30,8 +30,8 @@ export interface ChatInputWorkspaceVariant {
   disabled?: boolean;
   onReady?: (api: ChatInputAPI) => void;
   autoCompactionCheck?: AutoCompactionCheckResult; // Computed in parent (AIView) to avoid duplicate calculation
-  /** Reviews currently attached to chat (from usePendingReviews hook) */
-  attachedReviews?: PendingReview[];
+  /** Reviews currently attached to chat (from useReviews hook) */
+  attachedReviews?: Review[];
   /** Detach a review from chat input (sets status to pending) */
   onDetachReview?: (reviewId: string) => void;
   /** Mark reviews as checked after sending */

…wser/components/PendingReviewsBanner.tsx src/browser/components/ReviewsBanner.tsxsrc/browser/components/PendingReviewsBanner.tsx renamed to src/browser/components/ReviewsBanner.tsx src/browser/components/PendingReviewsBanner.tsx renamed to src/browser/components/ReviewsBanner.tsx

@@ -1,5 +1,5 @@
 /**
- * PendingReviewsBanner - Self-contained pending reviews UI
+ * ReviewsBanner - Self-contained reviews UI
  *
  * Features:
  * - Collapsible banner above chat input
@@ -25,8 +25,8 @@ import {
 import { cn } from "@/common/lib/utils";
 import { Button } from "./ui/button";
 import { Tooltip, TooltipTrigger, TooltipContent } from "./ui/tooltip";
-import type { PendingReview } from "@/common/types/review";
-import { usePendingReviews } from "@/browser/hooks/usePendingReviews";
+import type { Review } from "@/common/types/review";
+import { useReviews } from "@/browser/hooks/useReviews";
 import { formatRelativeTime } from "@/browser/utils/ui/dateTime";
 import { DiffRenderer } from "./shared/DiffRenderer";
 import { matchesKeybind, KEYBINDS } from "@/browser/utils/ui/keybinds";
@@ -79,7 +79,7 @@ class BannerErrorBoundary extends Component<
 // ═══════════════════════════════════════════════════════════════════════════════
 
 interface ReviewItemProps {
-  review: PendingReview;
+  review: Review;
   onCheck: () => void;
   onUncheck: () => void;
   onSendToChat: () => void;
@@ -309,12 +309,12 @@ const ReviewItem: React.FC<ReviewItemProps> = ({
 // MAIN BANNER COMPONENT
 // ═══════════════════════════════════════════════════════════════════════════════
 
-interface PendingReviewsBannerInnerProps {
+interface ReviewsBannerInnerProps {
   workspaceId: string;
 }
 
-const PendingReviewsBannerInner: React.FC<PendingReviewsBannerInnerProps> = ({ workspaceId }) => {
-  const pendingReviews = usePendingReviews(workspaceId);
+const ReviewsBannerInner: React.FC<ReviewsBannerInnerProps> = ({ workspaceId }) => {
+  const reviewsHook = useReviews(workspaceId);
   const [isExpanded, setIsExpanded] = useState(false);
   const [showAllCompleted, setShowAllCompleted] = useState(false);
 
@@ -323,10 +323,10 @@ const PendingReviewsBannerInner: React.FC<PendingReviewsBannerInnerProps> = ({ w
   // Separate pending and completed reviews
   // "attached" reviews are shown in ChatInput, so we only show "pending" and "checked" here
   const { pendingList, completedList } = useMemo(() => {
-    const pending = pendingReviews.reviews.filter((r) => r.status === "pending");
-    const completed = pendingReviews.reviews.filter((r) => r.status === "checked");
+    const pending = reviewsHook.reviews.filter((r) => r.status === "pending");
+    const completed = reviewsHook.reviews.filter((r) => r.status === "checked");
     return { pendingList: pending, completedList: completed };
-  }, [pendingReviews.reviews]);
+  }, [reviewsHook.reviews]);
 
   // Completed reviews to display (limited unless expanded)
   const displayedCompleted = useMemo(() => {
@@ -342,20 +342,20 @@ const PendingReviewsBannerInner: React.FC<PendingReviewsBannerInnerProps> = ({ w
 
   const handleSendToChat = useCallback(
     (reviewId: string) => {
-      pendingReviews.attachReview(reviewId);
+      reviewsHook.attachReview(reviewId);
     },
-    [pendingReviews]
+    [reviewsHook]
   );
 
   const handleUpdateNote = useCallback(
     (reviewId: string, newNote: string) => {
-      pendingReviews.updateReviewNote(reviewId, newNote);
+      reviewsHook.updateReviewNote(reviewId, newNote);
     },
-    [pendingReviews]
+    [reviewsHook]
   );
 
   // Don't show anything if no reviews
-  if (pendingReviews.reviews.length === 0) {
+  if (reviewsHook.reviews.length === 0) {
     return null;
   }
 
@@ -370,23 +370,23 @@ const PendingReviewsBannerInner: React.FC<PendingReviewsBannerInnerProps> = ({ w
         <MessageSquare
           className={cn(
             "size-3.5",
-            pendingReviews.pendingCount > 0 ? "text-[var(--color-review-accent)]" : "text-muted"
+            reviewsHook.pendingCount > 0 ? "text-[var(--color-review-accent)]" : "text-muted"
           )}
         />
         <span className="text-secondary">
-          {pendingReviews.pendingCount > 0 ? (
+          {reviewsHook.pendingCount > 0 ? (
             <>
               <span className="font-medium text-[var(--color-review-accent)]">
-                {pendingReviews.pendingCount}
+                {reviewsHook.pendingCount}
               </span>
               {" pending review"}
-              {pendingReviews.pendingCount !== 1 && "s"}
+              {reviewsHook.pendingCount !== 1 && "s"}
             </>
           ) : (
             <span className="text-muted">No pending reviews</span>
           )}
-          {pendingReviews.checkedCount > 0 && (
-            <span className="text-muted"> · {pendingReviews.checkedCount} completed</span>
+          {reviewsHook.checkedCount > 0 && (
+            <span className="text-muted"> · {reviewsHook.checkedCount} completed</span>
           )}
         </span>
         <div className="ml-auto">
@@ -411,10 +411,10 @@ const PendingReviewsBannerInner: React.FC<PendingReviewsBannerInnerProps> = ({ w
                 <ReviewItem
                   key={review.id}
                   review={review}
-                  onCheck={() => pendingReviews.checkReview(review.id)}
-                  onUncheck={() => pendingReviews.uncheckReview(review.id)}
+                  onCheck={() => reviewsHook.checkReview(review.id)}
+                  onUncheck={() => reviewsHook.uncheckReview(review.id)}
                   onSendToChat={() => handleSendToChat(review.id)}
-                  onRemove={() => pendingReviews.removeReview(review.id)}
+                  onRemove={() => reviewsHook.removeReview(review.id)}
                   onUpdateNote={(note) => handleUpdateNote(review.id, note)}
                 />
               ))}
@@ -431,7 +431,7 @@ const PendingReviewsBannerInner: React.FC<PendingReviewsBannerInnerProps> = ({ w
                 {completedList.length > 0 && (
                   <button
                     type="button"
-                    onClick={pendingReviews.clearChecked}
+                    onClick={reviewsHook.clearChecked}
                     className="text-muted hover:text-error text-[10px] transition-colors"
                   >
                     Clear
@@ -442,10 +442,10 @@ const PendingReviewsBannerInner: React.FC<PendingReviewsBannerInnerProps> = ({ w
                 <ReviewItem
                   key={review.id}
                   review={review}
-                  onCheck={() => pendingReviews.checkReview(review.id)}
-                  onUncheck={() => pendingReviews.uncheckReview(review.id)}
+                  onCheck={() => reviewsHook.checkReview(review.id)}
+                  onUncheck={() => reviewsHook.uncheckReview(review.id)}
                   onSendToChat={() => handleSendToChat(review.id)}
-                  onRemove={() => pendingReviews.removeReview(review.id)}
+                  onRemove={() => reviewsHook.removeReview(review.id)}
                   onUpdateNote={(note) => handleUpdateNote(review.id, note)}
                 />
               ))}
@@ -476,21 +476,21 @@ const PendingReviewsBannerInner: React.FC<PendingReviewsBannerInnerProps> = ({ w
 // EXPORTED COMPONENT
 // ═══════════════════════════════════════════════════════════════════════════════
 
-interface PendingReviewsBannerProps {
+interface ReviewsBannerProps {
   workspaceId: string;
 }
 
 /**
- * Self-contained pending reviews banner.
- * Uses usePendingReviews hook internally - only needs workspaceId.
+ * Self-contained reviews banner.
+ * Uses useReviews hook internally - only needs workspaceId.
  * Shows only "pending" and "checked" reviews (not "attached" which are in ChatInput).
  */
-export const PendingReviewsBanner: React.FC<PendingReviewsBannerProps> = ({ workspaceId }) => {
-  const pendingReviews = usePendingReviews(workspaceId);
+export const ReviewsBanner: React.FC<ReviewsBannerProps> = ({ workspaceId }) => {
+  const reviewsHook = useReviews(workspaceId);
 
   return (
-    <BannerErrorBoundary onClear={pendingReviews.clearAll}>
-      <PendingReviewsBannerInner workspaceId={workspaceId} />
+    <BannerErrorBoundary onClear={reviewsHook.clearAll}>
+      <ReviewsBannerInner workspaceId={workspaceId} />
     </BannerErrorBoundary>
   );
 };

src/browser/hooks/usePendingReviews.ts src/browser/hooks/useReviews.tssrc/browser/hooks/usePendingReviews.ts renamed to src/browser/hooks/useReviews.ts

@@ -1,12 +1,12 @@
 /**
- * Hook for managing pending reviews per workspace
+ * Hook for managing reviews per workspace
  * Provides interface for adding, checking, and removing reviews
  */
 
 import { useCallback, useMemo } from "react";
 import { usePersistedState } from "./usePersistedState";
 import { getReviewsKey } from "@/common/constants/storage";
-import type { PendingReview, ReviewsState, ReviewNoteData } from "@/common/types/review";
+import type { Review, ReviewsState, ReviewNoteData } from "@/common/types/review";
 
 /**
  * Generate a unique ID for a review
@@ -15,19 +15,19 @@ function generateReviewId(): string {
   return `review-${Date.now()}-${Math.random().toString(36).slice(2, 9)}`;
 }
 
-export interface UsePendingReviewsReturn {
+export interface UseReviewsReturn {
   /** All reviews (pending, attached, and checked) */
-  reviews: PendingReview[];
+  reviews: Review[];
   /** Count of pending reviews (not attached, not checked) */
   pendingCount: number;
   /** Count of attached reviews (in chat input draft) */
   attachedCount: number;
   /** Count of checked reviews */
   checkedCount: number;
   /** Reviews currently attached to chat input */
-  attachedReviews: PendingReview[];
+  attachedReviews: Review[];
   /** Add a new review from structured data (starts as attached) */
-  addReview: (data: ReviewNoteData) => PendingReview;
+  addReview: (data: ReviewNoteData) => Review;
   /** Mark a review as attached to chat input */
   attachReview: (reviewId: string) => void;
   /** Detach a review from chat input (back to pending) */
@@ -45,14 +45,14 @@ export interface UsePendingReviewsReturn {
   /** Clear all reviews (for error recovery) */
   clearAll: () => void;
   /** Get a review by ID */
-  getReview: (reviewId: string) => PendingReview | undefined;
+  getReview: (reviewId: string) => Review | undefined;
 }
 
 /**
- * Hook for managing pending reviews for a workspace
+ * Hook for managing reviews for a workspace
  * Persists reviews to localStorage
  */
-export function usePendingReviews(workspaceId: string): UsePendingReviewsReturn {
+export function useReviews(workspaceId: string): UseReviewsReturn {
   const [state, setState] = usePersistedState<ReviewsState>(
     getReviewsKey(workspaceId),
     {
@@ -85,8 +85,8 @@ export function usePendingReviews(workspaceId: string): UsePendingReviewsReturn
   }, [reviews]);
 
   const addReview = useCallback(
-    (data: ReviewNoteData): PendingReview => {
-      const review: PendingReview = {
+    (data: ReviewNoteData): Review => {
+      const review: Review = {
         id: generateReviewId(),
         data,
         status: "attached", // New reviews start attached to chat input
@@ -260,7 +260,7 @@ export function usePendingReviews(workspaceId: string): UsePendingReviewsReturn
   }, [setState]);
 
   const getReview = useCallback(
-    (reviewId: string): PendingReview | undefined => {
+    (reviewId: string): Review | undefined => {
       return state.reviews[reviewId];
     },
     [state.reviews]