🤖 feat: SSH connection pool with backoff and singleflighting #922
+484
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deansheather
force-pushed
the
ssh-mux-connection-backoff
branch
from
cfa5fa8 to
f611745
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
deansheather
force-pushed
the
ssh-mux-connection-backoff
branch
from
f611745 to
53de00a
Compare
Member
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
deansheather
force-pushed
the
ssh-mux-connection-backoff
branch
from
53de00a to
997109f
Compare
Prevents thundering herd issues with SSH connections by: - Adding SSHConnectionPool class with health tracking - Implementing exponential backoff (1s → 5s → 10s → 20s → 40s → 60s cap) - Singleflighting concurrent connection attempts to same host - Probing unknown connections before first use - Skipping probes for known-healthy connections Integration points: - SSHRuntime.exec() and execSSHCommand() call acquireConnection() - PTYService calls acquireConnection() before spawning SSH terminals _Generated with mux_
- Remove srcBaseDir from connection key: workspaces on same host now
share health tracking and control socket multiplexing
- Fix double markFailedByKey on timeout: add timedOut flag to prevent
both timeout callback and on('close') from incrementing failures
- Add HEALTHY_TTL_MS (5 min): stale healthy connections get re-probed
when network may have silently degraded
- Fix singleflighting test: actually test concurrent probes share
one failure count instead of pre-marking healthy
deansheather
force-pushed
the
ssh-mux-connection-backoff
branch
from
32fdb79 to
7ae97cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents thundering herd issues with SSH connections by adding health tracking, exponential backoff, and singleflighting to the connection pool.
Changes
SSHConnectionPool class with:
Integration points:
SSHRuntime.exec()andexecSSHCommand()callacquireConnection()PTYServicecallsacquireConnection()before spawning SSH terminalsFlow
Generated with
mux