🤖 feat: highlight JSON in generic tool call arguments and results #969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
ammar-agent
force-pushed
the
highlight-json-output
branch
29 times, most recently
from
bfc52fe to
7ac8239
Compare
ammar-agent
force-pushed
the
highlight-json-output
branch
7 times, most recently
from
41de0cd to
0b23501
Compare
- Add HighlightedCode component with optional line numbers - Add JsonHighlight component for tool call display - Update GenericToolCall to use JsonHighlight - Add createGenericTool factory for stories - Add GenericToolCallWithJsonHighlighting story with play function - Update AGENTS.md with storybook best practices
ammar-agent
force-pushed
the
highlight-json-output
branch
from
0b23501 to
b1e80eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds JSON syntax highlighting to the GenericToolCall component, making tool arguments and results easier to read.
Changes
JsonHighlightcomponent using the existinghighlightCodeworker API for Shiki syntax highlightingGenericToolCallto useJsonHighlightfor displaying arguments and resultscreateGenericToolfactory function for storybook testingGenericToolCallWithJsonHighlightingstory to demonstrate the featureTesting
make static-check- all checks passGenerated with
mux