From 0ef948330408eae543e505d15d50c6483ab3ed01 Mon Sep 17 00:00:00 2001 From: schnell3526 Date: Sat, 13 Jun 2026 10:21:27 +0900 Subject: [PATCH] fix(vscode-web): point app healthcheck at /version instead of /healthz The standalone VS Code web server exposes no /healthz route (it returns 404; the path was carried over from code-server, which does expose it). The 404 never surfaced because the agent treats any response below 500 as healthy, but the check only verified that something answers HTTP on the port. /version returns 200 in both the subdomain and path-based cases. --- registry/coder/modules/vscode-web/README.md | 12 ++++++------ registry/coder/modules/vscode-web/main.tf | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/registry/coder/modules/vscode-web/README.md b/registry/coder/modules/vscode-web/README.md index 35cad1adb..8a622f993 100644 --- a/registry/coder/modules/vscode-web/README.md +++ b/registry/coder/modules/vscode-web/README.md @@ -14,7 +14,7 @@ Automatically install [Visual Studio Code Server](https://code.visualstudio.com/ module "vscode-web" { count = data.coder_workspace.me.start_count source = "registry.coder.com/coder/vscode-web/coder" - version = "1.5.0" + version = "1.5.1" agent_id = coder_agent.example.id accept_license = true } @@ -30,7 +30,7 @@ module "vscode-web" { module "vscode-web" { count = data.coder_workspace.me.start_count source = "registry.coder.com/coder/vscode-web/coder" - version = "1.5.0" + version = "1.5.1" agent_id = coder_agent.example.id install_prefix = "/home/coder/.vscode-web" folder = "/home/coder" @@ -44,7 +44,7 @@ module "vscode-web" { module "vscode-web" { count = data.coder_workspace.me.start_count source = "registry.coder.com/coder/vscode-web/coder" - version = "1.5.0" + version = "1.5.1" agent_id = coder_agent.example.id extensions = ["github.copilot", "ms-python.python", "ms-toolsai.jupyter"] accept_license = true @@ -59,7 +59,7 @@ Configure VS Code's [Machine settings.json](https://code.visualstudio.com/docs/g module "vscode-web" { count = data.coder_workspace.me.start_count source = "registry.coder.com/coder/vscode-web/coder" - version = "1.5.0" + version = "1.5.1" agent_id = coder_agent.example.id extensions = ["dracula-theme.theme-dracula"] settings = { @@ -80,7 +80,7 @@ By default, this module installs the latest. To pin a specific version, retrieve module "vscode-web" { count = data.coder_workspace.me.start_count source = "registry.coder.com/coder/vscode-web/coder" - version = "1.5.0" + version = "1.5.1" agent_id = coder_agent.example.id commit_id = "e54c774e0add60467559eb0d1e229c6452cf8447" accept_license = true @@ -96,7 +96,7 @@ Note: Either `workspace` or `folder` can be used, but not both simultaneously. T module "vscode-web" { count = data.coder_workspace.me.start_count source = "registry.coder.com/coder/vscode-web/coder" - version = "1.5.0" + version = "1.5.1" agent_id = coder_agent.example.id workspace = "/home/coder/coder.code-workspace" } diff --git a/registry/coder/modules/vscode-web/main.tf b/registry/coder/modules/vscode-web/main.tf index ff86e455f..2d999b132 100644 --- a/registry/coder/modules/vscode-web/main.tf +++ b/registry/coder/modules/vscode-web/main.tf @@ -240,5 +240,5 @@ locals { "http://localhost:${var.port}${local.server_base_path}?folder=${urlencode(var.folder)}" : "http://localhost:${var.port}${local.server_base_path}" ) - healthcheck_url = var.subdomain ? "http://localhost:${var.port}/healthz" : "http://localhost:${var.port}${local.server_base_path}/healthz" + healthcheck_url = var.subdomain ? "http://localhost:${var.port}/version" : "http://localhost:${var.port}${local.server_base_path}/version" }