refactor: align telemetry outcomes with OpenTelemetry naming

Address review feedback and standardize span outcome vocabulary:

- Rename failure -> error (markError, error.type, *ErrorCategory) to match
  the OTel span status and the error.type semantic convention.
- Unify cancellation on "abort" across the telemetry layer; the VS Code
  cancellation mirrors (CancellationToken, ProgressResult) stay as-is.
- OTLP export: map aborted spans to UNSET and backfill error.type on error
  spans from the exception type/code, falling back to OTel's _OTHER.
- DevContainer casing, type-safe start/update button captions, and test
  cleanups (shared open defaults, multi-connected-agent coverage).

Author: EhabY

src/commands.ts

@@ -25,11 +25,11 @@ import {
 } from "./instrumentation/diagnostics";
 import { WorkspaceOperationTelemetry } from "./instrumentation/workspace";
 import {
-	type DevcontainerMode,
+	type DevContainerMode,
 	type WorkspaceOpenSource,
 	WorkspaceOpenTelemetry,
 	type WorkspaceOpenTrace,
-	type WorkspacePickerFailureCategory,
+	type WorkspacePickerErrorCategory,
 	type WorkspacePickerResult,
 	type WorkspacePickerSource,
 } from "./instrumentation/workspaceOpen";
@@ -102,7 +102,7 @@ type WorkspaceResolution =
 	| { readonly status: "cancelled" }
 	| {
 			readonly status: "failed";
-			readonly category: WorkspacePickerFailureCategory;
+			readonly category: WorkspacePickerErrorCategory;
 	  };
 
 type OpenWorkspaceResult =
@@ -281,7 +281,7 @@ export class Commands {
 	): Promise<void> {
 		const resolved = await this.resolveClientAndWorkspace(item);
 		if (resolved.status === "cancelled") {
-			telemetry.cancel("workspace_picker");
+			telemetry.abort("workspace_picker");
 			return;
 		}
 		if (resolved.status === "failed") {
@@ -304,7 +304,7 @@ export class Commands {
 			},
 		});
 		if (input === undefined) {
-			telemetry.cancel("input");
+			telemetry.abort("input");
 			return;
 		}
 		const seconds = Number(input.trim());
@@ -343,7 +343,7 @@ export class Commands {
 
 		if (!result.ok) {
 			if (result.cancelled) {
-				telemetry.cancel("progress");
+				telemetry.abort("progress");
 				return;
 			}
 			telemetry.fail();
@@ -391,7 +391,7 @@ export class Commands {
 	): Promise<void> {
 		const resolved = await this.resolveClientAndWorkspace(item);
 		if (resolved.status === "cancelled") {
-			telemetry.cancel("workspace_picker");
+			telemetry.abort("workspace_picker");
 			return;
 		}
 		if (resolved.status === "failed") {
@@ -403,7 +403,7 @@ export class Commands {
 
 		const outputUri = await this.promptSupportBundlePath();
 		if (!outputUri) {
-			telemetry.cancel("save_dialog");
+			telemetry.abort("save_dialog");
 			return;
 		}
 
@@ -441,7 +441,7 @@ export class Commands {
 
 		if (!result.ok) {
 			if (result.cancelled) {
-				telemetry.cancel("progress");
+				telemetry.abort("progress");
 				return;
 			}
 			telemetry.fail(
@@ -832,7 +832,7 @@ export class Commands {
 		const agents = await this.extractAgentsWithFallback(item.workspace);
 		const agent = await maybeAskAgent(agents);
 		if (!agent) {
-			telemetry.cancel("agent_picker", { workspace: item.workspace });
+			telemetry.abort("agent_picker", { workspace: item.workspace });
 			return false;
 		}
 		const selection = { workspace: item.workspace, agent };
@@ -911,7 +911,7 @@ export class Commands {
 		} else {
 			const pick = await this.pickWorkspace("workspace_open");
 			if (pick.status === "cancelled") {
-				telemetry.cancel("workspace_picker");
+				telemetry.abort("workspace_picker");
 				return false;
 			}
 			if (pick.status === "failed") {
@@ -924,7 +924,7 @@ export class Commands {
 		const agents = await this.extractAgentsWithFallback(workspace);
 		const agent = await maybeAskAgent(agents, agentName);
 		if (!agent) {
-			telemetry.cancel("agent_picker", { workspace });
+			telemetry.abort("agent_picker", { workspace });
 			return false;
 		}
 		const selection = { workspace, agent };
@@ -952,10 +952,10 @@ export class Commands {
 		localWorkspaceFolder = "",
 		localConfigFile = "",
 	): Promise<void> {
-		const mode: DevcontainerMode = localWorkspaceFolder
+		const mode: DevContainerMode = localWorkspaceFolder
 			? "dev_container"
 			: "attached_container";
-		await this.workspaceOpenTelemetry.traceDevcontainer(mode, () =>
+		await this.workspaceOpenTelemetry.traceDevContainer(mode, () =>
 			this.runOpenDevContainer(
 				workspaceOwner,
 				workspaceName,
@@ -1184,7 +1184,7 @@ export class Commands {
 
 		let lastWorkspaces: readonly Workspace[] = [];
 		let settled = false;
-		let fetchFailureCategory: WorkspacePickerFailureCategory | undefined;
+		let fetchErrorCategory: WorkspacePickerErrorCategory | undefined;
 		const disposables: vscode.Disposable[] = [];
 		disposables.push(
 			quickPick.onDidChangeValue((value) => {
@@ -1194,7 +1194,7 @@ export class Commands {
 						q: value,
 					})
 					.then((workspaces) => {
-						fetchFailureCategory = undefined;
+						fetchErrorCategory = undefined;
 						const filtered = filter
 							? workspaces.workspaces.filter(filter)
 							: workspaces.workspaces;
@@ -1224,7 +1224,7 @@ export class Commands {
 						}
 					})
 					.catch((ex) => {
-						fetchFailureCategory = "fetch_failed";
+						fetchErrorCategory = "fetch_failed";
 						this.logger.error("Failed to fetch workspaces", ex);
 						if (ex instanceof CertificateError) {
 							void ex.showNotification();
@@ -1256,10 +1256,10 @@ export class Commands {
 						};
 						disposables.push(
 							quickPick.onDidHide(() => {
-								if (fetchFailureCategory) {
+								if (fetchErrorCategory) {
 									finish({
 										status: "failed",
-										category: fetchFailureCategory,
+										category: fetchErrorCategory,
 									});
 									return;
 								}
@@ -1460,7 +1460,7 @@ function recordOpenResult(
 	result: OpenWorkspaceResult,
 ): boolean {
 	if (result.status === "cancelled") {
-		telemetry.cancel(result.stage, selection);
+		telemetry.abort(result.stage, selection);
 		return false;
 	}
 	telemetry.handoff(result.handoff);

src/core/cliCredentialManager.ts

@@ -281,8 +281,8 @@ export class CliCredentialManager {
 			binPath = await this.resolveKeyringBinary(url, configs, "keyringAuth");
 		} catch (error) {
 			this.logger.warn("Could not resolve keyring binary for delete:", error);
-			span.setProperty("failure_category", "binary");
-			span.markFailure();
+			span.setProperty("error.type", "binary");
+			span.markError();
 			return;
 		}
 		if (!binPath) {
@@ -298,8 +298,8 @@ export class CliCredentialManager {
 				throw error;
 			}
 			this.logger.warn("Failed to delete token via CLI:", error);
-			span.setProperty("failure_category", "cli");
-			span.markFailure();
+			span.setProperty("error.type", "cli");
+			span.markError();
 		}
 	}
 

src/instrumentation/auth.ts

@@ -117,9 +117,9 @@ export class AuthTelemetry {
 	}
 
 	/**
-	 * Records `auth.login_prompted`. `auth_failed` marks the span as failure;
+	 * Records `auth.login_prompted`. `auth_failed` marks the span as error;
 	 * other non-success reasons mark it as aborted. The reason is copied to the
-	 * span's `reason` property on failure/abort only.
+	 * span's `reason` property on error/abort only.
 	 */
 	public traceLoginPrompt<T extends LoginPromptOutcome>(
 		trigger: AuthLoginPromptTrigger,
@@ -139,11 +139,12 @@ export class AuthTelemetry {
 	}
 }
 
-/** `auth_failed` is a real failure; user/URL dismissals are intentional aborts. */
+/** `auth_failed` is a real error; user/URL dismissals are intentional aborts. */
 function recordReason(span: Span, reason: LoginPromptReason): void {
 	span.setProperty("reason", reason);
 	if (reason === "auth_failed") {
-		span.markFailure();
+		span.setProperty("error.type", reason);
+		span.markError();
 	} else {
 		span.markAborted();
 	}

src/instrumentation/credentials.ts

@@ -6,13 +6,13 @@ import type { WorkspaceConfiguration } from "vscode";
 import type { TelemetryReporter } from "../telemetry/reporter";
 import type { Span } from "../telemetry/span";
 
-export type CredentialFailureCategory = "aborted" | "binary" | "cli" | "file";
+export type CredentialErrorCategory = "aborted" | "binary" | "cli" | "file";
 
 type CredentialEvent = "auth.credential.store" | "auth.credential.clear";
 
 /**
  * Wraps credential store/clear in a span carrying `keyring_enabled`, the
- * `category` of storage involved, and a `failure_category` on failure. The
+ * `category` of storage involved, and an `error.type` on failure. The
  * traced operation sets `category` on the span and reports failures by
  * throwing a categorized error (store) or recording on the span (clear, which
  * is best-effort). Aborts are recorded and re-thrown so callers still unwind.
@@ -47,10 +47,7 @@ export class CredentialTelemetry {
 				try {
 					await fn(span);
 				} catch (error) {
-					span.setProperty(
-						"failure_category",
-						categorizeCredentialError(error),
-					);
+					span.setProperty("error.type", categorizeCredentialError(error));
 					if (isAbortError(error)) {
 						span.markAborted();
 						aborted = error;
@@ -70,7 +67,7 @@ export class CredentialTelemetry {
 	}
 }
 
-function categorizeCredentialError(error: unknown): CredentialFailureCategory {
+function categorizeCredentialError(error: unknown): CredentialErrorCategory {
 	if (isAbortError(error)) {
 		return "aborted";
 	}

src/instrumentation/diagnostics.ts

@@ -1,31 +1,31 @@
-import { recordCancelled, recordFailure } from "./outcomes";
+import { recordAborted, recordError } from "./outcomes";
 
 import type { SpeedtestResult } from "@repo/shared";
 
 import type { TelemetryReporter } from "../telemetry/reporter";
 import type { Span } from "../telemetry/span";
 
-import type { WorkspacePickerFailureCategory } from "./workspaceOpen";
+import type { WorkspacePickerErrorCategory } from "./workspaceOpen";
 
 export type DiagnosticCommand =
 	| "speed_test"
 	| "support_bundle"
 	| "export_telemetry";
-export type DiagnosticFailureCategory =
-	| WorkspacePickerFailureCategory
+export type DiagnosticErrorCategory =
+	| WorkspacePickerErrorCategory
 	| "parse_error"
 	| "unsupported_cli"
 	| "error";
-export type DiagnosticCancelStage =
+export type DiagnosticAbortStage =
 	| "workspace_picker"
 	| "input"
 	| "prompt"
 	| "save_dialog"
 	| "progress";
 
 export interface DiagnosticTrace {
-	cancel(stage: DiagnosticCancelStage): void;
-	fail(category?: DiagnosticFailureCategory): void;
+	abort(stage: DiagnosticAbortStage): void;
+	fail(category?: DiagnosticErrorCategory): void;
 	setRequestedDuration(seconds: number): void;
 	succeedSpeedtest(result: SpeedtestResult): void;
 	succeedExport(format: string, eventCount: number): void;
@@ -50,12 +50,12 @@ export class DiagnosticTelemetry {
 class SpanDiagnosticTrace implements DiagnosticTrace {
 	public constructor(private readonly span: Span) {}
 
-	public cancel(stage: DiagnosticCancelStage): void {
-		recordCancelled(this.span, stage);
+	public abort(stage: DiagnosticAbortStage): void {
+		recordAborted(this.span, stage);
 	}
 
-	public fail(category: DiagnosticFailureCategory = "error"): void {
-		recordFailure(this.span, category);
+	public fail(category: DiagnosticErrorCategory = "error"): void {
+		recordError(this.span, category);
 	}
 
 	public setRequestedDuration(seconds: number): void {

src/instrumentation/outcomes.ts

@@ -2,22 +2,22 @@ import { isAbortError } from "../error/errorUtils";
 
 import type { Span } from "../telemetry/span";
 
-export type AbortableFailureCategory = "aborted" | "error";
+export type AbortableErrorCategory = "aborted" | "error";
 
-/** Records a categorized failure without attaching raw error details. */
-export function recordFailure(span: Span, category: string): void {
-	span.setProperty("failure_category", category);
-	span.markFailure();
+/** Records a categorized error without attaching the raw error details. */
+export function recordError(span: Span, category: string): void {
+	span.setProperty("error.type", category);
+	span.markError();
 }
 
 /** Records the stage at which the user backed out and aborts the span. */
-export function recordCancelled(span: Span, stage: string): void {
-	span.setProperty("cancel_stage", stage);
+export function recordAborted(span: Span, stage: string): void {
+	span.setProperty("abort_stage", stage);
 	span.markAborted();
 }
 
-export function categorizeAbortableFailure(
+export function categorizeAbortableError(
 	error: unknown,
-): AbortableFailureCategory {
+): AbortableErrorCategory {
 	return isAbortError(error) ? "aborted" : "error";
 }