Fix Docker build: use *-all.jar pattern for shadowJar, revert lazy Firestore

Author: codeyousef

Dockerfile

@@ -20,8 +20,8 @@ RUN /workspace/gradlew -x test shadowJar --no-daemon
 FROM eclipse-temurin:17-jre
 WORKDIR /app
 
-# Copy application JAR
-COPY --from=build /workspace/build/libs/*.jar /app/app.jar
+# Copy application JAR (shadow/fat JAR only)
+COPY --from=build /workspace/build/libs/*-all.jar /app/app.jar
 
 # Copy classpath resources (including static assets) alongside the JAR
 COPY --from=build /workspace/src/main/resources/ /app/resources/

src/main/kotlin/Application.kt

@@ -36,23 +36,12 @@ fun Application.module() {
         appConfig.port
     )
 
-    // Lazy initialization: Firestore connects on first use, not at startup
-    val firestoreLazy = lazy { 
-        try {
-            FirestoreProvider.create(appConfig)
-        } catch (e: Exception) {
-            log.error("Failed to initialize Firestore - some features may be unavailable", e)
-            throw e
-        }
-    }
-    val firestore by firestoreLazy
-    val portfolioMetaService by lazy { PortfolioMetaService(PortfolioMetaRepository(firestore)) }
+    val firestore = FirestoreProvider.create(appConfig)
+    val portfolioMetaService = PortfolioMetaService(PortfolioMetaRepository(firestore))
 
     environment.monitor.subscribe(ApplicationStopped) {
-        if (firestoreLazy.isInitialized()) {
-            runCatching { firestore.close() }
-                .onFailure { throwable -> log.warn("Failed to close Firestore", throwable) }
-        }
+        runCatching { firestore.close() }
+            .onFailure { throwable -> log.warn("Failed to close Firestore", throwable) }
     }
 
     install(DefaultHeaders)