fix: align agent-sdk receipt APIs with runtime-core 1.2.0#48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
@commandlayer/runtime-core1.2.0, causing TypeScript build errors and broken signing/verification flows.Description
src/receipt.tsto remove non-existent type imports, stop treatingCommandLayerReceiptas a generic, and call the runtime-core signer assignCommandLayerReceipt(receipt, { privateKeyPem, kid })instead of the old object-shaped param; this adapts the SDK to the runtime-core 1.2 signing API.DEFAULT_CANONICALIZATIONand validation insrc/index.tsto accept the SDK constructorcanonicalizationfor compatibility but enforce that it equals"json.sorted_keys.v1", rejecting other values.test/receipt.test.tsto export the generated key's SPKI PEM and callverifyCommandLayerReceipt(receipt, { publicKeyPemOrDer }), and updated the expected verification status to"VERIFIED"for a valid receipt.src/receipt.ts,src/index.ts, andtest/receipt.test.ts; runtime-core API shapes used includesignCommandLayerReceipt(receipt, options)andverifyCommandLayerReceipt(receipt, { publicKeyPemOrDer }), andCommandLayerReceiptis consumed as a non-generic type.Testing
npm install, which failed in the current environment due to403 Forbiddenwhen fetching@commandlayer/runtime-core, so dependency installation did not complete.npm run build, which failed because dependencies and type declarations were unavailable after the install failure, producing TypeScript errors for missing modules and node types.npm test, which also failed becausepretestruns the build step that failed for the same dependency/type availability reason.Codex Task