Make verifier ENS-first and gate local key fallback to explicit test/demo mode#319
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
cl.sig.pub,cl.sig.kid,cl.sig.canonical, andcl.receipt.signerfrom ENS TXT records before any fallback is considered.Description
lib/verifyReceipt.jsto resolve required ENS TXT keys first and to reportpublic_key_sourceasens_txton successful ENS resolution andlocal_test_fallbackwhen the explicit local fallback is used.options.ens.allowLocalFallback === true,COMMANDLAYER_ALLOW_LOCAL_KEY_FALLBACK=true, orNODE_ENV === 'test', and returnINVALIDwithreason: ens_key_unavailablewhen ENS keys are missing and fallback is not allowed.public_key_sourcethrough the verify agent API by adding it toapi/agents/verifyagent.jsresponses and updatedverifyReceiptdebug output to includekey_resolution_error.tests/verifyReceipt-runtime.test.js,tests/api-verify.test.js, andtests/api-agents-verifyagent.test.jsto assert ENS-first behavior, explicit-fallback behavior, and thatpublic_key_sourceis exposed; and updatedREADME.mdto document the key resolution policy.Testing
npm testwhich completed successfully (97 passed, 0 failed).public_key_source: ens_txt, ENS missing with fallback disabled returnsreason: ens_key_unavailable, and explicit local fallback yieldspublic_key_source: local_test_fallbackin test/demo mode.npm run check:linkswhich failed because thecheck:linksscript is not defined inpackage.json.Codex Task