Audit RPC/ENS env usage and add production RPC env guidance#327
Merged
GsCommand merged 1 commit intoMay 24, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
getMainnetRpcUrl()toapi/ens/owned.jsand updatedhasProviderConfig()to accept a prioritized RPC env resolution order includingETHEREUM_RPC_URL,MAINNET_RPC_URL,ALCHEMY_ETHEREUM_RPC_URL,ALCHEMY_ETH_RPC_URL,ETH_RPC_URL, andALCHEMY_API_KEY(mapped tohttps://eth-mainnet.g.alchemy.com/v2/<key>if present).ethers.AlchemyProvider(...)fallback with aJsonRpcProviderthat is only initialized when a concrete RPC URL is resolved so the code no longer triggers Alchemy default-key behavior._private.getMainnetRpcUrlfor unit testing and added tests intests/api-ens-owned.test.jscovering env precedence, Alchemy key-to-URL derivation, and last-resort empty behavior; kept SimpleHash ownership lookup logic separate.docs/ops/environment.mddocumenting preferred production RPC variables and a table of required/optional env vars (includingCOMMANDLAYER_ALLOW_LOCAL_KEY_FALLBACKwarning andSIMPLEHASH_API_KEYusage), and added a short README pointer to that doc.Testing
npm testand all tests passed (113tests,0failures).npm run check:linksand it passed with "All local links/assets resolved across 25 HTML files."tests/api-ens-owned.test.jswhich passed and validate the RPC precedence and Alchemy URL derivation behavior.erc8211.merkle.v1(no matches) and noted an unrelatednpm warn Unknown env config "http-proxy"which is not a code regression.Codex Task