nerdctl/mounts label too long

[cielavenir]

Description

sudo ~/Downloads/nerdctl-2.2.0-linux-amd64/nerdctl run --namespace moby --privileged -it --rm --entrypoint bash IMAGE shows this

FATA[0000] create container failed validation: containers.Labels: label key and value length (5005 bytes) greater than maximum size (4096 bytes), key: nerdctl/mounts: invalid argument

Steps to reproduce the issue

Describe the results you received and expected

The container should be started

What version of nerdctl are you using?

2.2.2/1.6.0/0.19.0

Are you using a variant of nerdctl? (e.g., Rancher Desktop)

None

Host information

Debian 13

$ cat /proc/cmdline 
ro SYSTEMD_CGROUP_ENABLE_LEGACY_FORCE=1 systemd.unified_cgroup_hierarchy=0 split_lock_detect=off kvm.enable_virt_at_load=0 quiet splash

[cielavenir]

so far my observations

sudo ~/Downloads/nerdctl-0.18.0-linux-amd64/nerdctl run --namespace moby --privileged -it --rm --entrypoint bash

this does not have issue

sudo ~/Downloads/nerdctl-0.19.0-linux-amd64/nerdctl run --namespace moby --privileged -it --rm --entrypoint bash

this has issue

sudo ~/Downloads/nerdctl-0.19.0-linux-amd64/nerdctl' run --namespace moby --privileged -it --rm --entrypoint bash --tmpfs /private --tmpfs /var/lib/xkb --tmpfs /var/lib/apt/lists --tmpfs /var/lib/nfs --tmpfs /media --tmpfs /mnt

this does not have issue

[cielavenir]

our image's implicit mounts are interpreted like this, when nerdctl --debug is used

DEBU[0000] creating anonymous volume "95d86d1e8fd39850e5015fbe63ee37b1c7c6a12983f9ba4d5a32493e9fc9c42d", for "VOLUME /var/lib/docker" 
DEBU[0000] creating anonymous volume "1b456febed4e78dc0922d5c8ea0d995b41121dd31af6920f9adc79883433155f", for "VOLUME /etc/docker" 
DEBU[0000] creating anonymous volume "c883a08a7d23ccbd5772f4802f86dce64b01d5d50fb549e67f534fd0b52dddeb", for "VOLUME /home" 
DEBU[0000] creating anonymous volume "11b234347f414ce9410017fa2be8ac6545e6db47763dfae617c3e8bb7ed1d9ec", for "VOLUME /opt/debug" 
DEBU[0000] creating anonymous volume "1809b01c6f7f1dd6656d1594558694879e7f4eacfbf682c6fd5ec501624ea210", for "VOLUME /run" 
DEBU[0000] creating anonymous volume "f9da5a7d7f74d55c22f171511c8e126880c0655ed1fee10c4d0b792e9672dae2", for "VOLUME /data" 
DEBU[0000] creating anonymous volume "cb03ba49e59b9920d3a5861bdcf17d38ce618ee2cf9680d1733bc8eaf943a5a9", for "VOLUME /tmp" 
DEBU[0000] creating anonymous volume "6293056a6a51786319d7ea0fc39666c54d21928aaa1c896bcd1226716e2b6ce6", for "VOLUME /var/tmp" 
DEBU[0000] creating anonymous volume "f36ea4b0b0fdecb5939df5749ab46d1978f1f8562c3a45c88cf8573ab2b47631", for "VOLUME /var/log" 
DEBU[0000] creating anonymous volume "3113a6817af50698b1fb220d6538265e312e0afa6761c6a95a7cbf5d60acfee0", for "VOLUME /root" 
DEBU[0000] creating anonymous volume "435f0c4b90b5cb4a20578c72be02c42ae0c00ac339d0ac267e18e75741c312a5", for "VOLUME /var/cache"

[cielavenir]

0.19.0 added nerdctl container inspect mount field https://github.com/containerd/nerdctl/releases/tag/v0.19.0 in #822

the label length issue was a warning after containerd/containerd#6124 but now it seems an error

this can be considered as a feature request to make this mount field label optional

[ningmingxiao]

we can use extensions or annonations instead

[ningmingxiao]

can you assign me ? I can have a try to fix it @cielavenir

[cielavenir]

@ningmingxiao I cannot set assignee (as I'm not the organization member)

though if pull requests can be provided it would be appreciated

[ningmingxiao]

thanks. I will create a pr tomorrow. @cielavenir