fix: resolve false Go/gofmt not-installed warnings on Windows and unify tool detection#59
Open
Zireael wants to merge 1 commit into
Open
fix: resolve false Go/gofmt not-installed warnings on Windows and unify tool detection#59Zireael wants to merge 1 commit into
Zireael wants to merge 1 commit into
Conversation
…fy tool detection
There was a problem hiding this comment.
No issues found across 1 file
Tip: cubic could auto-approve low-risk PRs like this, if it thinks it's safe to merge. Learn more
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #58. Addresses reviewer feedback:
Fixed
AFT_DISABLE_WELL_KNOWN_LOOKUPenv-var bypass on Windows — moved the test escape hatch above thecfg!(windows)branch intry_well_known_path_lookupso integration tests can suppress well-known-path lookup on all platforms.Fixed missing spaces in
install_hint("go")strings — added trailing spaces before\line-continuation characters to prevent concatenated words like"—ensure"and"uses/opt/homebrew/bin".See discussion: #58 (comment)
Summary by cubic
Fixes false “Go/gofmt not installed” warnings on Windows by searching common install locations when PATH is incomplete. Also unifies tool detection across OSes and improves
goinstall hints.Bug Fixes
gotools (C:\Go\bin, C:\Program Files\Go\bin, %USERPROFILE%.cargo\bin, %USERPROFILE%\go\bin) to avoid false missinggo,gofmt,goplswarnings.AFT_DISABLE_WELL_KNOWN_LOOKUPbefore platform checks so tests can disable fallback lookup on all OSes.install_hint("go")spacing and added a Windows-specific hint with common paths.Refactors
resolve_tool_uncachedaspub(crate)for tests.well_known_windows_search_pathsandtry_well_known_path_lookup_into make lookup behavior easier to test.Written for commit bd54f5a. Summary will update on new commits. Review in cubic