Fix pcre linking

Author: pfultz2

cli/CMakeLists.txt

@@ -24,9 +24,6 @@ if (BUILD_CLI)
 
     add_executable(cppcheck ${cppcheck_SOURCES})
     target_link_libraries(cppcheck cppcheck-core cli tinyxml2 simplecpp)
-    if (HAVE_RULES)
-        target_link_libraries(cppcheck ${PCRE_LIBRARY})
-    endif()
     if (WIN32 AND NOT BORLAND)
         if(NOT MINGW)
             target_link_libraries(cppcheck Shlwapi.lib)

gui/test/xmlreportv2/CMakeLists.txt

@@ -9,15 +9,9 @@ add_executable(test-xmlreportv2
         ${CMAKE_SOURCE_DIR}/gui/xmlreport.cpp
         ${CMAKE_SOURCE_DIR}/gui/xmlreportv2.cpp
         )
-target_include_directories(test-xmlreportv2 PRIVATE ${CMAKE_SOURCE_DIR}/gui ${CMAKE_SOURCE_DIR}/lib)
+target_include_directories(test-xmlreportv2 PRIVATE ${CMAKE_SOURCE_DIR}/gui)
 target_compile_definitions(test-xmlreportv2 PRIVATE SRCDIR="${CMAKE_CURRENT_SOURCE_DIR}")
 target_link_libraries(test-xmlreportv2 ${QT_CORE_LIB} ${QT_TEST_LIB} cppcheck-core)
-if (HAVE_RULES)
-    target_link_libraries(test-xmlreportv2 ${PCRE_LIBRARY})
-endif()
-if(tinyxml2_FOUND AND NOT USE_BUNDLED_TINYXML2)
-    target_link_libraries(test-xmlreportv2 ${tinyxml2_LIBRARIES})
-endif()
 if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
     if(QT_VERSION VERSION_LESS "6.0.0")
         # Q_UNUSED() in generated code - see https://bugreports.qt.io/browse/QTBUG-82978

lib/CMakeLists.txt

@@ -55,7 +55,7 @@ target_dll_compile_definitions(cppcheck-core EXPORT CPPCHECKLIB_EXPORT)
 target_dll_compile_definitions(cppcheck-core-private IMPORT CPPCHECKLIB_IMPORT)
 
 target_include_directories(cppcheck-core INTERFACE .)
-foreach(lib tinyxml2 simplecpp picojson)
+foreach(lib tinyxml2 simplecpp picojson ${PCRE_LIBRARY})
     if (NOT BUILD_SHARED_LIBS)
         target_link_libraries(cppcheck-core INTERFACE $<LINK_ONLY:${lib}>)
     endif()

test/CMakeLists.txt

@@ -8,9 +8,6 @@ if (BUILD_TESTS)
 
     add_executable(testrunner ${testrunner_SOURCES})
     target_link_libraries(testrunner cppcheck-core tinyxml2 simplecpp frontend cli)
-    if (HAVE_RULES)
-        target_link_libraries(testrunner ${PCRE_LIBRARY})
-    endif()
     if (WIN32 AND NOT BORLAND)
         if(NOT MINGW)
             target_link_libraries(testrunner Shlwapi.lib)