Update checkclass.cpp

Author: chrchr-github

lib/checkclass.cpp

@@ -2594,20 +2594,20 @@ bool CheckClass::checkConstFunc(const Scope *scope, const Function *func, Member
 
             auto isConstContainerUsage = [&](const ValueType* vt) -> bool {
                 if (!vt || !vt->container)
-                    return false;
+                    return false;                
                 const auto yield = vt->container->getYield(end->str());
-                if (contains({Library::Container::Yield::START_ITERATOR, Library::Container::Yield::END_ITERATOR, Library::Container::Yield::ITERATOR}, yield)) {
-                    const Token* parent = tok1->astParent();
+                const Token* parent = tok1->astParent();
                     while (Token::Match(parent, "(|.|::"))
                         parent = parent->astParent();
+                if (contains({Library::Container::Yield::START_ITERATOR, Library::Container::Yield::END_ITERATOR, Library::Container::Yield::ITERATOR}, yield)) {
                     if (parent && parent->isComparisonOp())
                         return true;
                     // TODO: use AST
                     if (parent && parent->isAssignmentOp() && tok1->tokAt(-2)->variable() && Token::Match(tok1->tokAt(-2)->variable()->typeEndToken(), "const_iterator|const_reverse_iterator"))
                         return true;
                 }
                 if ((yield == Library::Container::Yield::ITEM || yield == Library::Container::Yield::AT_INDEX) &&
-                    (lhs->isComparisonOp() || lhs->isAssignmentOp() || (lhs->str() == "(" && Token::Match(lhs->astParent(), "%cop%"))))
+                    ((parent && parent->isComparisonOp()) || lhs->isAssignmentOp()))
                     return true; // assume that these functions have const overloads
                 return false;
             };