do not pass POD types by reference (based on clazy function-args-by-value check) (#5388)

firewave · web-flow · commit 02b836baad2a · 2023-09-11T20:40:39.000+02:00
diff --git a/gui/codeeditorstyle.cpp b/gui/codeeditorstyle.cpp
@@ -32,16 +32,17 @@ CodeEditorStyle::CodeEditorStyle(
     // cppcheck-suppress naming-varname - TODO: fix this
     QColor LnNumFGColor, QColor LnNumBGColor,
     // cppcheck-suppress naming-varname - TODO: fix this
-    QColor KeyWdFGColor, const QFont::Weight& KeyWdWeight,
+    QColor KeyWdFGColor, QFont::Weight KeyWdWeight,
     // cppcheck-suppress naming-varname - TODO: fix this
-    QColor ClsFGColor, const QFont::Weight& ClsWeight,
+    QColor ClsFGColor, QFont::Weight ClsWeight,
     // cppcheck-suppress naming-varname - TODO: fix this
-    QColor QteFGColor, const QFont::Weight& QteWeight,
+    QColor QteFGColor, QFont::Weight QteWeight,
     // cppcheck-suppress naming-varname - TODO: fix this
-    QColor CmtFGColor, const QFont::Weight& CmtWeight,
+    QColor CmtFGColor, QFont::Weight CmtWeight,
     // cppcheck-suppress naming-varname - TODO: fix this
     QColor SymbFGColor, QColor SymbBGColor,
-    const QFont::Weight& SymbWeight) :
+    // cppcheck-suppress naming-varname - TODO: fix this
+    QFont::Weight SymbWeight) :
     widgetFGColor(std::move(CtrlFGColor)),
     widgetBGColor(std::move(CtrlBGColor)),
     highlightBGColor(std::move(HiLiBGColor)),
diff --git a/gui/codeeditorstyle.h b/gui/codeeditorstyle.h
@@ -58,16 +58,17 @@ class CodeEditorStyle {
         // cppcheck-suppress naming-varname - TODO: fix this
         QColor LnNumFGColor, QColor LnNumBGColor,
         // cppcheck-suppress naming-varname - TODO: fix this
-        QColor KeyWdFGColor, const QFont::Weight& KeyWdWeight,
+        QColor KeyWdFGColor, QFont::Weight KeyWdWeight,
         // cppcheck-suppress naming-varname - TODO: fix this
-        QColor ClsFGColor, const QFont::Weight& ClsWeight,
+        QColor ClsFGColor, QFont::Weight ClsWeight,
         // cppcheck-suppress naming-varname - TODO: fix this
-        QColor QteFGColor, const QFont::Weight& QteWeight,
+        QColor QteFGColor, QFont::Weight QteWeight,
         // cppcheck-suppress naming-varname - TODO: fix this
-        QColor CmtFGColor, const QFont::Weight& CmtWeight,
+        QColor CmtFGColor, QFont::Weight CmtWeight,
         // cppcheck-suppress naming-varname - TODO: fix this
         QColor SymbFGColor, QColor SymbBGColor,
-        const QFont::Weight& SymbWeight);
+        // cppcheck-suppress naming-varname - TODO: fix this
+        QFont::Weight SymbWeight);
 
     bool operator==(const CodeEditorStyle& rhs) const;
     bool operator!=(const CodeEditorStyle& rhs) const;
diff --git a/gui/codeeditstylecontrols.cpp b/gui/codeeditstylecontrols.cpp
@@ -113,7 +113,7 @@ void SelectFontWeightCombo::changeWeight(int index)
     }
 }
 
-void SelectFontWeightCombo::setWeight(const QFont::Weight& weight)
+void SelectFontWeightCombo::setWeight(QFont::Weight weight)
 {
     mWeight = weight;
     updateWeight();
diff --git a/gui/codeeditstylecontrols.h b/gui/codeeditstylecontrols.h
@@ -57,12 +57,12 @@ class SelectFontWeightCombo : public QComboBox {
 public:
     explicit SelectFontWeightCombo(QWidget* parent);
 
-    void setWeight(const QFont::Weight& weight);
+    void setWeight(QFont::Weight weight);
     const QFont::Weight& getWeight();
 
 signals:
     // NOLINTNEXTLINE(readability-inconsistent-declaration-parameter-name) - caused by generated MOC code
-    void weightChanged(const QFont::Weight& newWeight);
+    void weightChanged(QFont::Weight newWeight);
 
 public slots:
     void updateWeight();
diff --git a/gui/codeeditstyledialog.cpp b/gui/codeeditstyledialog.cpp
@@ -296,7 +296,7 @@ void StyleEditDialog::colorChangedKeywordFG(const QColor& newColor)
     updateStyle();
 }
 
-void StyleEditDialog::weightChangedKeyword(const QFont::Weight& newWeight)
+void StyleEditDialog::weightChangedKeyword(QFont::Weight newWeight)
 {
     mStyleOutgoing.keywordWeight = newWeight;
     updateStyle();
@@ -308,7 +308,7 @@ void StyleEditDialog::colorChangedClassFG(const QColor& newColor)
     updateStyle();
 }
 
-void StyleEditDialog::weightChangedClass(const QFont::Weight& newWeight)
+void StyleEditDialog::weightChangedClass(QFont::Weight newWeight)
 {
     mStyleOutgoing.classWeight = newWeight;
     updateStyle();
@@ -320,7 +320,7 @@ void StyleEditDialog::colorChangedQuoteFG(const QColor& newColor)
     updateStyle();
 }
 
-void StyleEditDialog::weightChangedQuote(const QFont::Weight& newWeight)
+void StyleEditDialog::weightChangedQuote(QFont::Weight newWeight)
 {
     mStyleOutgoing.quoteWeight = newWeight;
     updateStyle();
@@ -332,7 +332,7 @@ void StyleEditDialog::colorChangedCommentFG(const QColor& newColor)
     updateStyle();
 }
 
-void StyleEditDialog::weightChangedComment(const QFont::Weight& newWeight)
+void StyleEditDialog::weightChangedComment(QFont::Weight newWeight)
 {
     mStyleOutgoing.commentWeight = newWeight;
     updateStyle();
@@ -350,7 +350,7 @@ void StyleEditDialog::colorChangedSymbolBG(const QColor& newColor)
     updateStyle();
 }
 
-void StyleEditDialog::weightChangedSymbol(const QFont::Weight& newWeight)
+void StyleEditDialog::weightChangedSymbol(QFont::Weight newWeight)
 {
     mStyleOutgoing.symbolWeight = newWeight;
     updateStyle();
diff --git a/gui/codeeditstyledialog.h b/gui/codeeditstyledialog.h
@@ -59,16 +59,16 @@ public slots:
     void colorChangedLineNumFG(const QColor& newColor);
     void colorChangedLineNumBG(const QColor& newColor);
     void colorChangedKeywordFG(const QColor& newColor);
-    void weightChangedKeyword(const QFont::Weight& newWeight);
+    void weightChangedKeyword(QFont::Weight newWeight);
     void colorChangedClassFG(const QColor& newColor);
-    void weightChangedClass(const QFont::Weight& newWeight);
+    void weightChangedClass(QFont::Weight newWeight);
     void colorChangedQuoteFG(const QColor& newColor);
-    void weightChangedQuote(const QFont::Weight& newWeight);
+    void weightChangedQuote(QFont::Weight newWeight);
     void colorChangedCommentFG(const QColor& newColor);
-    void weightChangedComment(const QFont::Weight& newWeight);
+    void weightChangedComment(QFont::Weight newWeight);
     void colorChangedSymbolFG(const QColor& newColor);
     void colorChangedSymbolBG(const QColor& newColor);
-    void weightChangedSymbol(const QFont::Weight& newWeight);
+    void weightChangedSymbol(QFont::Weight newWeight);
 
 private:
     CodeEditorStyle mStyleIncoming;
diff --git a/lib/checkstl.cpp b/lib/checkstl.cpp
@@ -65,7 +65,7 @@ static const struct CWE CWE825(825U);   // Expired Pointer Dereference
 static const struct CWE CWE833(833U);   // Deadlock
 static const struct CWE CWE834(834U);   // Excessive Iteration
 
-static bool isElementAccessYield(const Library::Container::Yield& yield)
+static bool isElementAccessYield(Library::Container::Yield yield)
 {
     return contains({Library::Container::Yield::ITEM, Library::Container::Yield::AT_INDEX}, yield);
 }
diff --git a/lib/color.cpp b/lib/color.cpp
@@ -40,7 +40,7 @@ static bool isStreamATty(const std::ostream & os)
 }
 #endif
 
-std::ostream& operator<<(std::ostream & os, const Color& c)
+std::ostream& operator<<(std::ostream & os, Color c)
 {
 #ifndef _WIN32
     if (!gDisableColors && isStreamATty(os))
@@ -51,7 +51,7 @@ std::ostream& operator<<(std::ostream & os, const Color& c)
     return os;
 }
 
-std::string toString(const Color& c)
+std::string toString(Color c)
 {
 #ifndef _WIN32
     std::stringstream ss;
diff --git a/lib/color.h b/lib/color.h
@@ -34,9 +34,9 @@ enum class Color {
     FgMagenta  = 35,
     FgDefault  = 39
 };
-CPPCHECKLIB std::ostream& operator<<(std::ostream& os, const Color& c);
+CPPCHECKLIB std::ostream& operator<<(std::ostream& os, Color c);
 
-CPPCHECKLIB std::string toString(const Color& c);
+CPPCHECKLIB std::string toString(Color c);
 
 extern CPPCHECKLIB bool gDisableColors; // for testing
 
diff --git a/lib/symboldatabase.cpp b/lib/symboldatabase.cpp
@@ -3662,7 +3662,7 @@ static std::ostream & operator << (std::ostream & s, Scope::ScopeType type)
     return s;
 }
 
-static std::string accessControlToString(const AccessControl& access)
+static std::string accessControlToString(AccessControl access)
 {
     switch (access) {
     case AccessControl::Public:
diff --git a/lib/tokenize.cpp b/lib/tokenize.cpp
@@ -7965,7 +7965,7 @@ void Tokenizer::unhandledCharLiteral(const Token *tok, const std::string& msg) c
  * @param floatConstant the string with stringified float constant to check against
  * @return true in case s is equal to X or X.0 and false otherwise.
  */
-static bool isNumberOneOf(const std::string &s, const MathLib::bigint& intConstant, const char* floatConstant)
+static bool isNumberOneOf(const std::string &s, MathLib::bigint intConstant, const char* floatConstant)
 {
     if (MathLib::isInt(s)) {
         if (MathLib::toLongNumber(s) == intConstant)

Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ void SelectFontWeightCombo::changeWeight(int index)`
`113`	`113`	`}`
`114`	`114`	`}`
`115`	`115`
`116`		`-void SelectFontWeightCombo::setWeight(const QFont::Weight& weight)`
	`116`	`+void SelectFontWeightCombo::setWeight(QFont::Weight weight)`
`117`	`117`	`{`
`118`	`118`	`mWeight = weight;`
`119`	`119`	`updateWeight();`
Original file line number	Diff line number	Diff line change
`@@ -296,7 +296,7 @@ void StyleEditDialog::colorChangedKeywordFG(const QColor& newColor)`
`296`	`296`	`updateStyle();`
`297`	`297`	`}`
`298`	`298`
`299`		`-void StyleEditDialog::weightChangedKeyword(const QFont::Weight& newWeight)`
	`299`	`+void StyleEditDialog::weightChangedKeyword(QFont::Weight newWeight)`
`300`	`300`	`{`
`301`	`301`	`mStyleOutgoing.keywordWeight = newWeight;`
`302`	`302`	`updateStyle();`
`@@ -308,7 +308,7 @@ void StyleEditDialog::colorChangedClassFG(const QColor& newColor)`
`308`	`308`	`updateStyle();`
`309`	`309`	`}`
`310`	`310`
`311`		`-void StyleEditDialog::weightChangedClass(const QFont::Weight& newWeight)`
	`311`	`+void StyleEditDialog::weightChangedClass(QFont::Weight newWeight)`
`312`	`312`	`{`
`313`	`313`	`mStyleOutgoing.classWeight = newWeight;`
`314`	`314`	`updateStyle();`
`@@ -320,7 +320,7 @@ void StyleEditDialog::colorChangedQuoteFG(const QColor& newColor)`
`320`	`320`	`updateStyle();`
`321`	`321`	`}`
`322`	`322`
`323`		`-void StyleEditDialog::weightChangedQuote(const QFont::Weight& newWeight)`
	`323`	`+void StyleEditDialog::weightChangedQuote(QFont::Weight newWeight)`
`324`	`324`	`{`
`325`	`325`	`mStyleOutgoing.quoteWeight = newWeight;`
`326`	`326`	`updateStyle();`
`@@ -332,7 +332,7 @@ void StyleEditDialog::colorChangedCommentFG(const QColor& newColor)`
`332`	`332`	`updateStyle();`
`333`	`333`	`}`
`334`	`334`
`335`		`-void StyleEditDialog::weightChangedComment(const QFont::Weight& newWeight)`
	`335`	`+void StyleEditDialog::weightChangedComment(QFont::Weight newWeight)`
`336`	`336`	`{`
`337`	`337`	`mStyleOutgoing.commentWeight = newWeight;`
`338`	`338`	`updateStyle();`
`@@ -350,7 +350,7 @@ void StyleEditDialog::colorChangedSymbolBG(const QColor& newColor)`
`350`	`350`	`updateStyle();`
`351`	`351`	`}`
`352`	`352`
`353`		`-void StyleEditDialog::weightChangedSymbol(const QFont::Weight& newWeight)`
	`353`	`+void StyleEditDialog::weightChangedSymbol(QFont::Weight newWeight)`
`354`	`354`	`{`
`355`	`355`	`mStyleOutgoing.symbolWeight = newWeight;`
`356`	`356`	`updateStyle();`
Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ static const struct CWE CWE825(825U); // Expired Pointer Dereference`
`65`	`65`	`static const struct CWE CWE833(833U); // Deadlock`
`66`	`66`	`static const struct CWE CWE834(834U); // Excessive Iteration`
`67`	`67`
`68`		`-static bool isElementAccessYield(const Library::Container::Yield& yield)`
	`68`	`+static bool isElementAccessYield(Library::Container::Yield yield)`
`69`	`69`	`{`
`70`	`70`	`return contains({Library::Container::Yield::ITEM, Library::Container::Yield::AT_INDEX}, yield);`
`71`	`71`	`}`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ static bool isStreamATty(const std::ostream & os)`
`40`	`40`	`}`
`41`	`41`	`#endif`
`42`	`42`
`43`		`-std::ostream& operator<<(std::ostream & os, const Color& c)`
	`43`	`+std::ostream& operator<<(std::ostream & os, Color c)`
`44`	`44`	`{`
`45`	`45`	`#ifndef _WIN32`
`46`	`46`	`if (!gDisableColors && isStreamATty(os))`
`@@ -51,7 +51,7 @@ std::ostream& operator<<(std::ostream & os, const Color& c)`
`51`	`51`	`return os;`
`52`	`52`	`}`
`53`	`53`
`54`		`-std::string toString(const Color& c)`
	`54`	`+std::string toString(Color c)`
`55`	`55`	`{`
`56`	`56`	`#ifndef _WIN32`
`57`	`57`	`std::stringstream ss;`
Original file line number	Diff line number	Diff line change
`@@ -3662,7 +3662,7 @@ static std::ostream & operator << (std::ostream & s, Scope::ScopeType type)`
`3662`	`3662`	`return s;`
`3663`	`3663`	`}`
`3664`	`3664`
`3665`		`-static std::string accessControlToString(const AccessControl& access)`
	`3665`	`+static std::string accessControlToString(AccessControl access)`
`3666`	`3666`	`{`
`3667`	`3667`	`switch (access) {`
`3668`	`3668`	`case AccessControl::Public:`