valueflow.cpp: avoid unnecessary copies in valueFlowFunctionReturn()

firewave · firewave · commit 0d6add0a7194 · 2026-02-13T16:14:48.000+01:00
diff --git a/lib/valueflow.cpp b/lib/valueflow.cpp
@@ -5844,10 +5844,10 @@ static void valueFlowFunctionReturn(TokenList& tokenlist, ErrorLogger& errorLogg
         if (programMemory.empty() && !arguments.empty())
             continue;
         std::vector<ValueFlow::Value> values = execute(function->functionScope, programMemory, settings);
-        for (const ValueFlow::Value& v : values) {
+        for (ValueFlow::Value& v : values) {
             if (v.isUninitValue())
                 continue;
-            setFunctionReturnValue(function, tok, v, settings);
+            setFunctionReturnValue(function, tok, std::move(v), settings);
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -5844,10 +5844,10 @@ static void valueFlowFunctionReturn(TokenList& tokenlist, ErrorLogger& errorLogg`
`5844`	`5844`	`if (programMemory.empty() && !arguments.empty())`
`5845`	`5845`	`continue;`
`5846`	`5846`	`std::vector<ValueFlow::Value> values = execute(function->functionScope, programMemory, settings);`
`5847`		`- for (const ValueFlow::Value& v : values) {`
	`5847`	`+ for (ValueFlow::Value& v : values) {`
`5848`	`5848`	`if (v.isUninitValue())`
`5849`	`5849`	`continue;`
`5850`		`- setFunctionReturnValue(function, tok, v, settings);`
	`5850`	`+ setFunctionReturnValue(function, tok, std::move(v), settings);`
`5851`	`5851`	`}`
`5852`	`5852`	`}`
`5853`	`5853`	`}`