ValueFlow: avoid unnecessary copy in getLifetimeObjValue()

firewave · firewave · commit 0edd83e5f88c · 2026-02-13T09:50:41.000+01:00
diff --git a/lib/valueflow.cpp b/lib/valueflow.cpp
@@ -1511,7 +1511,7 @@ ValueFlow::Value ValueFlow::getLifetimeObjValue(const Token *tok, bool inconclus
     // There should only be one lifetime
     if (values.size() != 1)
         return ValueFlow::Value{};
-    return values.front();
+    return std::move(values.front());
 }
 
 template<class Predicate>

Original file line number	Diff line number	Diff line change
`@@ -1511,7 +1511,7 @@ ValueFlow::Value ValueFlow::getLifetimeObjValue(const Token *tok, bool inconclus`
`1511`	`1511`	`// There should only be one lifetime`
`1512`	`1512`	`if (values.size() != 1)`
`1513`	`1513`	`return ValueFlow::Value{};`
`1514`		`- return values.front();`
	`1514`	`+ return std::move(values.front());`
`1515`	`1515`	`}`
`1516`	`1516`
`1517`	`1517`	`template<class Predicate>`