ValueFlow: avoid unnecessary copy in getLifetimeObjValue()

firewave · firewave · commit 14f1242f400d · 2025-06-10T12:34:38.000+02:00
diff --git a/lib/valueflow.cpp b/lib/valueflow.cpp
@@ -1644,7 +1644,7 @@ ValueFlow::Value ValueFlow::getLifetimeObjValue(const Token *tok, bool inconclus
     // There should only be one lifetime
     if (values.size() != 1)
         return ValueFlow::Value{};
-    return values.front();
+    return std::move(values.front());
 }
 
 template<class Predicate>

Original file line number	Diff line number	Diff line change
`@@ -1644,7 +1644,7 @@ ValueFlow::Value ValueFlow::getLifetimeObjValue(const Token *tok, bool inconclus`
`1644`	`1644`	`// There should only be one lifetime`
`1645`	`1645`	`if (values.size() != 1)`
`1646`	`1646`	`return ValueFlow::Value{};`
`1647`		`- return values.front();`
	`1647`	`+ return std::move(values.front());`
`1648`	`1648`	`}`
`1649`	`1649`
`1650`	`1650`	`template<class Predicate>`