fix column number being 0 issue

Author: Nettozx

cli/cppcheckexecutor.cpp

@@ -413,11 +413,13 @@ namespace {
                 artifactLocation["uri"]              = picojson::value(location.getfile(false));
                 physicalLocation["artifactLocation"] = picojson::value(artifactLocation);
                 picojson::object region;
-                // Ensure line numbers are always positive (SARIF requires positive line numbers)
+                // Ensure line numbers are always positive (SARIF requires line numbers >= 1)
                 const int64_t lineNumber = (location.line > 0) ? location.line : 1;
                 region["startLine"]        = picojson::value(lineNumber);
                 region["endLine"]          = region["startLine"];
-                region["startColumn"]      = picojson::value(static_cast<int64_t>(location.column));
+                // Ensure column numbers are always positive (SARIF requires column numbers >= 1)
+                const int64_t columnNumber = (location.column > 0) ? location.column : 1;
+                region["startColumn"]      = picojson::value(columnNumber);
                 region["endColumn"]        = region["startColumn"];
                 physicalLocation["region"] = picojson::value(region);
                 picojson::object loc;

test/testsarif.cpp

@@ -559,7 +559,7 @@ int main() {
                 ASSERT(region.find("startLine") != region.end());
                 ASSERT(region.find("startColumn") != region.end());
 
-                // Line numbers should be positive, columns can be 0 or positive
+                // Line numbers should be positive, columns should be positive (SARIF requires >= 1)
                 if (region.at("startLine").is<double>())
                 {
                     const int64_t line = static_cast<int64_t>(region.at("startLine").get<double>());
@@ -569,7 +569,7 @@ int main() {
                 if (region.at("startColumn").is<double>())
                 {
                     const int64_t col = static_cast<int64_t>(region.at("startColumn").get<double>());
-                    ASSERT(col >= 0);
+                    ASSERT(col > 0);
                 }
             }
         }