Fix #12916 False positive: negative shift in macro (string << i) (#6581)

Author: chrchr-github

lib/checkother.cpp

@@ -2999,7 +2999,7 @@ void CheckOther::checkNegativeBitwiseShift()
         // don't warn if lhs is a class. this is an overloaded operator then
         if (tok->isCpp()) {
             const ValueType * lhsType = tok->astOperand1()->valueType();
-            if (!lhsType || !lhsType->isIntegral())
+            if (!lhsType || !lhsType->isIntegral() || lhsType->pointer)
                 continue;
         }
 

test/testother.cpp

@@ -9113,6 +9113,13 @@ class TestOther : public TestFixture {
                       "[test.cpp:2]: (error) Shifting by a negative value is undefined behaviour\n"
                       "[test.cpp:3]: (portability) Shifting a negative value is technically undefined behaviour\n"
                       "[test.cpp:4]: (portability) Shifting a negative value is technically undefined behaviour\n", errout_str());
+
+        check("void f(int i) {\n" // #12916
+              "    if (i < 0) {\n"
+              "        g(\"abc\" << i);\n"
+              "    }\n"
+              "}\n");
+        ASSERT_EQUALS("", errout_str());
     }
 
     void incompleteArrayFill() {