Fix #12946 Calling base class on different object is ignored (#6606)

Author: chrchr-github

lib/checkclass.cpp

@@ -3296,6 +3296,8 @@ void CheckClass::checkUselessOverride()
             if (const Token* const call = getSingleFunctionCall(func.functionScope)) {
                 if (call->function() != baseFunc)
                     continue;
+                if (Token::simpleMatch(call->astParent(), "."))
+                    continue;
                 std::vector<const Token*> funcArgs = getArguments(func.tokenDef);
                 std::vector<const Token*> callArgs = getArguments(call);
                 if (funcArgs.size() != callArgs.size() ||

test/testclass.cpp

@@ -8732,6 +8732,16 @@ class TestClass : public TestFixture {
                              "    virtual void g() { std::cout << \"Derived\\n\"; }\n"
                              "};\n");
         ASSERT_EQUALS("", errout_str());
+
+        checkUselessOverride("struct B {\n" // #12946
+                             "    virtual int f() { return i; }\n"
+                             "    int i;\n"
+                             "};\n"
+                             "struct D : B {\n"
+                             "    int f() override { return b.f(); }\n"
+                             "    B b;\n"
+                             "};\n");
+        ASSERT_EQUALS("", errout_str());
     }
 
 #define checkUnsafeClassRefMember(code) checkUnsafeClassRefMember_(code, __FILE__, __LINE__)