testresultstree.cpp: fixed -Wsuggest-attribute=noreturn GCC warnings

Author: firewave

gui/test/resultstree/CMakeLists.txt

@@ -43,11 +43,13 @@ if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
         # caused by Qt generated moc code starting with 6.9.0 - see https://bugreports.qt.io/browse/QTBUG-135638
         target_compile_options_safe(test-resultstree -Wno-ctad-maybe-unsupported)
     endif()
-    # caused by mocs
+    # caused by mocks
     target_compile_options_safe(test-resultstree -Wno-missing-noreturn)
 elseif (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
     # caused by mocs
     target_compile_options_safe(test-resultstree -Wno-useless-cast)
+    # caused by mocks
+    target_compile_options_safe(test-resultstree -Wno-suggest-attribute=noreturn)
 endif()
 
 if (REGISTER_GUI_TESTS)

gui/test/resultstree/testresultstree.cpp

@@ -29,6 +29,7 @@
 
 #include "application.h"
 #include "checkers.h"
+#include "config.h"
 #include "erroritem.h"
 #include "errorlogger.h"
 #include "errortypes.h"
@@ -85,13 +86,13 @@ ThreadHandler::~ThreadHandler() = default;
 bool ThreadHandler::isChecking() const {
     return false;
 }
-void ThreadHandler::stop() {
+NORETURN void ThreadHandler::stop() {
     throw 1;
 }
-void ThreadHandler::threadDone() {
+NORETURN void ThreadHandler::threadDone() {
     throw 1;
 }
-Application& ApplicationList::getApplication(const int /*unused*/) {
+NORETURN Application& ApplicationList::getApplication(const int /*unused*/) {
     throw 1;
 }
 const Application& ApplicationList::getApplication(const int index) const {
@@ -108,13 +109,13 @@ QString XmlReport::unquoteMessage(const QString &message) {
     return message;
 }
 XmlReport::XmlReport(const QString& filename) : Report(filename) {}
-void ThreadResult::fileChecked(const QString & /*unused*/) {
+NORETURN void ThreadResult::fileChecked(const QString & /*unused*/) {
     throw 1;
 }
-void ThreadResult::reportOut(const std::string & /*unused*/, Color /*unused*/) {
+NORETURN void ThreadResult::reportOut(const std::string & /*unused*/, Color /*unused*/) {
     throw 1;
 }
-void ThreadResult::reportErr(const ErrorMessage & /*unused*/) {
+NORETURN void ThreadResult::reportErr(const ErrorMessage & /*unused*/) {
     throw 1;
 }