CheckersReport: added workaround for "always active" checkers with UNUSEDFUNCTION_ONLY hack

Author: firewave

lib/checkersreport.cpp

@@ -143,9 +143,13 @@ void CheckersReport::countCheckers()
         ++mAllCheckersCount;
     }
     if (mSettings.premiumArgs.find("misra-c-") != std::string::npos || mSettings.addons.count("misra")) {
+        const bool doUnusedFunctionOnly = Settings::unusedFunctionOnly();
         for (const checkers::MisraInfo& info: checkers::misraC2012Rules) {
             const std::string rule = std::to_string(info.a) + "." + std::to_string(info.b);
-            const bool active = isMisraRuleActive(mActiveCheckers, rule);
+            // this will return some rules as always active even if they are not in the active checkers.
+            // this leads to a difference in the shown count and in the checkers stored in the builddir
+            // TODO: fix this?
+            const bool active = !doUnusedFunctionOnly && isMisraRuleActive(mActiveCheckers, rule);
             if (active)
                 ++mActiveCheckersCount;
             ++mAllCheckersCount;

test/cli/other_test.py

@@ -4045,14 +4045,11 @@ def test_active_unusedfunction_only_builddir(tmp_path):
 
 
 def test_active_unusedfunction_only_misra(tmp_path):
-    # TODO: should only report a single active check
-    __test_active_checkers(tmp_path, 7, 1166, use_unusedfunction_only=True, use_misra=True)
+    __test_active_checkers(tmp_path, 1, 1166, use_unusedfunction_only=True, use_misra=True)
 
 
-@pytest.mark.xfail(strict=True)  # TODO: active count and checkers.txt differ
 def test_active_unusedfunction_only_misra_builddir(tmp_path):
-    # TODO: should only report a single active check
     checkers_exp = [
         'CheckUnusedFunctions::check'
     ]
-    __test_active_checkers(tmp_path, 7, 1166, use_unusedfunction_only=True, use_misra=True, checkers_exp=checkers_exp)
+    __test_active_checkers(tmp_path, 1, 1166, use_unusedfunction_only=True, use_misra=True, checkers_exp=checkers_exp)